From 2112c8bf3a61198ca74c5aa844f54cc9c8eb0f97 Mon Sep 17 00:00:00 2001 From: Ben Walker Date: Wed, 8 Jan 2020 12:48:40 -0700 Subject: [PATCH] nvmf/tcp: Remove pdu ref count This wasn't actually used. Every PDU only had a single reference. Change-Id: I8adaa7edeca5fe175aa853c156df741170d76c10 Signed-off-by: Ben Walker Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/479902 Tested-by: SPDK CI Jenkins Community-CI: Broadcom SPDK FC-NVMe CI Community-CI: SPDK CI Jenkins Reviewed-by: Shuhei Matsumoto Reviewed-by: Ziye Yang Reviewed-by: Jim Harris --- include/spdk_internal/nvme_tcp.h | 1 - lib/nvmf/tcp.c | 14 ++------------ 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/include/spdk_internal/nvme_tcp.h b/include/spdk_internal/nvme_tcp.h index 38f607dfc..c5bf874e2 100644 --- a/include/spdk_internal/nvme_tcp.h +++ b/include/spdk_internal/nvme_tcp.h @@ -107,7 +107,6 @@ struct nvme_tcp_pdu { uint8_t ch_valid_bytes; uint8_t psh_valid_bytes; uint8_t psh_len; - int ref; nvme_tcp_qpair_xfer_complete_cb cb_fn; void *cb_arg; diff --git a/lib/nvmf/tcp.c b/lib/nvmf/tcp.c index a4a1e5264..24cd6b9be 100644 --- a/lib/nvmf/tcp.c +++ b/lib/nvmf/tcp.c @@ -328,7 +328,6 @@ spdk_nvmf_tcp_pdu_get(struct spdk_nvmf_tcp_qpair *tqpair) TAILQ_REMOVE(&tqpair->free_queue, pdu, tailq); memset(pdu, 0, sizeof(*pdu)); pdu->qpair = tqpair; - pdu->ref = 1; pdu->hdr = &pdu->hdr_mem; return pdu; @@ -337,17 +336,8 @@ spdk_nvmf_tcp_pdu_get(struct spdk_nvmf_tcp_qpair *tqpair) static void spdk_nvmf_tcp_pdu_put(struct spdk_nvmf_tcp_qpair *tqpair, struct nvme_tcp_pdu *pdu) { - if (!pdu) { - return; - } - - assert(pdu->ref > 0); - - pdu->ref--; - if (pdu->ref == 0) { - tqpair->free_pdu_num++; - TAILQ_INSERT_HEAD(&tqpair->free_queue, pdu, tailq); - } + tqpair->free_pdu_num++; + TAILQ_INSERT_HEAD(&tqpair->free_queue, pdu, tailq); } static struct spdk_nvmf_tcp_req *