ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test/vhost: remove hardcoded vhost name id

Browse Source 
This line called vhost_kill with 2 arguments:
$1 - string "0"
$2 - string "vhost_name"

Problem was that vhost_kill only accepts 1 argument, which
is "vhost_name". This was not noticed because in seems in
most of our tests we just use the name "0".
This would fail to kill a vhost instance in case it would
be named anything else than "0"

Change-Id: I635c5b92673abb7350d8bd6c636f6b794651f7ac
Signed-off-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/468201
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
This commit is contained in:
Karol Latecki 2019-09-12 08:59:10 +02:00 committed by Ben Walker
parent cc539da903
commit 1b10706ee0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/vhost/common.sh
View File

@ -124,7 +124,7 @@ function vhost_run()
local vhost_pid_file="$vhost_dir/vhost.pid" local vhost_pid_file="$vhost_dir/vhost.pid"
local vhost_socket="$vhost_dir/usvhost" local vhost_socket="$vhost_dir/usvhost"
notice "starting vhost app in background" notice "starting vhost app in background"
[[ -r "$vhost_pid_file" ]] && vhost_kill 0 $vhost_name [[ -r "$vhost_pid_file" ]] && vhost_kill $vhost_name
[[ -d $vhost_dir ]] && rm -f $vhost_dir/* [[ -d $vhost_dir ]] && rm -f $vhost_dir/*
mkdir -p $vhost_dir mkdir -p $vhost_dir