From 1b10706ee0bbf8bef46f3fabd9f7fc93f959e7ea Mon Sep 17 00:00:00 2001 From: Karol Latecki Date: Thu, 12 Sep 2019 08:59:10 +0200 Subject: [PATCH] test/vhost: remove hardcoded vhost name id This line called vhost_kill with 2 arguments: $1 - string "0" $2 - string "vhost_name" Problem was that vhost_kill only accepts 1 argument, which is "vhost_name". This was not noticed because in seems in most of our tests we just use the name "0". This would fail to kill a vhost instance in case it would be named anything else than "0" Change-Id: I635c5b92673abb7350d8bd6c636f6b794651f7ac Signed-off-by: Karol Latecki Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/468201 Tested-by: SPDK CI Jenkins Reviewed-by: Darek Stojaczyk Reviewed-by: Ben Walker --- test/vhost/common.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/vhost/common.sh b/test/vhost/common.sh index c7001c8c2..3142008cd 100644 --- a/test/vhost/common.sh +++ b/test/vhost/common.sh @@ -124,7 +124,7 @@ function vhost_run() local vhost_pid_file="$vhost_dir/vhost.pid" local vhost_socket="$vhost_dir/usvhost" notice "starting vhost app in background" - [[ -r "$vhost_pid_file" ]] && vhost_kill 0 $vhost_name + [[ -r "$vhost_pid_file" ]] && vhost_kill $vhost_name [[ -d $vhost_dir ]] && rm -f $vhost_dir/* mkdir -p $vhost_dir