ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scripts/rpc: remove default value from iscsi functions

Browse Source 
Removing default options from parser command to prevent overwrite by
argparse the defaults defined in the .c files.

Signed-off-by: Jaroslaw Chachulski <jaroslawx.chachulski@intel.com>
Change-Id: I11ef4947324dfba796fc16da566c0b8a1e606a00
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12922
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
This commit is contained in:
Jaroslaw Chachulski 2022-06-07 09:20:48 -04:00 committed by Tomasz Zawadzki
parent 9518bbc260
commit 169bab1f1a
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
scripts/rpc.py
View File

@ -1345,7 +1345,7 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse
*** The Portal/Initiator Groups must be precreated ***""") *** The Portal/Initiator Groups must be precreated ***""")
p.add_argument('queue_depth', help='Desired target queue depth', type=int) p.add_argument('queue_depth', help='Desired target queue depth', type=int)
p.add_argument('-g', '--chap-group', help="""Authentication group ID for this target node. p.add_argument('-g', '--chap-group', help="""Authentication group ID for this target node.
*** Authentication group must be precreated ***""", type=int, default=0) *** Authentication group must be precreated ***""", type=int)
p.add_argument('-d', '--disable-chap', help="""CHAP authentication should be disabled for this target node. p.add_argument('-d', '--disable-chap', help="""CHAP authentication should be disabled for this target node.
*** Mutually exclusive with --require-chap ***""", action='store_true') *** Mutually exclusive with --require-chap ***""", action='store_true')
p.add_argument('-r', '--require-chap', help="""CHAP authentication should be required for this target node. p.add_argument('-r', '--require-chap', help="""CHAP authentication should be required for this target node.
@ -1387,7 +1387,7 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse
help='Set CHAP authentication for the target node') help='Set CHAP authentication for the target node')
p.add_argument('name', help='Target node name (ASCII)') p.add_argument('name', help='Target node name (ASCII)')
p.add_argument('-g', '--chap-group', help="""Authentication group ID for this target node. p.add_argument('-g', '--chap-group', help="""Authentication group ID for this target node.
*** Authentication group must be precreated ***""", type=int, default=0) *** Authentication group must be precreated ***""", type=int)
p.add_argument('-d', '--disable-chap', help="""CHAP authentication should be disabled for this target node. p.add_argument('-d', '--disable-chap', help="""CHAP authentication should be disabled for this target node.
*** Mutually exclusive with --require-chap ***""", action='store_true') *** Mutually exclusive with --require-chap ***""", action='store_true')
p.add_argument('-r', '--require-chap', help="""CHAP authentication should be required for this target node. p.add_argument('-r', '--require-chap', help="""CHAP authentication should be required for this target node.
@ -1628,7 +1628,7 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse
help='Set CHAP authentication for discovery sessions specific for the portal group') help='Set CHAP authentication for discovery sessions specific for the portal group')
p.add_argument('tag', help='Portal group tag (unique, integer > 0)', type=int) p.add_argument('tag', help='Portal group tag (unique, integer > 0)', type=int)
p.add_argument('-g', '--chap-group', help="""Authentication group ID for this portal group. p.add_argument('-g', '--chap-group', help="""Authentication group ID for this portal group.
*** Authentication group must be precreated ***""", type=int, default=0) *** Authentication group must be precreated ***""", type=int)
p.add_argument('-d', '--disable-chap', help="""CHAP authentication should be disabled for this portal group. p.add_argument('-d', '--disable-chap', help="""CHAP authentication should be disabled for this portal group.
*** Mutually exclusive with --require-chap ***""", action='store_true') *** Mutually exclusive with --require-chap ***""", action='store_true')
p.add_argument('-r', '--require-chap', help="""CHAP authentication should be required for this portal group. p.add_argument('-r', '--require-chap', help="""CHAP authentication should be required for this portal group.