From 169bab1f1a6719b3724deff68cc53113da93ac1d Mon Sep 17 00:00:00 2001
From: Jaroslaw Chachulski <jaroslawx.chachulski@intel.com>
Date: Tue, 7 Jun 2022 09:20:48 -0400
Subject: [PATCH] scripts/rpc: remove default value from iscsi functions

Removing default options from parser command to prevent overwrite by
argparse the defaults defined in the .c files.

Signed-off-by: Jaroslaw Chachulski <jaroslawx.chachulski@intel.com>
Change-Id: I11ef4947324dfba796fc16da566c0b8a1e606a00
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12922
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
---
 scripts/rpc.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/rpc.py b/scripts/rpc.py
index 8bea468c9..f5c419597 100755
--- a/scripts/rpc.py
+++ b/scripts/rpc.py
@@ -1345,7 +1345,7 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse
     *** The Portal/Initiator Groups must be precreated ***""")
     p.add_argument('queue_depth', help='Desired target queue depth', type=int)
     p.add_argument('-g', '--chap-group', help="""Authentication group ID for this target node.
-    *** Authentication group must be precreated ***""", type=int, default=0)
+    *** Authentication group must be precreated ***""", type=int)
     p.add_argument('-d', '--disable-chap', help="""CHAP authentication should be disabled for this target node.
     *** Mutually exclusive with --require-chap ***""", action='store_true')
     p.add_argument('-r', '--require-chap', help="""CHAP authentication should be required for this target node.
@@ -1387,7 +1387,7 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse
                               help='Set CHAP authentication for the target node')
     p.add_argument('name', help='Target node name (ASCII)')
     p.add_argument('-g', '--chap-group', help="""Authentication group ID for this target node.
-    *** Authentication group must be precreated ***""", type=int, default=0)
+    *** Authentication group must be precreated ***""", type=int)
     p.add_argument('-d', '--disable-chap', help="""CHAP authentication should be disabled for this target node.
     *** Mutually exclusive with --require-chap ***""", action='store_true')
     p.add_argument('-r', '--require-chap', help="""CHAP authentication should be required for this target node.
@@ -1628,7 +1628,7 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse
                               help='Set CHAP authentication for discovery sessions specific for the portal group')
     p.add_argument('tag', help='Portal group tag (unique, integer > 0)', type=int)
     p.add_argument('-g', '--chap-group', help="""Authentication group ID for this portal group.
-    *** Authentication group must be precreated ***""", type=int, default=0)
+    *** Authentication group must be precreated ***""", type=int)
     p.add_argument('-d', '--disable-chap', help="""CHAP authentication should be disabled for this portal group.
     *** Mutually exclusive with --require-chap ***""", action='store_true')
     p.add_argument('-r', '--require-chap', help="""CHAP authentication should be required for this portal group.