ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

app, log: clarify how to enable log flags

Browse Source 
Let's point users to use --enable-debug now instead of
CONFIG_DEBUG=y.  Also to be completely pedantic, use
"configure" instead of "build" to make it more clear
this flag needs to be passed to the configure script,
not make.

Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: I4a6f6313a4f8e87cbb1d79cb68645305abb0e106

Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449339
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Paul Luse <paul.e.luse@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
This commit is contained in:
Jim Harris 2019-03-27 02:24:44 -07:00 committed by Changpeng Liu
parent a0070df9f8
commit 11b38a585a
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/event/app.c
View File

@ -934,7 +934,7 @@ spdk_app_parse_args(int argc, char **argv, struct spdk_app_opts *opts,
break; break;
case LOGFLAG_OPT_IDX: case LOGFLAG_OPT_IDX:
#ifndef DEBUG #ifndef DEBUG
fprintf(stderr, "%s must be built with CONFIG_DEBUG=y for -L flag\n", fprintf(stderr, "%s must be configured with --enable-debug for -L flag\n",
argv[0]); argv[0]);
usage(app_usage); usage(app_usage);
goto out; goto out;

2
lib/log/log_flags.c
View File

@ -197,6 +197,6 @@ spdk_log_usage(FILE *f, const char *log_arg)
fprintf(f, ")\n"); fprintf(f, ")\n");
#else #else
fprintf(f, " %s, --logflag <flag> enable debug log flag (not supported" fprintf(f, " %s, --logflag <flag> enable debug log flag (not supported"
" - must rebuild with --enable-debug)\n", log_arg); " - must reconfigure with --enable-debug)\n", log_arg);
#endif #endif
} }