From 11b38a585aa12b3e9159a2c244a2585ab3716546 Mon Sep 17 00:00:00 2001 From: Jim Harris Date: Wed, 27 Mar 2019 02:24:44 -0700 Subject: [PATCH] app, log: clarify how to enable log flags Let's point users to use --enable-debug now instead of CONFIG_DEBUG=y. Also to be completely pedantic, use "configure" instead of "build" to make it more clear this flag needs to be passed to the configure script, not make. Signed-off-by: Jim Harris Change-Id: I4a6f6313a4f8e87cbb1d79cb68645305abb0e106 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449339 Reviewed-by: Changpeng Liu Reviewed-by: Shuhei Matsumoto Reviewed-by: Paul Luse Tested-by: SPDK CI Jenkins --- lib/event/app.c | 2 +- lib/log/log_flags.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/event/app.c b/lib/event/app.c index 97fe117ac..4ccc61bef 100644 --- a/lib/event/app.c +++ b/lib/event/app.c @@ -934,7 +934,7 @@ spdk_app_parse_args(int argc, char **argv, struct spdk_app_opts *opts, break; case LOGFLAG_OPT_IDX: #ifndef DEBUG - fprintf(stderr, "%s must be built with CONFIG_DEBUG=y for -L flag\n", + fprintf(stderr, "%s must be configured with --enable-debug for -L flag\n", argv[0]); usage(app_usage); goto out; diff --git a/lib/log/log_flags.c b/lib/log/log_flags.c index d83722d27..a8cbae9d7 100644 --- a/lib/log/log_flags.c +++ b/lib/log/log_flags.c @@ -197,6 +197,6 @@ spdk_log_usage(FILE *f, const char *log_arg) fprintf(f, ")\n"); #else fprintf(f, " %s, --logflag enable debug log flag (not supported" - " - must rebuild with --enable-debug)\n", log_arg); + " - must reconfigure with --enable-debug)\n", log_arg); #endif }