ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nvme: clear the ns id desc list in nvme_ns_destruct()

Browse Source 
Clear the ns id desc list in nvme_ns_destruct().

Without this, someone can get stale data by calling e.g.
spdk_nvme_ns_get_uuid() on a destructed namespace.

Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
Change-Id: I965dd4cd6101d3a77eddbd582b9618b3436d39c8
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4263
Community-CI: Broadcom CI
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
This commit is contained in:
Niklas Cassel 2020-09-16 09:31:01 +00:00 committed by Tomasz Zawadzki
parent 792807a444
commit 07525a91b5
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/nvme/nvme_ns.c
View File

@ -417,6 +417,7 @@ void nvme_ns_destruct(struct spdk_nvme_ns *ns)
nsdata = _nvme_ns_get_data(ns); nsdata = _nvme_ns_get_data(ns);
memset(nsdata, 0, sizeof(*nsdata)); memset(nsdata, 0, sizeof(*nsdata));
memset(ns->id_desc_list, 0, sizeof(ns->id_desc_list));
ns->sector_size = 0; ns->sector_size = 0;
ns->extended_lba_size = 0; ns->extended_lba_size = 0;
ns->md_size = 0; ns->md_size = 0;