From 07525a91b5f6dfc0e1145cf1b6096b4413cb1be7 Mon Sep 17 00:00:00 2001
From: Niklas Cassel <niklas.cassel@wdc.com>
Date: Wed, 16 Sep 2020 09:31:01 +0000
Subject: [PATCH] nvme: clear the ns id desc list in nvme_ns_destruct()

Clear the ns id desc list in nvme_ns_destruct().

Without this, someone can get stale data by calling e.g.
spdk_nvme_ns_get_uuid() on a destructed namespace.

Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
Change-Id: I965dd4cd6101d3a77eddbd582b9618b3436d39c8
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4263
Community-CI: Broadcom CI
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
---
 lib/nvme/nvme_ns.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/nvme/nvme_ns.c b/lib/nvme/nvme_ns.c
index 09ae81c4c..61f500fe2 100644
--- a/lib/nvme/nvme_ns.c
+++ b/lib/nvme/nvme_ns.c
@@ -417,6 +417,7 @@ void nvme_ns_destruct(struct spdk_nvme_ns *ns)
 
 	nsdata = _nvme_ns_get_data(ns);
 	memset(nsdata, 0, sizeof(*nsdata));
+	memset(ns->id_desc_list, 0, sizeof(ns->id_desc_list));
 	ns->sector_size = 0;
 	ns->extended_lba_size = 0;
 	ns->md_size = 0;