2022-06-03 19:15:11 +00:00
|
|
|
/* SPDX-License-Identifier: BSD-3-Clause
|
2022-11-01 20:26:26 +00:00
|
|
|
* Copyright (C) 2016 Intel Corporation.
|
2016-11-22 19:47:04 +00:00
|
|
|
* All rights reserved.
|
|
|
|
*/
|
|
|
|
|
2017-05-02 18:18:25 +00:00
|
|
|
#include "spdk/stdinc.h"
|
2016-11-22 19:47:04 +00:00
|
|
|
|
2017-05-02 18:18:25 +00:00
|
|
|
#include "spdk/endian.h"
|
2016-11-22 19:47:04 +00:00
|
|
|
#include "spdk/scsi.h"
|
2018-01-18 06:34:47 +00:00
|
|
|
#include "spdk_cunit.h"
|
2016-11-22 19:47:04 +00:00
|
|
|
|
|
|
|
#include "CUnit/Basic.h"
|
|
|
|
|
2017-06-24 00:05:41 +00:00
|
|
|
#include "iscsi/iscsi.c"
|
|
|
|
|
2016-11-22 19:47:04 +00:00
|
|
|
#include "../common.c"
|
|
|
|
#include "iscsi/portal_grp.h"
|
2017-05-01 20:32:34 +00:00
|
|
|
#include "scsi/scsi_internal.h"
|
2018-11-21 10:03:52 +00:00
|
|
|
#include "common/lib/test_env.c"
|
2016-11-22 19:47:04 +00:00
|
|
|
|
2018-12-10 00:58:26 +00:00
|
|
|
#include "spdk_internal/mock.h"
|
|
|
|
|
2017-11-13 02:14:02 +00:00
|
|
|
#define UT_TARGET_NAME1 "iqn.2017-11.spdk.io:t0001"
|
|
|
|
#define UT_TARGET_NAME2 "iqn.2017-11.spdk.io:t0002"
|
|
|
|
#define UT_INITIATOR_NAME1 "iqn.2017-11.spdk.io:i0001"
|
|
|
|
#define UT_INITIATOR_NAME2 "iqn.2017-11.spdk.io:i0002"
|
2019-06-13 21:19:50 +00:00
|
|
|
#define UT_ISCSI_TSIH 256
|
|
|
|
|
2021-01-27 17:17:14 +00:00
|
|
|
struct spdk_iscsi_tgt_node g_tgt = {
|
|
|
|
.mutex = PTHREAD_MUTEX_INITIALIZER
|
|
|
|
};
|
2017-11-13 02:14:02 +00:00
|
|
|
|
2016-11-22 19:47:04 +00:00
|
|
|
struct spdk_iscsi_tgt_node *
|
2020-04-15 21:04:36 +00:00
|
|
|
iscsi_find_tgt_node(const char *target_name)
|
2016-11-22 19:47:04 +00:00
|
|
|
{
|
2017-11-13 02:14:02 +00:00
|
|
|
if (strcasecmp(target_name, UT_TARGET_NAME1) == 0) {
|
2019-06-13 21:19:50 +00:00
|
|
|
g_tgt.dev = NULL;
|
|
|
|
return (struct spdk_iscsi_tgt_node *)&g_tgt;
|
2017-11-13 02:14:02 +00:00
|
|
|
} else {
|
|
|
|
return NULL;
|
|
|
|
}
|
2016-11-22 19:47:04 +00:00
|
|
|
}
|
|
|
|
|
2017-11-13 02:14:02 +00:00
|
|
|
bool
|
2020-04-15 21:04:36 +00:00
|
|
|
iscsi_tgt_node_access(struct spdk_iscsi_conn *conn,
|
|
|
|
struct spdk_iscsi_tgt_node *target,
|
|
|
|
const char *iqn, const char *addr)
|
2016-11-22 19:47:04 +00:00
|
|
|
{
|
2017-11-13 02:14:02 +00:00
|
|
|
if (strcasecmp(conn->initiator_name, UT_INITIATOR_NAME1) == 0) {
|
|
|
|
return true;
|
|
|
|
} else {
|
|
|
|
return false;
|
|
|
|
}
|
2016-11-22 19:47:04 +00:00
|
|
|
}
|
|
|
|
|
2020-08-09 15:41:40 +00:00
|
|
|
DEFINE_STUB(iscsi_tgt_node_is_redirected, bool,
|
|
|
|
(struct spdk_iscsi_conn *conn, struct spdk_iscsi_tgt_node *target,
|
|
|
|
char *buf, int buf_len),
|
|
|
|
false);
|
|
|
|
|
2020-04-15 21:04:36 +00:00
|
|
|
DEFINE_STUB(iscsi_send_tgts, int,
|
2020-07-19 22:27:24 +00:00
|
|
|
(struct spdk_iscsi_conn *conn, const char *iiqn,
|
2018-12-10 00:58:26 +00:00
|
|
|
const char *tiqn, uint8_t *data, int alloc_len, int data_len),
|
|
|
|
0);
|
2016-11-22 19:47:04 +00:00
|
|
|
|
2020-04-15 21:04:36 +00:00
|
|
|
DEFINE_STUB(iscsi_tgt_node_is_destructed, bool,
|
2019-04-11 00:34:42 +00:00
|
|
|
(struct spdk_iscsi_tgt_node *target), false);
|
|
|
|
|
2020-04-15 21:54:21 +00:00
|
|
|
DEFINE_STUB_V(iscsi_portal_grp_close_all, (void));
|
2016-11-22 19:47:04 +00:00
|
|
|
|
2020-04-15 22:28:10 +00:00
|
|
|
DEFINE_STUB_V(iscsi_conn_schedule, (struct spdk_iscsi_conn *conn));
|
2018-03-05 00:01:00 +00:00
|
|
|
|
2020-04-15 22:28:10 +00:00
|
|
|
DEFINE_STUB_V(iscsi_conn_free_pdu,
|
2018-12-10 00:58:26 +00:00
|
|
|
(struct spdk_iscsi_conn *conn, struct spdk_iscsi_pdu *pdu));
|
2016-12-07 05:02:40 +00:00
|
|
|
|
2020-04-15 22:28:10 +00:00
|
|
|
DEFINE_STUB_V(iscsi_conn_pdu_generic_complete, (void *cb_arg));
|
|
|
|
|
|
|
|
DEFINE_STUB(iscsi_conn_handle_queued_datain_tasks, int,
|
2019-12-10 01:22:48 +00:00
|
|
|
(struct spdk_iscsi_conn *conn), 0);
|
|
|
|
|
2020-04-15 22:28:10 +00:00
|
|
|
DEFINE_STUB(iscsi_conn_abort_queued_datain_task, int,
|
2019-12-11 06:07:53 +00:00
|
|
|
(struct spdk_iscsi_conn *conn, uint32_t ref_task_tag), 0);
|
|
|
|
|
2020-04-15 22:28:10 +00:00
|
|
|
DEFINE_STUB(iscsi_conn_abort_queued_datain_tasks, int,
|
2019-12-11 06:07:53 +00:00
|
|
|
(struct spdk_iscsi_conn *conn, struct spdk_scsi_lun *lun,
|
|
|
|
struct spdk_iscsi_pdu *pdu), 0);
|
|
|
|
|
2020-04-16 02:18:51 +00:00
|
|
|
DEFINE_STUB(iscsi_chap_get_authinfo, int,
|
2018-12-10 00:58:26 +00:00
|
|
|
(struct iscsi_chap_auth *auth, const char *authuser, int ag_tag),
|
|
|
|
0);
|
2018-08-20 00:27:21 +00:00
|
|
|
|
2020-04-01 18:35:23 +00:00
|
|
|
DEFINE_STUB(spdk_sock_set_recvbuf, int, (struct spdk_sock *sock, int sz), 0);
|
|
|
|
|
2017-05-01 20:32:34 +00:00
|
|
|
int
|
|
|
|
spdk_scsi_lun_get_id(const struct spdk_scsi_lun *lun)
|
|
|
|
{
|
|
|
|
return lun->id;
|
|
|
|
}
|
|
|
|
|
2018-12-10 00:58:26 +00:00
|
|
|
DEFINE_STUB(spdk_scsi_lun_is_removing, bool, (const struct spdk_scsi_lun *lun),
|
|
|
|
true);
|
2018-07-04 05:23:55 +00:00
|
|
|
|
2017-05-02 17:56:08 +00:00
|
|
|
struct spdk_scsi_lun *
|
|
|
|
spdk_scsi_dev_get_lun(struct spdk_scsi_dev *dev, int lun_id)
|
|
|
|
{
|
2021-09-25 03:52:02 +00:00
|
|
|
struct spdk_scsi_lun *lun;
|
|
|
|
|
|
|
|
TAILQ_FOREACH(lun, &dev->luns, tailq) {
|
|
|
|
if (lun->id == lun_id) {
|
|
|
|
break;
|
|
|
|
}
|
2017-05-02 17:56:08 +00:00
|
|
|
}
|
|
|
|
|
2021-09-25 03:52:02 +00:00
|
|
|
return lun;
|
2017-05-02 17:56:08 +00:00
|
|
|
}
|
|
|
|
|
2019-04-03 02:51:21 +00:00
|
|
|
DEFINE_STUB(spdk_scsi_lun_id_int_to_fmt, uint64_t, (int lun_id), 0);
|
|
|
|
|
|
|
|
DEFINE_STUB(spdk_scsi_lun_id_fmt_to_int, int, (uint64_t lun_fmt), 0);
|
|
|
|
|
2019-10-20 22:37:01 +00:00
|
|
|
DEFINE_STUB(spdk_scsi_lun_get_dif_ctx, bool,
|
2019-10-28 04:05:46 +00:00
|
|
|
(struct spdk_scsi_lun *lun, struct spdk_scsi_task *task,
|
2019-10-20 22:37:01 +00:00
|
|
|
struct spdk_dif_ctx *dif_ctx), false);
|
|
|
|
|
2022-11-21 09:29:09 +00:00
|
|
|
static void
|
|
|
|
alloc_mock_mobj(struct spdk_mobj *mobj, int len)
|
|
|
|
{
|
|
|
|
mobj->buf = calloc(1, SPDK_BDEV_BUF_SIZE_WITH_MD(len));
|
|
|
|
SPDK_CU_ASSERT_FATAL(mobj->buf != NULL);
|
|
|
|
|
|
|
|
g_iscsi.pdu_immediate_data_pool = (struct spdk_mempool *)100;
|
|
|
|
g_iscsi.pdu_data_out_pool = (struct spdk_mempool *)200;
|
|
|
|
if (len == SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH) {
|
|
|
|
mobj->mp = g_iscsi.pdu_data_out_pool;
|
|
|
|
} else {
|
|
|
|
mobj->mp = g_iscsi.pdu_immediate_data_pool;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-11-13 02:14:02 +00:00
|
|
|
static void
|
|
|
|
op_login_check_target_test(void)
|
|
|
|
{
|
2019-12-09 05:35:29 +00:00
|
|
|
struct spdk_iscsi_conn conn = {};
|
|
|
|
struct spdk_iscsi_pdu rsp_pdu = {};
|
2017-11-13 02:14:02 +00:00
|
|
|
struct spdk_iscsi_tgt_node *target;
|
|
|
|
int rc;
|
|
|
|
|
2018-08-27 08:24:40 +00:00
|
|
|
/* expect success */
|
2017-11-13 02:14:02 +00:00
|
|
|
snprintf(conn.initiator_name, sizeof(conn.initiator_name),
|
|
|
|
"%s", UT_INITIATOR_NAME1);
|
|
|
|
|
2019-03-27 21:53:37 +00:00
|
|
|
rc = iscsi_op_login_check_target(&conn, &rsp_pdu,
|
|
|
|
UT_TARGET_NAME1, &target);
|
2017-11-13 02:14:02 +00:00
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
|
|
|
|
/* expect failure */
|
|
|
|
snprintf(conn.initiator_name, sizeof(conn.initiator_name),
|
|
|
|
"%s", UT_INITIATOR_NAME1);
|
|
|
|
|
2019-03-27 21:53:37 +00:00
|
|
|
rc = iscsi_op_login_check_target(&conn, &rsp_pdu,
|
|
|
|
UT_TARGET_NAME2, &target);
|
2017-11-13 02:14:02 +00:00
|
|
|
CU_ASSERT(rc != 0);
|
|
|
|
|
|
|
|
/* expect failure */
|
|
|
|
snprintf(conn.initiator_name, sizeof(conn.initiator_name),
|
|
|
|
"%s", UT_INITIATOR_NAME2);
|
|
|
|
|
2019-03-27 21:53:37 +00:00
|
|
|
rc = iscsi_op_login_check_target(&conn, &rsp_pdu,
|
|
|
|
UT_TARGET_NAME1, &target);
|
2017-11-13 02:14:02 +00:00
|
|
|
CU_ASSERT(rc != 0);
|
|
|
|
}
|
|
|
|
|
2019-06-13 21:19:50 +00:00
|
|
|
static void
|
|
|
|
op_login_session_normal_test(void)
|
|
|
|
{
|
2019-07-30 23:36:12 +00:00
|
|
|
struct spdk_iscsi_conn conn = {};
|
2019-12-09 05:35:29 +00:00
|
|
|
struct spdk_iscsi_portal portal = {};
|
|
|
|
struct spdk_iscsi_portal_grp group = {};
|
2019-06-28 05:47:01 +00:00
|
|
|
struct spdk_iscsi_pdu rsp_pdu = {};
|
2019-06-13 21:19:50 +00:00
|
|
|
struct iscsi_bhs_login_rsp *rsph;
|
2019-12-09 05:35:29 +00:00
|
|
|
struct spdk_iscsi_sess sess = {};
|
|
|
|
struct iscsi_param param = {};
|
2019-06-13 21:19:50 +00:00
|
|
|
int rc;
|
|
|
|
|
|
|
|
/* setup related data structures */
|
2019-09-19 04:00:07 +00:00
|
|
|
rsph = (struct iscsi_bhs_login_rsp *)&rsp_pdu.bhs;
|
2019-06-13 21:19:50 +00:00
|
|
|
rsph->tsih = 0;
|
|
|
|
memset(rsph->isid, 0, sizeof(rsph->isid));
|
|
|
|
conn.portal = &portal;
|
|
|
|
portal.group = &group;
|
|
|
|
conn.portal->group->tag = 0;
|
|
|
|
conn.params = NULL;
|
|
|
|
|
|
|
|
/* expect failure: NULL params for target name */
|
|
|
|
rc = iscsi_op_login_session_normal(&conn, &rsp_pdu, UT_INITIATOR_NAME1,
|
2019-07-30 23:36:12 +00:00
|
|
|
NULL, 0);
|
2019-06-13 21:19:50 +00:00
|
|
|
CU_ASSERT(rc != 0);
|
|
|
|
CU_ASSERT(rsph->status_class == ISCSI_CLASS_INITIATOR_ERROR);
|
|
|
|
CU_ASSERT(rsph->status_detail == ISCSI_LOGIN_MISSING_PARMS);
|
|
|
|
|
|
|
|
/* expect failure: incorrect key for target name */
|
|
|
|
param.next = NULL;
|
|
|
|
rc = iscsi_op_login_session_normal(&conn, &rsp_pdu, UT_INITIATOR_NAME1,
|
2019-07-30 23:36:12 +00:00
|
|
|
¶m, 0);
|
2019-06-13 21:19:50 +00:00
|
|
|
CU_ASSERT(rc != 0);
|
|
|
|
CU_ASSERT(rsph->status_class == ISCSI_CLASS_INITIATOR_ERROR);
|
|
|
|
CU_ASSERT(rsph->status_detail == ISCSI_LOGIN_MISSING_PARMS);
|
|
|
|
|
|
|
|
/* expect failure: NULL target name */
|
|
|
|
param.key = "TargetName";
|
|
|
|
param.val = NULL;
|
|
|
|
rc = iscsi_op_login_session_normal(&conn, &rsp_pdu, UT_INITIATOR_NAME1,
|
2019-07-30 23:36:12 +00:00
|
|
|
¶m, 0);
|
2019-06-13 21:19:50 +00:00
|
|
|
CU_ASSERT(rc != 0);
|
|
|
|
CU_ASSERT(rsph->status_class == ISCSI_CLASS_INITIATOR_ERROR);
|
|
|
|
CU_ASSERT(rsph->status_detail == ISCSI_LOGIN_MISSING_PARMS);
|
|
|
|
|
|
|
|
/* expect failure: session not found */
|
|
|
|
param.key = "TargetName";
|
|
|
|
param.val = "iqn.2017-11.spdk.io:t0001";
|
|
|
|
snprintf(conn.initiator_name, sizeof(conn.initiator_name),
|
|
|
|
"%s", UT_INITIATOR_NAME1);
|
|
|
|
rsph->tsih = 1; /* to append the session */
|
|
|
|
rc = iscsi_op_login_session_normal(&conn, &rsp_pdu, UT_INITIATOR_NAME1,
|
2019-07-30 23:36:12 +00:00
|
|
|
¶m, 0);
|
2019-06-13 21:19:50 +00:00
|
|
|
CU_ASSERT(conn.target_port == NULL);
|
|
|
|
CU_ASSERT(rc != 0);
|
|
|
|
CU_ASSERT(rsph->status_class == ISCSI_CLASS_INITIATOR_ERROR);
|
|
|
|
CU_ASSERT(rsph->status_detail == ISCSI_LOGIN_CONN_ADD_FAIL);
|
|
|
|
|
|
|
|
/* expect failure: session found while tag is wrong */
|
2020-04-13 21:05:20 +00:00
|
|
|
g_iscsi.MaxSessions = UT_ISCSI_TSIH * 2;
|
|
|
|
g_iscsi.session = calloc(1, sizeof(void *) * g_iscsi.MaxSessions);
|
|
|
|
g_iscsi.session[UT_ISCSI_TSIH - 1] = &sess;
|
2019-06-13 21:19:50 +00:00
|
|
|
sess.tsih = UT_ISCSI_TSIH;
|
|
|
|
rsph->tsih = UT_ISCSI_TSIH >> 8; /* to append the session */
|
2019-06-18 04:54:07 +00:00
|
|
|
sess.tag = 1;
|
2019-06-13 21:19:50 +00:00
|
|
|
rc = iscsi_op_login_session_normal(&conn, &rsp_pdu, UT_INITIATOR_NAME1,
|
2019-07-30 23:36:12 +00:00
|
|
|
¶m, 0);
|
2019-06-13 21:19:50 +00:00
|
|
|
CU_ASSERT(conn.target_port == NULL);
|
|
|
|
CU_ASSERT(rc != 0);
|
|
|
|
CU_ASSERT(rsph->status_class == ISCSI_CLASS_INITIATOR_ERROR);
|
|
|
|
CU_ASSERT(rsph->status_detail == ISCSI_LOGIN_CONN_ADD_FAIL);
|
|
|
|
|
2021-11-25 01:40:59 +00:00
|
|
|
/* expect success: drop the session */
|
2019-06-13 21:19:50 +00:00
|
|
|
rsph->tsih = 0; /* to create the session */
|
2020-04-13 21:05:20 +00:00
|
|
|
g_iscsi.AllowDuplicateIsid = false;
|
2019-06-13 21:19:50 +00:00
|
|
|
rc = iscsi_op_login_session_normal(&conn, &rsp_pdu, UT_INITIATOR_NAME1,
|
2019-07-30 23:36:12 +00:00
|
|
|
¶m, 0);
|
2019-06-13 21:19:50 +00:00
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
|
2021-11-25 01:40:59 +00:00
|
|
|
/* expect success: create the session */
|
2019-06-13 21:19:50 +00:00
|
|
|
rsph->tsih = 0; /* to create the session */
|
2020-04-13 21:05:20 +00:00
|
|
|
g_iscsi.AllowDuplicateIsid = true;
|
2019-06-13 21:19:50 +00:00
|
|
|
rc = iscsi_op_login_session_normal(&conn, &rsp_pdu, UT_INITIATOR_NAME1,
|
2019-07-30 23:36:12 +00:00
|
|
|
¶m, 0);
|
2019-06-13 21:19:50 +00:00
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
|
2020-04-13 21:05:20 +00:00
|
|
|
free(g_iscsi.session);
|
2019-06-13 21:19:50 +00:00
|
|
|
}
|
|
|
|
|
2016-11-22 19:47:04 +00:00
|
|
|
static void
|
|
|
|
maxburstlength_test(void)
|
|
|
|
{
|
2019-12-09 05:35:29 +00:00
|
|
|
struct spdk_iscsi_sess sess = {};
|
|
|
|
struct spdk_iscsi_conn conn = {};
|
|
|
|
struct spdk_scsi_dev dev = {};
|
|
|
|
struct spdk_scsi_lun lun = {};
|
2017-06-08 05:11:02 +00:00
|
|
|
struct spdk_iscsi_pdu *req_pdu, *data_out_pdu, *r2t_pdu;
|
2016-11-22 19:47:04 +00:00
|
|
|
struct iscsi_bhs_scsi_req *req;
|
|
|
|
struct iscsi_bhs_r2t *r2t;
|
|
|
|
struct iscsi_bhs_data_out *data_out;
|
|
|
|
struct spdk_iscsi_pdu *response_pdu;
|
|
|
|
int rc;
|
|
|
|
|
2020-08-14 01:23:28 +00:00
|
|
|
g_iscsi.MaxR2TPerConnection = DEFAULT_MAXR2T;
|
|
|
|
|
2020-04-16 02:10:57 +00:00
|
|
|
req_pdu = iscsi_get_pdu(&conn);
|
|
|
|
data_out_pdu = iscsi_get_pdu(&conn);
|
2016-11-22 19:47:04 +00:00
|
|
|
|
|
|
|
sess.ExpCmdSN = 0;
|
|
|
|
sess.MaxCmdSN = 64;
|
|
|
|
sess.session_type = SESSION_TYPE_NORMAL;
|
|
|
|
sess.MaxBurstLength = 1024;
|
|
|
|
|
|
|
|
lun.id = 0;
|
|
|
|
|
2021-09-25 03:52:02 +00:00
|
|
|
TAILQ_INIT(&dev.luns);
|
|
|
|
TAILQ_INSERT_TAIL(&dev.luns, &lun, tailq);
|
2016-11-22 19:47:04 +00:00
|
|
|
|
|
|
|
conn.full_feature = 1;
|
|
|
|
conn.sess = &sess;
|
|
|
|
conn.dev = &dev;
|
|
|
|
conn.state = ISCSI_CONN_STATE_RUNNING;
|
|
|
|
TAILQ_INIT(&conn.write_pdu_list);
|
|
|
|
TAILQ_INIT(&conn.active_r2t_tasks);
|
|
|
|
|
2019-09-19 04:00:07 +00:00
|
|
|
req_pdu->bhs.opcode = ISCSI_OP_SCSI;
|
2016-11-22 19:47:04 +00:00
|
|
|
req_pdu->data_segment_len = 0;
|
|
|
|
|
2019-09-19 04:00:07 +00:00
|
|
|
req = (struct iscsi_bhs_scsi_req *)&req_pdu->bhs;
|
2016-11-22 19:47:04 +00:00
|
|
|
|
|
|
|
to_be32(&req->cmd_sn, 0);
|
|
|
|
to_be32(&req->expected_data_xfer_len, 1028);
|
|
|
|
to_be32(&req->itt, 0x1234);
|
2017-07-17 22:57:54 +00:00
|
|
|
req->write_bit = 1;
|
|
|
|
req->final_bit = 1;
|
2016-11-22 19:47:04 +00:00
|
|
|
|
2019-10-16 23:00:56 +00:00
|
|
|
rc = iscsi_pdu_hdr_handle(&conn, req_pdu);
|
|
|
|
if (rc == 0 && !req_pdu->is_rejected) {
|
|
|
|
rc = iscsi_pdu_payload_handle(&conn, req_pdu);
|
|
|
|
}
|
2018-07-05 12:52:19 +00:00
|
|
|
CU_ASSERT(rc == 0);
|
2016-11-22 19:47:04 +00:00
|
|
|
|
2018-01-18 06:34:47 +00:00
|
|
|
response_pdu = TAILQ_FIRST(&g_write_pdu_list);
|
|
|
|
SPDK_CU_ASSERT_FATAL(response_pdu != NULL);
|
2016-11-22 19:47:04 +00:00
|
|
|
|
|
|
|
/*
|
2018-08-27 08:24:40 +00:00
|
|
|
* Confirm that a correct R2T reply was sent in response to the
|
2016-11-22 19:47:04 +00:00
|
|
|
* SCSI request.
|
|
|
|
*/
|
2018-01-18 06:34:47 +00:00
|
|
|
TAILQ_REMOVE(&g_write_pdu_list, response_pdu, tailq);
|
2019-09-19 04:00:07 +00:00
|
|
|
CU_ASSERT(response_pdu->bhs.opcode == ISCSI_OP_R2T);
|
|
|
|
r2t = (struct iscsi_bhs_r2t *)&response_pdu->bhs;
|
2016-11-22 19:47:04 +00:00
|
|
|
CU_ASSERT(from_be32(&r2t->desired_xfer_len) == 1024);
|
|
|
|
CU_ASSERT(from_be32(&r2t->buffer_offset) == 0);
|
|
|
|
CU_ASSERT(from_be32(&r2t->itt) == 0x1234);
|
|
|
|
|
2019-09-19 04:00:07 +00:00
|
|
|
data_out_pdu->bhs.opcode = ISCSI_OP_SCSI_DATAOUT;
|
|
|
|
data_out_pdu->bhs.flags = ISCSI_FLAG_FINAL;
|
2016-11-22 19:47:04 +00:00
|
|
|
data_out_pdu->data_segment_len = 1028;
|
2019-09-19 04:00:07 +00:00
|
|
|
data_out = (struct iscsi_bhs_data_out *)&data_out_pdu->bhs;
|
2016-11-22 19:47:04 +00:00
|
|
|
data_out->itt = r2t->itt;
|
|
|
|
data_out->ttt = r2t->ttt;
|
|
|
|
DSET24(data_out->data_segment_len, 1028);
|
|
|
|
|
2019-10-16 23:00:56 +00:00
|
|
|
rc = iscsi_pdu_hdr_handle(&conn, data_out_pdu);
|
|
|
|
if (rc == 0 && !data_out_pdu->is_rejected) {
|
|
|
|
rc = iscsi_pdu_payload_handle(&conn, data_out_pdu);
|
|
|
|
}
|
2016-11-22 19:47:04 +00:00
|
|
|
CU_ASSERT(rc == SPDK_ISCSI_CONNECTION_FATAL);
|
2017-06-08 05:11:02 +00:00
|
|
|
|
2018-07-06 23:14:25 +00:00
|
|
|
SPDK_CU_ASSERT_FATAL(response_pdu->task != NULL);
|
2020-04-15 20:30:47 +00:00
|
|
|
iscsi_task_disassociate_pdu(response_pdu->task);
|
|
|
|
iscsi_task_put(response_pdu->task);
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_put_pdu(response_pdu);
|
2017-06-08 05:11:02 +00:00
|
|
|
|
2018-01-18 06:34:47 +00:00
|
|
|
r2t_pdu = TAILQ_FIRST(&g_write_pdu_list);
|
2017-06-08 05:11:02 +00:00
|
|
|
CU_ASSERT(r2t_pdu != NULL);
|
2018-01-18 06:34:47 +00:00
|
|
|
TAILQ_REMOVE(&g_write_pdu_list, r2t_pdu, tailq);
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_put_pdu(r2t_pdu);
|
2017-06-08 05:11:02 +00:00
|
|
|
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_put_pdu(data_out_pdu);
|
|
|
|
iscsi_put_pdu(req_pdu);
|
2016-11-22 19:47:04 +00:00
|
|
|
}
|
|
|
|
|
2018-07-05 06:09:55 +00:00
|
|
|
static void
|
|
|
|
underflow_for_read_transfer_test(void)
|
|
|
|
{
|
2019-12-09 05:35:29 +00:00
|
|
|
struct spdk_iscsi_sess sess = {};
|
|
|
|
struct spdk_iscsi_conn conn = {};
|
|
|
|
struct spdk_iscsi_task task = {};
|
|
|
|
struct spdk_scsi_dev dev = {};
|
|
|
|
struct spdk_scsi_lun lun = {};
|
2018-07-05 06:09:55 +00:00
|
|
|
struct spdk_iscsi_pdu *pdu;
|
|
|
|
struct iscsi_bhs_scsi_req *scsi_req;
|
|
|
|
struct iscsi_bhs_data_in *datah;
|
|
|
|
uint32_t residual_count = 0;
|
|
|
|
|
|
|
|
sess.MaxBurstLength = SPDK_ISCSI_MAX_BURST_LENGTH;
|
|
|
|
|
|
|
|
conn.sess = &sess;
|
|
|
|
conn.MaxRecvDataSegmentLength = 8192;
|
|
|
|
|
2021-09-25 03:52:02 +00:00
|
|
|
TAILQ_INIT(&dev.luns);
|
|
|
|
TAILQ_INSERT_TAIL(&dev.luns, &lun, tailq);
|
2019-10-20 22:37:01 +00:00
|
|
|
conn.dev = &dev;
|
|
|
|
|
2020-04-16 02:10:57 +00:00
|
|
|
pdu = iscsi_get_pdu(&conn);
|
2018-07-05 06:09:55 +00:00
|
|
|
SPDK_CU_ASSERT_FATAL(pdu != NULL);
|
|
|
|
|
2019-09-19 04:00:07 +00:00
|
|
|
scsi_req = (struct iscsi_bhs_scsi_req *)&pdu->bhs;
|
2018-07-05 06:09:55 +00:00
|
|
|
scsi_req->read_bit = 1;
|
|
|
|
|
2020-04-15 20:30:47 +00:00
|
|
|
iscsi_task_set_pdu(&task, pdu);
|
2018-07-05 06:09:55 +00:00
|
|
|
task.parent = NULL;
|
|
|
|
|
|
|
|
task.scsi.iovs = &task.scsi.iov;
|
|
|
|
task.scsi.iovcnt = 1;
|
|
|
|
task.scsi.length = 512;
|
|
|
|
task.scsi.transfer_len = 512;
|
|
|
|
task.bytes_completed = 512;
|
|
|
|
task.scsi.data_transferred = 256;
|
|
|
|
task.scsi.status = SPDK_SCSI_STATUS_GOOD;
|
|
|
|
|
2020-04-16 02:18:51 +00:00
|
|
|
iscsi_task_response(&conn, &task);
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_put_pdu(pdu);
|
2018-07-05 06:09:55 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* In this case, a SCSI Data-In PDU should contain the Status
|
|
|
|
* for the data transfer.
|
|
|
|
*/
|
|
|
|
to_be32(&residual_count, 256);
|
|
|
|
|
|
|
|
pdu = TAILQ_FIRST(&g_write_pdu_list);
|
|
|
|
SPDK_CU_ASSERT_FATAL(pdu != NULL);
|
|
|
|
|
2019-09-19 04:00:07 +00:00
|
|
|
CU_ASSERT(pdu->bhs.opcode == ISCSI_OP_SCSI_DATAIN);
|
2018-07-05 06:09:55 +00:00
|
|
|
|
2019-09-19 04:00:07 +00:00
|
|
|
datah = (struct iscsi_bhs_data_in *)&pdu->bhs;
|
2018-07-05 06:09:55 +00:00
|
|
|
|
|
|
|
CU_ASSERT(datah->flags == (ISCSI_DATAIN_UNDERFLOW | ISCSI_FLAG_FINAL | ISCSI_DATAIN_STATUS));
|
|
|
|
CU_ASSERT(datah->res_cnt == residual_count);
|
|
|
|
|
|
|
|
TAILQ_REMOVE(&g_write_pdu_list, pdu, tailq);
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_put_pdu(pdu);
|
2018-07-05 06:09:55 +00:00
|
|
|
|
|
|
|
CU_ASSERT(TAILQ_EMPTY(&g_write_pdu_list));
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
underflow_for_zero_read_transfer_test(void)
|
|
|
|
{
|
2019-12-09 05:35:29 +00:00
|
|
|
struct spdk_iscsi_sess sess = {};
|
|
|
|
struct spdk_iscsi_conn conn = {};
|
|
|
|
struct spdk_iscsi_task task = {};
|
|
|
|
struct spdk_scsi_dev dev = {};
|
|
|
|
struct spdk_scsi_lun lun = {};
|
2018-07-05 06:09:55 +00:00
|
|
|
struct spdk_iscsi_pdu *pdu;
|
|
|
|
struct iscsi_bhs_scsi_req *scsi_req;
|
|
|
|
struct iscsi_bhs_scsi_resp *resph;
|
|
|
|
uint32_t residual_count = 0, data_segment_len;
|
|
|
|
|
|
|
|
sess.MaxBurstLength = SPDK_ISCSI_MAX_BURST_LENGTH;
|
|
|
|
|
|
|
|
conn.sess = &sess;
|
|
|
|
conn.MaxRecvDataSegmentLength = 8192;
|
|
|
|
|
2021-09-25 03:52:02 +00:00
|
|
|
TAILQ_INIT(&dev.luns);
|
|
|
|
TAILQ_INSERT_TAIL(&dev.luns, &lun, tailq);
|
2019-10-20 22:37:01 +00:00
|
|
|
conn.dev = &dev;
|
|
|
|
|
2020-04-16 02:10:57 +00:00
|
|
|
pdu = iscsi_get_pdu(&conn);
|
2018-07-05 06:09:55 +00:00
|
|
|
SPDK_CU_ASSERT_FATAL(pdu != NULL);
|
|
|
|
|
2019-09-19 04:00:07 +00:00
|
|
|
scsi_req = (struct iscsi_bhs_scsi_req *)&pdu->bhs;
|
2018-07-05 06:09:55 +00:00
|
|
|
scsi_req->read_bit = 1;
|
|
|
|
|
2020-04-15 20:30:47 +00:00
|
|
|
iscsi_task_set_pdu(&task, pdu);
|
2018-07-05 06:09:55 +00:00
|
|
|
task.parent = NULL;
|
|
|
|
|
|
|
|
task.scsi.length = 512;
|
|
|
|
task.scsi.transfer_len = 512;
|
|
|
|
task.bytes_completed = 512;
|
|
|
|
task.scsi.data_transferred = 0;
|
|
|
|
task.scsi.status = SPDK_SCSI_STATUS_GOOD;
|
|
|
|
|
2020-04-16 02:18:51 +00:00
|
|
|
iscsi_task_response(&conn, &task);
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_put_pdu(pdu);
|
2018-07-05 06:09:55 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* In this case, only a SCSI Response PDU is expected and
|
|
|
|
* underflow must be set in it.
|
|
|
|
* */
|
|
|
|
to_be32(&residual_count, 512);
|
|
|
|
|
|
|
|
pdu = TAILQ_FIRST(&g_write_pdu_list);
|
|
|
|
SPDK_CU_ASSERT_FATAL(pdu != NULL);
|
|
|
|
|
2019-09-19 04:00:07 +00:00
|
|
|
CU_ASSERT(pdu->bhs.opcode == ISCSI_OP_SCSI_RSP);
|
2018-07-05 06:09:55 +00:00
|
|
|
|
2019-09-19 04:00:07 +00:00
|
|
|
resph = (struct iscsi_bhs_scsi_resp *)&pdu->bhs;
|
2018-07-05 06:09:55 +00:00
|
|
|
|
|
|
|
CU_ASSERT(resph->flags == (ISCSI_SCSI_UNDERFLOW | 0x80));
|
|
|
|
|
|
|
|
data_segment_len = DGET24(resph->data_segment_len);
|
|
|
|
CU_ASSERT(data_segment_len == 0);
|
|
|
|
CU_ASSERT(resph->res_cnt == residual_count);
|
|
|
|
|
|
|
|
TAILQ_REMOVE(&g_write_pdu_list, pdu, tailq);
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_put_pdu(pdu);
|
2018-07-05 06:09:55 +00:00
|
|
|
|
|
|
|
CU_ASSERT(TAILQ_EMPTY(&g_write_pdu_list));
|
|
|
|
}
|
|
|
|
|
2018-07-06 08:05:58 +00:00
|
|
|
static void
|
|
|
|
underflow_for_request_sense_test(void)
|
|
|
|
{
|
2019-12-09 05:35:29 +00:00
|
|
|
struct spdk_iscsi_sess sess = {};
|
|
|
|
struct spdk_iscsi_conn conn = {};
|
|
|
|
struct spdk_iscsi_task task = {};
|
|
|
|
struct spdk_scsi_dev dev = {};
|
|
|
|
struct spdk_scsi_lun lun = {};
|
2018-08-29 22:28:21 +00:00
|
|
|
struct spdk_iscsi_pdu *pdu1, *pdu2;
|
2018-07-06 08:05:58 +00:00
|
|
|
struct iscsi_bhs_scsi_req *scsi_req;
|
|
|
|
struct iscsi_bhs_data_in *datah;
|
|
|
|
struct iscsi_bhs_scsi_resp *resph;
|
|
|
|
uint32_t residual_count = 0, data_segment_len;
|
|
|
|
|
|
|
|
sess.MaxBurstLength = SPDK_ISCSI_MAX_BURST_LENGTH;
|
|
|
|
|
|
|
|
conn.sess = &sess;
|
|
|
|
conn.MaxRecvDataSegmentLength = 8192;
|
|
|
|
|
2021-09-25 03:52:02 +00:00
|
|
|
TAILQ_INIT(&dev.luns);
|
|
|
|
TAILQ_INSERT_TAIL(&dev.luns, &lun, tailq);
|
2019-10-20 22:37:01 +00:00
|
|
|
conn.dev = &dev;
|
|
|
|
|
2020-04-16 02:10:57 +00:00
|
|
|
pdu1 = iscsi_get_pdu(&conn);
|
2018-08-29 22:28:21 +00:00
|
|
|
SPDK_CU_ASSERT_FATAL(pdu1 != NULL);
|
2018-07-06 08:05:58 +00:00
|
|
|
|
2019-09-19 04:00:07 +00:00
|
|
|
scsi_req = (struct iscsi_bhs_scsi_req *)&pdu1->bhs;
|
2018-07-06 08:05:58 +00:00
|
|
|
scsi_req->read_bit = 1;
|
|
|
|
|
2020-04-15 20:30:47 +00:00
|
|
|
iscsi_task_set_pdu(&task, pdu1);
|
2018-07-06 08:05:58 +00:00
|
|
|
task.parent = NULL;
|
|
|
|
|
|
|
|
task.scsi.iovs = &task.scsi.iov;
|
|
|
|
task.scsi.iovcnt = 1;
|
|
|
|
task.scsi.length = 512;
|
|
|
|
task.scsi.transfer_len = 512;
|
|
|
|
task.bytes_completed = 512;
|
|
|
|
|
|
|
|
task.scsi.sense_data_len = 18;
|
|
|
|
task.scsi.data_transferred = 18;
|
|
|
|
task.scsi.status = SPDK_SCSI_STATUS_GOOD;
|
|
|
|
|
2020-04-16 02:18:51 +00:00
|
|
|
iscsi_task_response(&conn, &task);
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_put_pdu(pdu1);
|
2018-07-06 08:05:58 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* In this case, a SCSI Data-In PDU and a SCSI Response PDU are returned.
|
|
|
|
* Sense data are set both in payload and sense area.
|
|
|
|
* The SCSI Data-In PDU sets FINAL and the SCSI Response PDU sets UNDERFLOW.
|
|
|
|
*
|
|
|
|
* Probably there will be different implementation but keeping current SPDK
|
|
|
|
* implementation by adding UT will be valuable for any implementation.
|
|
|
|
*/
|
|
|
|
to_be32(&residual_count, 494);
|
|
|
|
|
2018-08-29 22:28:21 +00:00
|
|
|
pdu1 = TAILQ_FIRST(&g_write_pdu_list);
|
|
|
|
SPDK_CU_ASSERT_FATAL(pdu1 != NULL);
|
2018-07-06 08:05:58 +00:00
|
|
|
|
2019-09-19 04:00:07 +00:00
|
|
|
CU_ASSERT(pdu1->bhs.opcode == ISCSI_OP_SCSI_DATAIN);
|
2018-07-06 08:05:58 +00:00
|
|
|
|
2019-09-19 04:00:07 +00:00
|
|
|
datah = (struct iscsi_bhs_data_in *)&pdu1->bhs;
|
2018-07-06 08:05:58 +00:00
|
|
|
|
|
|
|
CU_ASSERT(datah->flags == ISCSI_FLAG_FINAL);
|
|
|
|
|
|
|
|
data_segment_len = DGET24(datah->data_segment_len);
|
|
|
|
CU_ASSERT(data_segment_len == 18);
|
|
|
|
CU_ASSERT(datah->res_cnt == 0);
|
|
|
|
|
2018-08-29 22:28:21 +00:00
|
|
|
TAILQ_REMOVE(&g_write_pdu_list, pdu1, tailq);
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_put_pdu(pdu1);
|
2018-07-06 08:05:58 +00:00
|
|
|
|
2018-08-29 22:28:21 +00:00
|
|
|
pdu2 = TAILQ_FIRST(&g_write_pdu_list);
|
|
|
|
/* inform scan-build (clang 6) that these pointers are not the same */
|
|
|
|
SPDK_CU_ASSERT_FATAL(pdu1 != pdu2);
|
|
|
|
SPDK_CU_ASSERT_FATAL(pdu2 != NULL);
|
2018-07-06 08:05:58 +00:00
|
|
|
|
2019-09-19 04:00:07 +00:00
|
|
|
CU_ASSERT(pdu2->bhs.opcode == ISCSI_OP_SCSI_RSP);
|
2018-07-06 08:05:58 +00:00
|
|
|
|
2019-09-19 04:00:07 +00:00
|
|
|
resph = (struct iscsi_bhs_scsi_resp *)&pdu2->bhs;
|
2018-07-06 08:05:58 +00:00
|
|
|
|
|
|
|
CU_ASSERT(resph->flags == (ISCSI_SCSI_UNDERFLOW | 0x80));
|
|
|
|
|
|
|
|
data_segment_len = DGET24(resph->data_segment_len);
|
|
|
|
CU_ASSERT(data_segment_len == task.scsi.sense_data_len + 2);
|
|
|
|
CU_ASSERT(resph->res_cnt == residual_count);
|
|
|
|
|
2018-08-29 22:28:21 +00:00
|
|
|
TAILQ_REMOVE(&g_write_pdu_list, pdu2, tailq);
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_put_pdu(pdu2);
|
2018-07-06 08:05:58 +00:00
|
|
|
|
|
|
|
CU_ASSERT(TAILQ_EMPTY(&g_write_pdu_list));
|
|
|
|
}
|
|
|
|
|
2018-07-06 08:48:14 +00:00
|
|
|
static void
|
|
|
|
underflow_for_check_condition_test(void)
|
|
|
|
{
|
2019-12-09 05:35:29 +00:00
|
|
|
struct spdk_iscsi_sess sess = {};
|
|
|
|
struct spdk_iscsi_conn conn = {};
|
|
|
|
struct spdk_iscsi_task task = {};
|
|
|
|
struct spdk_scsi_dev dev = {};
|
|
|
|
struct spdk_scsi_lun lun = {};
|
2018-07-06 08:48:14 +00:00
|
|
|
struct spdk_iscsi_pdu *pdu;
|
|
|
|
struct iscsi_bhs_scsi_req *scsi_req;
|
|
|
|
struct iscsi_bhs_scsi_resp *resph;
|
|
|
|
uint32_t data_segment_len;
|
|
|
|
|
|
|
|
sess.MaxBurstLength = SPDK_ISCSI_MAX_BURST_LENGTH;
|
|
|
|
|
|
|
|
conn.sess = &sess;
|
|
|
|
conn.MaxRecvDataSegmentLength = 8192;
|
|
|
|
|
2021-09-25 03:52:02 +00:00
|
|
|
TAILQ_INIT(&dev.luns);
|
|
|
|
TAILQ_INSERT_TAIL(&dev.luns, &lun, tailq);
|
2019-10-20 22:37:01 +00:00
|
|
|
conn.dev = &dev;
|
|
|
|
|
2020-04-16 02:10:57 +00:00
|
|
|
pdu = iscsi_get_pdu(&conn);
|
2018-07-06 08:48:14 +00:00
|
|
|
SPDK_CU_ASSERT_FATAL(pdu != NULL);
|
|
|
|
|
2019-09-19 04:00:07 +00:00
|
|
|
scsi_req = (struct iscsi_bhs_scsi_req *)&pdu->bhs;
|
2018-07-06 08:48:14 +00:00
|
|
|
scsi_req->read_bit = 1;
|
|
|
|
|
2020-04-15 20:30:47 +00:00
|
|
|
iscsi_task_set_pdu(&task, pdu);
|
2018-07-06 08:48:14 +00:00
|
|
|
task.parent = NULL;
|
|
|
|
|
|
|
|
task.scsi.iovs = &task.scsi.iov;
|
|
|
|
task.scsi.iovcnt = 1;
|
|
|
|
task.scsi.length = 512;
|
|
|
|
task.scsi.transfer_len = 512;
|
|
|
|
task.bytes_completed = 512;
|
|
|
|
|
|
|
|
task.scsi.sense_data_len = 18;
|
|
|
|
task.scsi.data_transferred = 18;
|
|
|
|
task.scsi.status = SPDK_SCSI_STATUS_CHECK_CONDITION;
|
|
|
|
|
2020-04-16 02:18:51 +00:00
|
|
|
iscsi_task_response(&conn, &task);
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_put_pdu(pdu);
|
2018-07-06 08:48:14 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* In this case, a SCSI Response PDU is returned.
|
|
|
|
* Sense data is set in sense area.
|
|
|
|
* Underflow is not set.
|
|
|
|
*/
|
|
|
|
pdu = TAILQ_FIRST(&g_write_pdu_list);
|
|
|
|
SPDK_CU_ASSERT_FATAL(pdu != NULL);
|
|
|
|
|
2019-09-19 04:00:07 +00:00
|
|
|
CU_ASSERT(pdu->bhs.opcode == ISCSI_OP_SCSI_RSP);
|
2018-07-06 08:48:14 +00:00
|
|
|
|
2019-09-19 04:00:07 +00:00
|
|
|
resph = (struct iscsi_bhs_scsi_resp *)&pdu->bhs;
|
2018-07-06 08:48:14 +00:00
|
|
|
|
|
|
|
CU_ASSERT(resph->flags == 0x80);
|
|
|
|
|
|
|
|
data_segment_len = DGET24(resph->data_segment_len);
|
|
|
|
CU_ASSERT(data_segment_len == task.scsi.sense_data_len + 2);
|
|
|
|
CU_ASSERT(resph->res_cnt == 0);
|
|
|
|
|
|
|
|
TAILQ_REMOVE(&g_write_pdu_list, pdu, tailq);
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_put_pdu(pdu);
|
2018-07-06 08:48:14 +00:00
|
|
|
|
|
|
|
CU_ASSERT(TAILQ_EMPTY(&g_write_pdu_list));
|
|
|
|
}
|
2018-07-09 08:16:33 +00:00
|
|
|
|
|
|
|
static void
|
|
|
|
add_transfer_task_test(void)
|
|
|
|
{
|
2019-12-09 05:35:29 +00:00
|
|
|
struct spdk_iscsi_sess sess = {};
|
|
|
|
struct spdk_iscsi_conn conn = {};
|
|
|
|
struct spdk_iscsi_task task = {};
|
2018-07-09 08:16:33 +00:00
|
|
|
struct spdk_iscsi_pdu *pdu, *tmp;
|
|
|
|
struct iscsi_bhs_r2t *r2th;
|
|
|
|
int rc, count = 0;
|
|
|
|
uint32_t buffer_offset, desired_xfer_len;
|
|
|
|
|
2020-08-14 01:23:28 +00:00
|
|
|
g_iscsi.MaxR2TPerConnection = DEFAULT_MAXR2T;
|
|
|
|
|
2018-07-09 08:16:33 +00:00
|
|
|
sess.MaxBurstLength = SPDK_ISCSI_MAX_BURST_LENGTH; /* 1M */
|
|
|
|
sess.MaxOutstandingR2T = DEFAULT_MAXR2T; /* 4 */
|
|
|
|
|
|
|
|
conn.sess = &sess;
|
|
|
|
TAILQ_INIT(&conn.queued_r2t_tasks);
|
|
|
|
TAILQ_INIT(&conn.active_r2t_tasks);
|
|
|
|
|
2020-04-16 02:10:57 +00:00
|
|
|
pdu = iscsi_get_pdu(&conn);
|
2018-07-09 08:16:33 +00:00
|
|
|
SPDK_CU_ASSERT_FATAL(pdu != NULL);
|
|
|
|
|
|
|
|
pdu->data_segment_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH; /* 64K */
|
|
|
|
task.scsi.transfer_len = 16 * 1024 * 1024;
|
2020-04-15 20:30:47 +00:00
|
|
|
iscsi_task_set_pdu(&task, pdu);
|
2018-07-09 08:16:33 +00:00
|
|
|
|
|
|
|
/* The following tests if the task is queued because R2T tasks are full. */
|
|
|
|
conn.pending_r2t = DEFAULT_MAXR2T;
|
|
|
|
|
2019-03-27 21:53:37 +00:00
|
|
|
rc = add_transfer_task(&conn, &task);
|
2018-07-09 08:16:33 +00:00
|
|
|
|
2019-06-05 05:49:19 +00:00
|
|
|
CU_ASSERT(rc == 0);
|
2018-07-09 08:16:33 +00:00
|
|
|
CU_ASSERT(TAILQ_FIRST(&conn.queued_r2t_tasks) == &task);
|
|
|
|
|
|
|
|
TAILQ_REMOVE(&conn.queued_r2t_tasks, &task, link);
|
|
|
|
CU_ASSERT(TAILQ_EMPTY(&conn.queued_r2t_tasks));
|
|
|
|
|
|
|
|
/* The following tests if multiple R2Ts are issued. */
|
|
|
|
conn.pending_r2t = 0;
|
|
|
|
|
2019-03-27 21:53:37 +00:00
|
|
|
rc = add_transfer_task(&conn, &task);
|
2018-07-09 08:16:33 +00:00
|
|
|
|
2019-06-05 05:49:19 +00:00
|
|
|
CU_ASSERT(rc == 0);
|
2018-07-09 08:16:33 +00:00
|
|
|
CU_ASSERT(TAILQ_FIRST(&conn.active_r2t_tasks) == &task);
|
|
|
|
|
|
|
|
TAILQ_REMOVE(&conn.active_r2t_tasks, &task, link);
|
|
|
|
CU_ASSERT(TAILQ_EMPTY(&conn.active_r2t_tasks));
|
|
|
|
|
|
|
|
CU_ASSERT(conn.data_out_cnt == 255);
|
|
|
|
CU_ASSERT(conn.pending_r2t == 1);
|
|
|
|
CU_ASSERT(conn.ttt == 1);
|
|
|
|
|
|
|
|
CU_ASSERT(task.data_out_cnt == 255);
|
|
|
|
CU_ASSERT(task.ttt == 1);
|
|
|
|
CU_ASSERT(task.outstanding_r2t == sess.MaxOutstandingR2T);
|
|
|
|
CU_ASSERT(task.next_r2t_offset ==
|
|
|
|
pdu->data_segment_len + sess.MaxBurstLength * sess.MaxOutstandingR2T);
|
|
|
|
|
|
|
|
|
|
|
|
while (!TAILQ_EMPTY(&g_write_pdu_list)) {
|
|
|
|
tmp = TAILQ_FIRST(&g_write_pdu_list);
|
|
|
|
TAILQ_REMOVE(&g_write_pdu_list, tmp, tailq);
|
|
|
|
|
2019-09-19 04:00:07 +00:00
|
|
|
r2th = (struct iscsi_bhs_r2t *)&tmp->bhs;
|
2018-07-09 08:16:33 +00:00
|
|
|
|
|
|
|
buffer_offset = from_be32(&r2th->buffer_offset);
|
|
|
|
CU_ASSERT(buffer_offset == pdu->data_segment_len + sess.MaxBurstLength * count);
|
|
|
|
|
|
|
|
desired_xfer_len = from_be32(&r2th->desired_xfer_len);
|
|
|
|
CU_ASSERT(desired_xfer_len == sess.MaxBurstLength);
|
|
|
|
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_put_pdu(tmp);
|
2018-07-09 08:16:33 +00:00
|
|
|
count++;
|
|
|
|
}
|
|
|
|
|
|
|
|
CU_ASSERT(count == DEFAULT_MAXR2T);
|
|
|
|
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_put_pdu(pdu);
|
2018-07-09 08:16:33 +00:00
|
|
|
}
|
|
|
|
|
2018-07-09 13:21:52 +00:00
|
|
|
static void
|
|
|
|
get_transfer_task_test(void)
|
|
|
|
{
|
2019-12-09 05:35:29 +00:00
|
|
|
struct spdk_iscsi_sess sess = {};
|
|
|
|
struct spdk_iscsi_conn conn = {};
|
|
|
|
struct spdk_iscsi_task task1 = {}, task2 = {}, *task;
|
2018-07-09 13:21:52 +00:00
|
|
|
struct spdk_iscsi_pdu *pdu1, *pdu2, *pdu;
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
sess.MaxBurstLength = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
sess.MaxOutstandingR2T = 1;
|
|
|
|
|
|
|
|
conn.sess = &sess;
|
|
|
|
TAILQ_INIT(&conn.active_r2t_tasks);
|
|
|
|
|
2020-04-16 02:10:57 +00:00
|
|
|
pdu1 = iscsi_get_pdu(&conn);
|
2018-07-09 13:21:52 +00:00
|
|
|
SPDK_CU_ASSERT_FATAL(pdu1 != NULL);
|
|
|
|
|
|
|
|
pdu1->data_segment_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
task1.scsi.transfer_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
2020-04-15 20:30:47 +00:00
|
|
|
iscsi_task_set_pdu(&task1, pdu1);
|
2018-07-09 13:21:52 +00:00
|
|
|
|
2019-03-27 21:53:37 +00:00
|
|
|
rc = add_transfer_task(&conn, &task1);
|
2019-06-05 05:49:19 +00:00
|
|
|
CU_ASSERT(rc == 0);
|
2018-07-09 13:21:52 +00:00
|
|
|
|
2020-04-16 02:10:57 +00:00
|
|
|
pdu2 = iscsi_get_pdu(&conn);
|
2018-07-09 13:21:52 +00:00
|
|
|
SPDK_CU_ASSERT_FATAL(pdu2 != NULL);
|
|
|
|
|
|
|
|
pdu2->data_segment_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
task2.scsi.transfer_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
2020-04-15 20:30:47 +00:00
|
|
|
iscsi_task_set_pdu(&task2, pdu2);
|
2018-07-09 13:21:52 +00:00
|
|
|
|
2019-03-27 21:53:37 +00:00
|
|
|
rc = add_transfer_task(&conn, &task2);
|
2019-06-05 05:49:19 +00:00
|
|
|
CU_ASSERT(rc == 0);
|
2018-07-09 13:21:52 +00:00
|
|
|
|
2019-03-27 21:53:37 +00:00
|
|
|
task = get_transfer_task(&conn, 1);
|
2018-07-09 13:21:52 +00:00
|
|
|
CU_ASSERT(task == &task1);
|
|
|
|
|
2019-03-27 21:53:37 +00:00
|
|
|
task = get_transfer_task(&conn, 2);
|
2018-07-09 13:21:52 +00:00
|
|
|
CU_ASSERT(task == &task2);
|
|
|
|
|
|
|
|
while (!TAILQ_EMPTY(&conn.active_r2t_tasks)) {
|
|
|
|
task = TAILQ_FIRST(&conn.active_r2t_tasks);
|
|
|
|
TAILQ_REMOVE(&conn.active_r2t_tasks, task, link);
|
|
|
|
}
|
|
|
|
|
|
|
|
while (!TAILQ_EMPTY(&g_write_pdu_list)) {
|
|
|
|
pdu = TAILQ_FIRST(&g_write_pdu_list);
|
|
|
|
TAILQ_REMOVE(&g_write_pdu_list, pdu, tailq);
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_put_pdu(pdu);
|
2018-07-09 13:21:52 +00:00
|
|
|
}
|
|
|
|
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_put_pdu(pdu2);
|
|
|
|
iscsi_put_pdu(pdu1);
|
2018-07-09 13:21:52 +00:00
|
|
|
}
|
|
|
|
|
2018-07-09 13:43:30 +00:00
|
|
|
static void
|
|
|
|
del_transfer_task_test(void)
|
|
|
|
{
|
2019-12-09 05:35:29 +00:00
|
|
|
struct spdk_iscsi_sess sess = {};
|
|
|
|
struct spdk_iscsi_conn conn = {};
|
2020-06-29 04:18:43 +00:00
|
|
|
struct spdk_iscsi_task *task1, *task2, *task3, *task4, *task5;
|
2018-07-09 13:43:30 +00:00
|
|
|
struct spdk_iscsi_pdu *pdu1, *pdu2, *pdu3, *pdu4, *pdu5, *pdu;
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
sess.MaxBurstLength = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
sess.MaxOutstandingR2T = 1;
|
|
|
|
|
|
|
|
conn.sess = &sess;
|
|
|
|
TAILQ_INIT(&conn.active_r2t_tasks);
|
|
|
|
TAILQ_INIT(&conn.queued_r2t_tasks);
|
|
|
|
|
2020-04-16 02:10:57 +00:00
|
|
|
pdu1 = iscsi_get_pdu(&conn);
|
2018-07-09 13:43:30 +00:00
|
|
|
SPDK_CU_ASSERT_FATAL(pdu1 != NULL);
|
|
|
|
|
|
|
|
pdu1->data_segment_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
|
2020-06-29 04:18:43 +00:00
|
|
|
task1 = iscsi_task_get(&conn, NULL, NULL);
|
|
|
|
SPDK_CU_ASSERT_FATAL(task1 != NULL);
|
|
|
|
|
|
|
|
task1->scsi.transfer_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
iscsi_task_set_pdu(task1, pdu1);
|
|
|
|
task1->tag = 11;
|
|
|
|
|
|
|
|
rc = add_transfer_task(&conn, task1);
|
2019-06-05 05:49:19 +00:00
|
|
|
CU_ASSERT(rc == 0);
|
2018-07-09 13:43:30 +00:00
|
|
|
|
2020-04-16 02:10:57 +00:00
|
|
|
pdu2 = iscsi_get_pdu(&conn);
|
2018-07-09 13:43:30 +00:00
|
|
|
SPDK_CU_ASSERT_FATAL(pdu2 != NULL);
|
|
|
|
|
|
|
|
pdu2->data_segment_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
|
2020-06-29 04:18:43 +00:00
|
|
|
task2 = iscsi_task_get(&conn, NULL, NULL);
|
|
|
|
SPDK_CU_ASSERT_FATAL(task2 != NULL);
|
|
|
|
|
|
|
|
task2->scsi.transfer_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
iscsi_task_set_pdu(task2, pdu2);
|
|
|
|
task2->tag = 12;
|
|
|
|
|
|
|
|
rc = add_transfer_task(&conn, task2);
|
2019-06-05 05:49:19 +00:00
|
|
|
CU_ASSERT(rc == 0);
|
2018-07-09 13:43:30 +00:00
|
|
|
|
2020-04-16 02:10:57 +00:00
|
|
|
pdu3 = iscsi_get_pdu(&conn);
|
2018-07-09 13:43:30 +00:00
|
|
|
SPDK_CU_ASSERT_FATAL(pdu3 != NULL);
|
|
|
|
|
|
|
|
pdu3->data_segment_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
|
2020-06-29 04:18:43 +00:00
|
|
|
task3 = iscsi_task_get(&conn, NULL, NULL);
|
|
|
|
SPDK_CU_ASSERT_FATAL(task3 != NULL);
|
|
|
|
|
|
|
|
task3->scsi.transfer_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
iscsi_task_set_pdu(task3, pdu3);
|
|
|
|
task3->tag = 13;
|
|
|
|
|
|
|
|
rc = add_transfer_task(&conn, task3);
|
2019-06-05 05:49:19 +00:00
|
|
|
CU_ASSERT(rc == 0);
|
2018-07-09 13:43:30 +00:00
|
|
|
|
2020-04-16 02:10:57 +00:00
|
|
|
pdu4 = iscsi_get_pdu(&conn);
|
2018-07-09 13:43:30 +00:00
|
|
|
SPDK_CU_ASSERT_FATAL(pdu4 != NULL);
|
|
|
|
|
|
|
|
pdu4->data_segment_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
|
2020-06-29 04:18:43 +00:00
|
|
|
task4 = iscsi_task_get(&conn, NULL, NULL);
|
|
|
|
SPDK_CU_ASSERT_FATAL(task4 != NULL);
|
|
|
|
|
|
|
|
task4->scsi.transfer_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
iscsi_task_set_pdu(task4, pdu4);
|
|
|
|
task4->tag = 14;
|
|
|
|
|
|
|
|
rc = add_transfer_task(&conn, task4);
|
2019-06-05 05:49:19 +00:00
|
|
|
CU_ASSERT(rc == 0);
|
2018-07-09 13:43:30 +00:00
|
|
|
|
2020-04-16 02:10:57 +00:00
|
|
|
pdu5 = iscsi_get_pdu(&conn);
|
2018-07-09 13:43:30 +00:00
|
|
|
SPDK_CU_ASSERT_FATAL(pdu5 != NULL);
|
|
|
|
|
|
|
|
pdu5->data_segment_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
|
2020-06-29 04:18:43 +00:00
|
|
|
task5 = iscsi_task_get(&conn, NULL, NULL);
|
|
|
|
SPDK_CU_ASSERT_FATAL(task5 != NULL);
|
|
|
|
|
|
|
|
task5->scsi.transfer_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
iscsi_task_set_pdu(task5, pdu5);
|
|
|
|
task5->tag = 15;
|
|
|
|
|
|
|
|
rc = add_transfer_task(&conn, task5);
|
2019-06-05 05:49:19 +00:00
|
|
|
CU_ASSERT(rc == 0);
|
2018-07-09 13:43:30 +00:00
|
|
|
|
2020-06-29 04:18:43 +00:00
|
|
|
CU_ASSERT(get_transfer_task(&conn, 1) == task1);
|
2019-03-27 21:53:37 +00:00
|
|
|
CU_ASSERT(get_transfer_task(&conn, 5) == NULL);
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_del_transfer_task(&conn, 11);
|
2019-03-27 21:53:37 +00:00
|
|
|
CU_ASSERT(get_transfer_task(&conn, 1) == NULL);
|
2020-06-29 04:18:43 +00:00
|
|
|
CU_ASSERT(get_transfer_task(&conn, 5) == task5);
|
2018-07-09 13:43:30 +00:00
|
|
|
|
2020-06-29 04:18:43 +00:00
|
|
|
CU_ASSERT(get_transfer_task(&conn, 2) == task2);
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_del_transfer_task(&conn, 12);
|
2019-03-27 21:53:37 +00:00
|
|
|
CU_ASSERT(get_transfer_task(&conn, 2) == NULL);
|
2018-07-09 13:43:30 +00:00
|
|
|
|
2020-06-29 04:18:43 +00:00
|
|
|
CU_ASSERT(get_transfer_task(&conn, 3) == task3);
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_del_transfer_task(&conn, 13);
|
2019-03-27 21:53:37 +00:00
|
|
|
CU_ASSERT(get_transfer_task(&conn, 3) == NULL);
|
2018-07-09 13:43:30 +00:00
|
|
|
|
2020-06-29 04:18:43 +00:00
|
|
|
CU_ASSERT(get_transfer_task(&conn, 4) == task4);
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_del_transfer_task(&conn, 14);
|
2019-03-27 21:53:37 +00:00
|
|
|
CU_ASSERT(get_transfer_task(&conn, 4) == NULL);
|
2018-07-09 13:43:30 +00:00
|
|
|
|
2020-06-29 04:18:43 +00:00
|
|
|
CU_ASSERT(get_transfer_task(&conn, 5) == task5);
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_del_transfer_task(&conn, 15);
|
2019-03-27 21:53:37 +00:00
|
|
|
CU_ASSERT(get_transfer_task(&conn, 5) == NULL);
|
2018-07-09 13:43:30 +00:00
|
|
|
|
2020-06-29 04:18:43 +00:00
|
|
|
CU_ASSERT(TAILQ_EMPTY(&conn.active_r2t_tasks));
|
2018-07-09 13:43:30 +00:00
|
|
|
|
|
|
|
while (!TAILQ_EMPTY(&g_write_pdu_list)) {
|
|
|
|
pdu = TAILQ_FIRST(&g_write_pdu_list);
|
|
|
|
TAILQ_REMOVE(&g_write_pdu_list, pdu, tailq);
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_put_pdu(pdu);
|
2018-07-09 13:43:30 +00:00
|
|
|
}
|
|
|
|
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_put_pdu(pdu5);
|
|
|
|
iscsi_put_pdu(pdu4);
|
|
|
|
iscsi_put_pdu(pdu3);
|
|
|
|
iscsi_put_pdu(pdu2);
|
|
|
|
iscsi_put_pdu(pdu1);
|
2018-07-09 13:43:30 +00:00
|
|
|
}
|
|
|
|
|
2018-07-10 05:36:35 +00:00
|
|
|
static void
|
|
|
|
clear_all_transfer_tasks_test(void)
|
|
|
|
{
|
2019-12-09 05:35:29 +00:00
|
|
|
struct spdk_iscsi_sess sess = {};
|
|
|
|
struct spdk_iscsi_conn conn = {};
|
2018-11-26 01:48:10 +00:00
|
|
|
struct spdk_iscsi_task *task1, *task2, *task3, *task4, *task5, *task6;
|
|
|
|
struct spdk_iscsi_pdu *pdu1, *pdu2, *pdu3, *pdu4, *pdu5, *pdu6, *pdu;
|
|
|
|
struct spdk_iscsi_pdu *mgmt_pdu1, *mgmt_pdu2;
|
2019-12-09 05:35:29 +00:00
|
|
|
struct spdk_scsi_lun lun1 = {}, lun2 = {};
|
2018-11-26 01:48:10 +00:00
|
|
|
uint32_t alloc_cmd_sn;
|
2018-07-10 05:36:35 +00:00
|
|
|
int rc;
|
|
|
|
|
|
|
|
sess.MaxBurstLength = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
sess.MaxOutstandingR2T = 1;
|
|
|
|
|
|
|
|
conn.sess = &sess;
|
|
|
|
TAILQ_INIT(&conn.active_r2t_tasks);
|
|
|
|
TAILQ_INIT(&conn.queued_r2t_tasks);
|
|
|
|
|
2018-11-26 01:48:10 +00:00
|
|
|
alloc_cmd_sn = 10;
|
|
|
|
|
2020-04-15 20:30:47 +00:00
|
|
|
task1 = iscsi_task_get(&conn, NULL, NULL);
|
2018-07-10 05:36:35 +00:00
|
|
|
SPDK_CU_ASSERT_FATAL(task1 != NULL);
|
2020-04-16 02:10:57 +00:00
|
|
|
pdu1 = iscsi_get_pdu(&conn);
|
2018-07-10 05:36:35 +00:00
|
|
|
SPDK_CU_ASSERT_FATAL(pdu1 != NULL);
|
|
|
|
|
|
|
|
pdu1->data_segment_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
2018-11-26 01:48:10 +00:00
|
|
|
pdu1->cmd_sn = alloc_cmd_sn;
|
|
|
|
alloc_cmd_sn++;
|
2018-07-10 05:36:35 +00:00
|
|
|
task1->scsi.transfer_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
task1->scsi.lun = &lun1;
|
2020-04-15 20:30:47 +00:00
|
|
|
iscsi_task_set_pdu(task1, pdu1);
|
2018-07-10 05:36:35 +00:00
|
|
|
|
2019-03-27 21:53:37 +00:00
|
|
|
rc = add_transfer_task(&conn, task1);
|
2019-06-05 05:49:19 +00:00
|
|
|
CU_ASSERT(rc == 0);
|
2018-07-10 05:36:35 +00:00
|
|
|
|
2020-04-16 02:10:57 +00:00
|
|
|
mgmt_pdu1 = iscsi_get_pdu(&conn);
|
2018-11-26 01:48:10 +00:00
|
|
|
SPDK_CU_ASSERT_FATAL(mgmt_pdu1 != NULL);
|
|
|
|
|
|
|
|
mgmt_pdu1->cmd_sn = alloc_cmd_sn;
|
|
|
|
alloc_cmd_sn++;
|
|
|
|
|
2020-04-15 20:30:47 +00:00
|
|
|
task2 = iscsi_task_get(&conn, NULL, NULL);
|
2018-07-10 05:36:35 +00:00
|
|
|
SPDK_CU_ASSERT_FATAL(task2 != NULL);
|
2020-04-16 02:10:57 +00:00
|
|
|
pdu2 = iscsi_get_pdu(&conn);
|
2018-07-10 05:36:35 +00:00
|
|
|
SPDK_CU_ASSERT_FATAL(pdu2 != NULL);
|
|
|
|
|
|
|
|
pdu2->data_segment_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
2018-11-26 01:48:10 +00:00
|
|
|
pdu2->cmd_sn = alloc_cmd_sn;
|
|
|
|
alloc_cmd_sn++;
|
2018-07-10 05:36:35 +00:00
|
|
|
task2->scsi.transfer_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
task2->scsi.lun = &lun1;
|
2020-04-15 20:30:47 +00:00
|
|
|
iscsi_task_set_pdu(task2, pdu2);
|
2018-07-10 05:36:35 +00:00
|
|
|
|
2019-03-27 21:53:37 +00:00
|
|
|
rc = add_transfer_task(&conn, task2);
|
2019-06-05 05:49:19 +00:00
|
|
|
CU_ASSERT(rc == 0);
|
2018-07-10 05:36:35 +00:00
|
|
|
|
2020-04-15 20:30:47 +00:00
|
|
|
task3 = iscsi_task_get(&conn, NULL, NULL);
|
2018-07-10 05:36:35 +00:00
|
|
|
SPDK_CU_ASSERT_FATAL(task3 != NULL);
|
2020-04-16 02:10:57 +00:00
|
|
|
pdu3 = iscsi_get_pdu(&conn);
|
2018-07-10 05:36:35 +00:00
|
|
|
SPDK_CU_ASSERT_FATAL(pdu3 != NULL);
|
|
|
|
|
|
|
|
pdu3->data_segment_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
2018-11-26 01:48:10 +00:00
|
|
|
pdu3->cmd_sn = alloc_cmd_sn;
|
|
|
|
alloc_cmd_sn++;
|
2018-07-10 05:36:35 +00:00
|
|
|
task3->scsi.transfer_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
task3->scsi.lun = &lun1;
|
2020-04-15 20:30:47 +00:00
|
|
|
iscsi_task_set_pdu(task3, pdu3);
|
2018-07-10 05:36:35 +00:00
|
|
|
|
2019-03-27 21:53:37 +00:00
|
|
|
rc = add_transfer_task(&conn, task3);
|
2019-06-05 05:49:19 +00:00
|
|
|
CU_ASSERT(rc == 0);
|
2018-07-10 05:36:35 +00:00
|
|
|
|
2020-04-15 20:30:47 +00:00
|
|
|
task4 = iscsi_task_get(&conn, NULL, NULL);
|
2018-07-10 05:36:35 +00:00
|
|
|
SPDK_CU_ASSERT_FATAL(task4 != NULL);
|
2020-04-16 02:10:57 +00:00
|
|
|
pdu4 = iscsi_get_pdu(&conn);
|
2018-07-10 05:36:35 +00:00
|
|
|
SPDK_CU_ASSERT_FATAL(pdu4 != NULL);
|
|
|
|
|
|
|
|
pdu4->data_segment_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
2018-11-26 01:48:10 +00:00
|
|
|
pdu4->cmd_sn = alloc_cmd_sn;
|
|
|
|
alloc_cmd_sn++;
|
2018-07-10 05:36:35 +00:00
|
|
|
task4->scsi.transfer_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
task4->scsi.lun = &lun2;
|
2020-04-15 20:30:47 +00:00
|
|
|
iscsi_task_set_pdu(task4, pdu4);
|
2018-07-10 05:36:35 +00:00
|
|
|
|
2019-03-27 21:53:37 +00:00
|
|
|
rc = add_transfer_task(&conn, task4);
|
2019-06-05 05:49:19 +00:00
|
|
|
CU_ASSERT(rc == 0);
|
2018-07-10 05:36:35 +00:00
|
|
|
|
2020-04-15 20:30:47 +00:00
|
|
|
task5 = iscsi_task_get(&conn, NULL, NULL);
|
2018-07-10 05:36:35 +00:00
|
|
|
SPDK_CU_ASSERT_FATAL(task5 != NULL);
|
2020-04-16 02:10:57 +00:00
|
|
|
pdu5 = iscsi_get_pdu(&conn);
|
2018-07-10 05:36:35 +00:00
|
|
|
SPDK_CU_ASSERT_FATAL(pdu5 != NULL);
|
|
|
|
|
|
|
|
pdu5->data_segment_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
2018-11-26 01:48:10 +00:00
|
|
|
pdu5->cmd_sn = alloc_cmd_sn;
|
|
|
|
alloc_cmd_sn++;
|
2018-07-10 05:36:35 +00:00
|
|
|
task5->scsi.transfer_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
task5->scsi.lun = &lun2;
|
2020-04-15 20:30:47 +00:00
|
|
|
iscsi_task_set_pdu(task5, pdu5);
|
2018-07-10 05:36:35 +00:00
|
|
|
|
2019-03-27 21:53:37 +00:00
|
|
|
rc = add_transfer_task(&conn, task5);
|
2019-06-05 05:49:19 +00:00
|
|
|
CU_ASSERT(rc == 0);
|
2018-07-10 05:36:35 +00:00
|
|
|
|
2020-04-16 02:10:57 +00:00
|
|
|
mgmt_pdu2 = iscsi_get_pdu(&conn);
|
2018-11-26 01:48:10 +00:00
|
|
|
SPDK_CU_ASSERT_FATAL(mgmt_pdu2 != NULL);
|
|
|
|
|
|
|
|
mgmt_pdu2->cmd_sn = alloc_cmd_sn;
|
|
|
|
alloc_cmd_sn++;
|
|
|
|
|
2020-04-15 20:30:47 +00:00
|
|
|
task6 = iscsi_task_get(&conn, NULL, NULL);
|
2018-11-26 01:48:10 +00:00
|
|
|
SPDK_CU_ASSERT_FATAL(task6 != NULL);
|
2020-04-16 02:10:57 +00:00
|
|
|
pdu6 = iscsi_get_pdu(&conn);
|
2018-11-26 01:48:10 +00:00
|
|
|
SPDK_CU_ASSERT_FATAL(pdu6 != NULL);
|
|
|
|
|
|
|
|
pdu6->data_segment_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
pdu6->cmd_sn = alloc_cmd_sn;
|
|
|
|
alloc_cmd_sn++;
|
|
|
|
task5->scsi.transfer_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
task6->scsi.lun = &lun2;
|
2020-04-15 20:30:47 +00:00
|
|
|
iscsi_task_set_pdu(task6, pdu6);
|
2018-11-26 01:48:10 +00:00
|
|
|
|
2019-03-27 21:53:37 +00:00
|
|
|
rc = add_transfer_task(&conn, task6);
|
2019-06-05 05:49:19 +00:00
|
|
|
CU_ASSERT(rc == 0);
|
2018-11-26 01:48:10 +00:00
|
|
|
|
2018-07-10 05:36:35 +00:00
|
|
|
CU_ASSERT(conn.ttt == 4);
|
|
|
|
|
2019-03-27 21:53:37 +00:00
|
|
|
CU_ASSERT(get_transfer_task(&conn, 1) == task1);
|
|
|
|
CU_ASSERT(get_transfer_task(&conn, 2) == task2);
|
|
|
|
CU_ASSERT(get_transfer_task(&conn, 3) == task3);
|
|
|
|
CU_ASSERT(get_transfer_task(&conn, 4) == task4);
|
|
|
|
CU_ASSERT(get_transfer_task(&conn, 5) == NULL);
|
2018-07-10 05:36:35 +00:00
|
|
|
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_clear_all_transfer_task(&conn, &lun1, mgmt_pdu1);
|
2018-11-26 01:48:10 +00:00
|
|
|
|
|
|
|
CU_ASSERT(!TAILQ_EMPTY(&conn.queued_r2t_tasks));
|
2019-03-27 21:53:37 +00:00
|
|
|
CU_ASSERT(get_transfer_task(&conn, 1) == NULL);
|
|
|
|
CU_ASSERT(get_transfer_task(&conn, 2) == task2);
|
|
|
|
CU_ASSERT(get_transfer_task(&conn, 3) == task3);
|
|
|
|
CU_ASSERT(get_transfer_task(&conn, 4) == task4);
|
|
|
|
CU_ASSERT(get_transfer_task(&conn, 5) == task5);
|
|
|
|
CU_ASSERT(get_transfer_task(&conn, 6) == NULL);
|
2018-11-26 01:48:10 +00:00
|
|
|
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_clear_all_transfer_task(&conn, &lun1, NULL);
|
2018-07-10 05:36:35 +00:00
|
|
|
|
2018-07-11 05:24:10 +00:00
|
|
|
CU_ASSERT(TAILQ_EMPTY(&conn.queued_r2t_tasks));
|
2019-03-27 21:53:37 +00:00
|
|
|
CU_ASSERT(get_transfer_task(&conn, 1) == NULL);
|
|
|
|
CU_ASSERT(get_transfer_task(&conn, 2) == NULL);
|
|
|
|
CU_ASSERT(get_transfer_task(&conn, 3) == NULL);
|
|
|
|
CU_ASSERT(get_transfer_task(&conn, 4) == task4);
|
|
|
|
CU_ASSERT(get_transfer_task(&conn, 5) == task5);
|
|
|
|
CU_ASSERT(get_transfer_task(&conn, 6) == task6);
|
2018-07-10 05:36:35 +00:00
|
|
|
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_clear_all_transfer_task(&conn, &lun2, mgmt_pdu2);
|
2018-07-10 05:36:35 +00:00
|
|
|
|
2019-03-27 21:53:37 +00:00
|
|
|
CU_ASSERT(get_transfer_task(&conn, 4) == NULL);
|
|
|
|
CU_ASSERT(get_transfer_task(&conn, 5) == NULL);
|
|
|
|
CU_ASSERT(get_transfer_task(&conn, 6) == task6);
|
2018-11-26 01:48:10 +00:00
|
|
|
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_clear_all_transfer_task(&conn, NULL, NULL);
|
2018-11-26 01:48:10 +00:00
|
|
|
|
2019-03-27 21:53:37 +00:00
|
|
|
CU_ASSERT(get_transfer_task(&conn, 6) == NULL);
|
2018-07-10 05:36:35 +00:00
|
|
|
|
|
|
|
CU_ASSERT(TAILQ_EMPTY(&conn.active_r2t_tasks));
|
|
|
|
while (!TAILQ_EMPTY(&g_write_pdu_list)) {
|
|
|
|
pdu = TAILQ_FIRST(&g_write_pdu_list);
|
|
|
|
TAILQ_REMOVE(&g_write_pdu_list, pdu, tailq);
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_put_pdu(pdu);
|
2018-07-10 05:36:35 +00:00
|
|
|
}
|
|
|
|
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_put_pdu(mgmt_pdu2);
|
|
|
|
iscsi_put_pdu(mgmt_pdu1);
|
|
|
|
iscsi_put_pdu(pdu6);
|
|
|
|
iscsi_put_pdu(pdu5);
|
|
|
|
iscsi_put_pdu(pdu4);
|
|
|
|
iscsi_put_pdu(pdu3);
|
|
|
|
iscsi_put_pdu(pdu2);
|
|
|
|
iscsi_put_pdu(pdu1);
|
2018-07-10 05:36:35 +00:00
|
|
|
}
|
|
|
|
|
2019-02-26 00:41:29 +00:00
|
|
|
static void
|
|
|
|
build_iovs_test(void)
|
|
|
|
{
|
|
|
|
struct spdk_iscsi_conn conn = {};
|
|
|
|
struct spdk_iscsi_pdu pdu = {};
|
|
|
|
struct iovec iovs[5] = {};
|
|
|
|
uint8_t *data;
|
2019-02-26 02:26:42 +00:00
|
|
|
uint32_t mapped_length = 0;
|
2019-02-26 00:41:29 +00:00
|
|
|
int rc;
|
|
|
|
|
|
|
|
conn.header_digest = true;
|
|
|
|
conn.data_digest = true;
|
|
|
|
|
2019-09-19 04:00:07 +00:00
|
|
|
DSET24(&pdu.bhs.data_segment_len, 512);
|
2019-02-26 00:41:29 +00:00
|
|
|
data = calloc(1, 512);
|
|
|
|
SPDK_CU_ASSERT_FATAL(data != NULL);
|
|
|
|
pdu.data = data;
|
|
|
|
|
2019-09-19 04:00:07 +00:00
|
|
|
pdu.bhs.total_ahs_len = 0;
|
|
|
|
pdu.bhs.opcode = ISCSI_OP_SCSI;
|
2019-02-26 00:41:29 +00:00
|
|
|
|
|
|
|
pdu.writev_offset = 0;
|
2020-04-16 02:18:51 +00:00
|
|
|
rc = iscsi_build_iovs(&conn, iovs, 5, &pdu, &mapped_length);
|
2019-02-26 00:41:29 +00:00
|
|
|
CU_ASSERT(rc == 4);
|
2019-09-19 04:00:07 +00:00
|
|
|
CU_ASSERT(iovs[0].iov_base == (void *)&pdu.bhs);
|
2019-02-26 00:41:29 +00:00
|
|
|
CU_ASSERT(iovs[0].iov_len == ISCSI_BHS_LEN);
|
|
|
|
CU_ASSERT(iovs[1].iov_base == (void *)pdu.header_digest);
|
|
|
|
CU_ASSERT(iovs[1].iov_len == ISCSI_DIGEST_LEN);
|
|
|
|
CU_ASSERT(iovs[2].iov_base == (void *)pdu.data);
|
|
|
|
CU_ASSERT(iovs[2].iov_len == 512);
|
|
|
|
CU_ASSERT(iovs[3].iov_base == (void *)pdu.data_digest);
|
|
|
|
CU_ASSERT(iovs[3].iov_len == ISCSI_DIGEST_LEN);
|
2019-02-26 02:26:42 +00:00
|
|
|
CU_ASSERT(mapped_length == ISCSI_BHS_LEN + ISCSI_DIGEST_LEN + 512 + ISCSI_DIGEST_LEN);
|
2019-02-26 00:41:29 +00:00
|
|
|
|
|
|
|
pdu.writev_offset = ISCSI_BHS_LEN / 2;
|
2020-04-16 02:18:51 +00:00
|
|
|
rc = iscsi_build_iovs(&conn, iovs, 5, &pdu, &mapped_length);
|
2019-02-26 00:41:29 +00:00
|
|
|
CU_ASSERT(rc == 4);
|
2019-09-19 04:00:07 +00:00
|
|
|
CU_ASSERT(iovs[0].iov_base == (void *)((uint8_t *)&pdu.bhs + ISCSI_BHS_LEN / 2));
|
2019-02-26 00:41:29 +00:00
|
|
|
CU_ASSERT(iovs[0].iov_len == ISCSI_BHS_LEN / 2);
|
|
|
|
CU_ASSERT(iovs[1].iov_base == (void *)pdu.header_digest);
|
|
|
|
CU_ASSERT(iovs[1].iov_len == ISCSI_DIGEST_LEN);
|
|
|
|
CU_ASSERT(iovs[2].iov_base == (void *)pdu.data);
|
|
|
|
CU_ASSERT(iovs[2].iov_len == 512);
|
|
|
|
CU_ASSERT(iovs[3].iov_base == (void *)pdu.data_digest);
|
|
|
|
CU_ASSERT(iovs[3].iov_len == ISCSI_DIGEST_LEN);
|
2019-02-26 02:26:42 +00:00
|
|
|
CU_ASSERT(mapped_length == ISCSI_BHS_LEN / 2 + ISCSI_DIGEST_LEN + 512 + ISCSI_DIGEST_LEN);
|
2019-02-26 00:41:29 +00:00
|
|
|
|
|
|
|
pdu.writev_offset = ISCSI_BHS_LEN;
|
2020-04-16 02:18:51 +00:00
|
|
|
rc = iscsi_build_iovs(&conn, iovs, 5, &pdu, &mapped_length);
|
2019-02-26 00:41:29 +00:00
|
|
|
CU_ASSERT(rc == 3);
|
|
|
|
CU_ASSERT(iovs[0].iov_base == (void *)pdu.header_digest);
|
|
|
|
CU_ASSERT(iovs[0].iov_len == ISCSI_DIGEST_LEN);
|
|
|
|
CU_ASSERT(iovs[1].iov_base == (void *)pdu.data);
|
|
|
|
CU_ASSERT(iovs[1].iov_len == 512);
|
|
|
|
CU_ASSERT(iovs[2].iov_base == (void *)pdu.data_digest);
|
|
|
|
CU_ASSERT(iovs[2].iov_len == ISCSI_DIGEST_LEN);
|
2019-02-26 02:26:42 +00:00
|
|
|
CU_ASSERT(mapped_length == ISCSI_DIGEST_LEN + 512 + ISCSI_DIGEST_LEN);
|
2019-02-26 00:41:29 +00:00
|
|
|
|
|
|
|
pdu.writev_offset = ISCSI_BHS_LEN + ISCSI_DIGEST_LEN / 2;
|
2020-04-16 02:18:51 +00:00
|
|
|
rc = iscsi_build_iovs(&conn, iovs, 5, &pdu, &mapped_length);
|
2019-02-26 00:41:29 +00:00
|
|
|
CU_ASSERT(rc == 3);
|
|
|
|
CU_ASSERT(iovs[0].iov_base == (void *)((uint8_t *)pdu.header_digest + ISCSI_DIGEST_LEN / 2));
|
|
|
|
CU_ASSERT(iovs[0].iov_len == ISCSI_DIGEST_LEN / 2);
|
|
|
|
CU_ASSERT(iovs[1].iov_base == (void *)pdu.data);
|
|
|
|
CU_ASSERT(iovs[1].iov_len == 512);
|
|
|
|
CU_ASSERT(iovs[2].iov_base == (void *)pdu.data_digest);
|
|
|
|
CU_ASSERT(iovs[2].iov_len == ISCSI_DIGEST_LEN);
|
2019-02-26 02:26:42 +00:00
|
|
|
CU_ASSERT(mapped_length == ISCSI_DIGEST_LEN / 2 + 512 + ISCSI_DIGEST_LEN);
|
2019-02-26 00:41:29 +00:00
|
|
|
|
|
|
|
pdu.writev_offset = ISCSI_BHS_LEN + ISCSI_DIGEST_LEN;
|
2020-04-16 02:18:51 +00:00
|
|
|
rc = iscsi_build_iovs(&conn, iovs, 5, &pdu, &mapped_length);
|
2019-02-26 00:41:29 +00:00
|
|
|
CU_ASSERT(rc == 2);
|
|
|
|
CU_ASSERT(iovs[0].iov_base == (void *)pdu.data);
|
|
|
|
CU_ASSERT(iovs[0].iov_len == 512);
|
|
|
|
CU_ASSERT(iovs[1].iov_base == (void *)pdu.data_digest);
|
|
|
|
CU_ASSERT(iovs[1].iov_len == ISCSI_DIGEST_LEN);
|
2019-02-26 02:26:42 +00:00
|
|
|
CU_ASSERT(mapped_length == 512 + ISCSI_DIGEST_LEN);
|
2019-02-26 00:41:29 +00:00
|
|
|
|
|
|
|
pdu.writev_offset = ISCSI_BHS_LEN + ISCSI_DIGEST_LEN + 512;
|
2020-04-16 02:18:51 +00:00
|
|
|
rc = iscsi_build_iovs(&conn, iovs, 5, &pdu, &mapped_length);
|
2019-02-26 00:41:29 +00:00
|
|
|
CU_ASSERT(rc == 1);
|
|
|
|
CU_ASSERT(iovs[0].iov_base == (void *)pdu.data_digest);
|
|
|
|
CU_ASSERT(iovs[0].iov_len == ISCSI_DIGEST_LEN);
|
2019-02-26 02:26:42 +00:00
|
|
|
CU_ASSERT(mapped_length == ISCSI_DIGEST_LEN);
|
2019-02-26 00:41:29 +00:00
|
|
|
|
|
|
|
pdu.writev_offset = ISCSI_BHS_LEN + ISCSI_DIGEST_LEN + 512 + ISCSI_DIGEST_LEN / 2;
|
2020-04-16 02:18:51 +00:00
|
|
|
rc = iscsi_build_iovs(&conn, iovs, 5, &pdu, &mapped_length);
|
2019-02-26 00:41:29 +00:00
|
|
|
CU_ASSERT(rc == 1);
|
|
|
|
CU_ASSERT(iovs[0].iov_base == (void *)((uint8_t *)pdu.data_digest + ISCSI_DIGEST_LEN / 2));
|
|
|
|
CU_ASSERT(iovs[0].iov_len == ISCSI_DIGEST_LEN / 2);
|
2019-02-26 02:26:42 +00:00
|
|
|
CU_ASSERT(mapped_length == ISCSI_DIGEST_LEN / 2);
|
2019-02-26 00:41:29 +00:00
|
|
|
|
|
|
|
pdu.writev_offset = ISCSI_BHS_LEN + ISCSI_DIGEST_LEN + 512 + ISCSI_DIGEST_LEN;
|
2020-04-16 02:18:51 +00:00
|
|
|
rc = iscsi_build_iovs(&conn, iovs, 5, &pdu, &mapped_length);
|
2019-02-26 00:41:29 +00:00
|
|
|
CU_ASSERT(rc == 0);
|
2019-02-26 02:26:42 +00:00
|
|
|
CU_ASSERT(mapped_length == 0);
|
2019-02-26 00:41:29 +00:00
|
|
|
|
2019-02-27 02:32:33 +00:00
|
|
|
pdu.writev_offset = 0;
|
2020-04-16 02:18:51 +00:00
|
|
|
rc = iscsi_build_iovs(&conn, iovs, 1, &pdu, &mapped_length);
|
2019-02-27 02:32:33 +00:00
|
|
|
CU_ASSERT(rc == 1);
|
2019-09-19 04:00:07 +00:00
|
|
|
CU_ASSERT(iovs[0].iov_base == (void *)&pdu.bhs);
|
2019-02-27 02:32:33 +00:00
|
|
|
CU_ASSERT(iovs[0].iov_len == ISCSI_BHS_LEN);
|
|
|
|
CU_ASSERT(mapped_length == ISCSI_BHS_LEN);
|
|
|
|
|
2020-04-16 02:18:51 +00:00
|
|
|
rc = iscsi_build_iovs(&conn, iovs, 2, &pdu, &mapped_length);
|
2019-02-27 02:32:33 +00:00
|
|
|
CU_ASSERT(rc == 2);
|
2019-09-19 04:00:07 +00:00
|
|
|
CU_ASSERT(iovs[0].iov_base == (void *)&pdu.bhs);
|
2019-02-27 02:32:33 +00:00
|
|
|
CU_ASSERT(iovs[0].iov_len == ISCSI_BHS_LEN);
|
|
|
|
CU_ASSERT(iovs[1].iov_base == (void *)pdu.header_digest);
|
|
|
|
CU_ASSERT(iovs[1].iov_len == ISCSI_DIGEST_LEN);
|
|
|
|
CU_ASSERT(mapped_length == ISCSI_BHS_LEN + ISCSI_DIGEST_LEN);
|
|
|
|
|
2020-04-16 02:18:51 +00:00
|
|
|
rc = iscsi_build_iovs(&conn, iovs, 3, &pdu, &mapped_length);
|
2019-02-27 02:32:33 +00:00
|
|
|
CU_ASSERT(rc == 3);
|
2019-09-19 04:00:07 +00:00
|
|
|
CU_ASSERT(iovs[0].iov_base == (void *)&pdu.bhs);
|
2019-02-27 02:32:33 +00:00
|
|
|
CU_ASSERT(iovs[0].iov_len == ISCSI_BHS_LEN);
|
|
|
|
CU_ASSERT(iovs[1].iov_base == (void *)pdu.header_digest);
|
|
|
|
CU_ASSERT(iovs[1].iov_len == ISCSI_DIGEST_LEN);
|
|
|
|
CU_ASSERT(iovs[2].iov_base == (void *)pdu.data);
|
|
|
|
CU_ASSERT(iovs[2].iov_len == 512);
|
|
|
|
CU_ASSERT(mapped_length == ISCSI_BHS_LEN + ISCSI_DIGEST_LEN + 512);
|
|
|
|
|
2020-04-16 02:18:51 +00:00
|
|
|
rc = iscsi_build_iovs(&conn, iovs, 4, &pdu, &mapped_length);
|
2019-02-27 02:32:33 +00:00
|
|
|
CU_ASSERT(rc == 4);
|
2019-09-19 04:00:07 +00:00
|
|
|
CU_ASSERT(iovs[0].iov_base == (void *)&pdu.bhs);
|
2019-02-27 02:32:33 +00:00
|
|
|
CU_ASSERT(iovs[0].iov_len == ISCSI_BHS_LEN);
|
|
|
|
CU_ASSERT(iovs[1].iov_base == (void *)pdu.header_digest);
|
|
|
|
CU_ASSERT(iovs[1].iov_len == ISCSI_DIGEST_LEN);
|
|
|
|
CU_ASSERT(iovs[2].iov_base == (void *)pdu.data);
|
|
|
|
CU_ASSERT(iovs[2].iov_len == 512);
|
|
|
|
CU_ASSERT(iovs[3].iov_base == (void *)pdu.data_digest);
|
|
|
|
CU_ASSERT(iovs[3].iov_len == ISCSI_DIGEST_LEN);
|
|
|
|
CU_ASSERT(mapped_length == ISCSI_BHS_LEN + ISCSI_DIGEST_LEN + 512 + ISCSI_DIGEST_LEN);
|
|
|
|
|
2019-02-26 00:41:29 +00:00
|
|
|
free(data);
|
|
|
|
}
|
|
|
|
|
2019-06-19 01:08:17 +00:00
|
|
|
static void
|
|
|
|
build_iovs_with_md_test(void)
|
|
|
|
{
|
|
|
|
struct spdk_iscsi_conn conn = {};
|
|
|
|
struct spdk_iscsi_pdu pdu = {};
|
|
|
|
struct iovec iovs[6] = {};
|
|
|
|
uint8_t *data;
|
|
|
|
uint32_t mapped_length = 0;
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
conn.header_digest = true;
|
|
|
|
conn.data_digest = true;
|
|
|
|
|
2019-09-19 04:00:07 +00:00
|
|
|
DSET24(&pdu.bhs.data_segment_len, 4096 * 2);
|
2019-06-19 01:08:17 +00:00
|
|
|
data = calloc(1, (4096 + 128) * 2);
|
|
|
|
SPDK_CU_ASSERT_FATAL(data != NULL);
|
|
|
|
pdu.data = data;
|
|
|
|
pdu.data_buf_len = (4096 + 128) * 2;
|
|
|
|
|
2019-09-19 04:00:07 +00:00
|
|
|
pdu.bhs.total_ahs_len = 0;
|
|
|
|
pdu.bhs.opcode = ISCSI_OP_SCSI;
|
2019-06-19 01:08:17 +00:00
|
|
|
|
|
|
|
rc = spdk_dif_ctx_init(&pdu.dif_ctx, 4096 + 128, 128, true, false, SPDK_DIF_TYPE1,
|
|
|
|
0, 0, 0, 0, 0, 0);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
|
|
|
|
pdu.dif_insert_or_strip = true;
|
|
|
|
|
|
|
|
pdu.writev_offset = 0;
|
2020-04-16 02:18:51 +00:00
|
|
|
rc = iscsi_build_iovs(&conn, iovs, 6, &pdu, &mapped_length);
|
2019-06-19 01:08:17 +00:00
|
|
|
CU_ASSERT(rc == 5);
|
2019-09-19 04:00:07 +00:00
|
|
|
CU_ASSERT(iovs[0].iov_base == (void *)&pdu.bhs);
|
2019-06-19 01:08:17 +00:00
|
|
|
CU_ASSERT(iovs[0].iov_len == ISCSI_BHS_LEN);
|
|
|
|
CU_ASSERT(iovs[1].iov_base == (void *)pdu.header_digest);
|
|
|
|
CU_ASSERT(iovs[1].iov_len == ISCSI_DIGEST_LEN);
|
|
|
|
CU_ASSERT(iovs[2].iov_base == (void *)pdu.data);
|
|
|
|
CU_ASSERT(iovs[2].iov_len == 4096);
|
|
|
|
CU_ASSERT(iovs[3].iov_base == (void *)(pdu.data + 4096 + 128));
|
|
|
|
CU_ASSERT(iovs[3].iov_len == 4096);
|
|
|
|
CU_ASSERT(iovs[4].iov_base == (void *)pdu.data_digest);
|
|
|
|
CU_ASSERT(iovs[4].iov_len == ISCSI_DIGEST_LEN);
|
|
|
|
CU_ASSERT(mapped_length == ISCSI_BHS_LEN + ISCSI_DIGEST_LEN + 4096 * 2 + ISCSI_DIGEST_LEN);
|
|
|
|
|
|
|
|
pdu.writev_offset = ISCSI_BHS_LEN + ISCSI_DIGEST_LEN + 2048;
|
2020-04-16 02:18:51 +00:00
|
|
|
rc = iscsi_build_iovs(&conn, iovs, 6, &pdu, &mapped_length);
|
2019-06-19 01:08:17 +00:00
|
|
|
CU_ASSERT(rc == 3);
|
|
|
|
CU_ASSERT(iovs[0].iov_base == (void *)(pdu.data + 2048));
|
|
|
|
CU_ASSERT(iovs[0].iov_len == 2048);
|
|
|
|
CU_ASSERT(iovs[1].iov_base == (void *)(pdu.data + 4096 + 128));
|
|
|
|
CU_ASSERT(iovs[1].iov_len == 4096);
|
|
|
|
CU_ASSERT(iovs[2].iov_base == (void *)pdu.data_digest);
|
|
|
|
CU_ASSERT(iovs[2].iov_len == ISCSI_DIGEST_LEN);
|
|
|
|
CU_ASSERT(mapped_length == 2048 + 4096 + ISCSI_DIGEST_LEN);
|
|
|
|
|
|
|
|
pdu.writev_offset = ISCSI_BHS_LEN + ISCSI_DIGEST_LEN + 4096 * 2;
|
2020-04-16 02:18:51 +00:00
|
|
|
rc = iscsi_build_iovs(&conn, iovs, 6, &pdu, &mapped_length);
|
2019-06-19 01:08:17 +00:00
|
|
|
CU_ASSERT(rc == 1);
|
|
|
|
CU_ASSERT(iovs[0].iov_base == (void *)pdu.data_digest);
|
|
|
|
CU_ASSERT(iovs[0].iov_len == ISCSI_DIGEST_LEN);
|
|
|
|
CU_ASSERT(mapped_length == ISCSI_DIGEST_LEN);
|
|
|
|
|
|
|
|
pdu.writev_offset = 0;
|
2020-04-16 02:18:51 +00:00
|
|
|
rc = iscsi_build_iovs(&conn, iovs, 3, &pdu, &mapped_length);
|
2019-06-19 01:08:17 +00:00
|
|
|
CU_ASSERT(rc == 3);
|
2019-09-19 04:00:07 +00:00
|
|
|
CU_ASSERT(iovs[0].iov_base == (void *)&pdu.bhs);
|
2019-06-19 01:08:17 +00:00
|
|
|
CU_ASSERT(iovs[0].iov_len == ISCSI_BHS_LEN);
|
|
|
|
CU_ASSERT(iovs[1].iov_base == (void *)pdu.header_digest);
|
|
|
|
CU_ASSERT(iovs[1].iov_len == ISCSI_DIGEST_LEN);
|
|
|
|
CU_ASSERT(iovs[2].iov_base == (void *)pdu.data);
|
|
|
|
CU_ASSERT(iovs[2].iov_len == 4096);
|
|
|
|
CU_ASSERT(mapped_length == ISCSI_BHS_LEN + ISCSI_DIGEST_LEN + 4096);
|
|
|
|
|
|
|
|
free(data);
|
|
|
|
}
|
|
|
|
|
2019-10-24 01:05:06 +00:00
|
|
|
static void
|
|
|
|
check_iscsi_reject(struct spdk_iscsi_pdu *pdu, uint8_t reason)
|
|
|
|
{
|
|
|
|
struct spdk_iscsi_pdu *rsp_pdu;
|
|
|
|
struct iscsi_bhs_reject *reject_bhs;
|
|
|
|
|
|
|
|
CU_ASSERT(pdu->is_rejected == true);
|
|
|
|
rsp_pdu = TAILQ_FIRST(&g_write_pdu_list);
|
|
|
|
CU_ASSERT(rsp_pdu != NULL);
|
|
|
|
reject_bhs = (struct iscsi_bhs_reject *)&rsp_pdu->bhs;
|
|
|
|
CU_ASSERT(reject_bhs->reason == reason);
|
|
|
|
|
|
|
|
TAILQ_REMOVE(&g_write_pdu_list, rsp_pdu, tailq);
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_put_pdu(rsp_pdu);
|
2019-10-24 01:05:06 +00:00
|
|
|
pdu->is_rejected = false;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
check_login_response(uint8_t status_class, uint8_t status_detail)
|
|
|
|
{
|
|
|
|
struct spdk_iscsi_pdu *rsp_pdu;
|
|
|
|
struct iscsi_bhs_login_rsp *login_rsph;
|
|
|
|
|
|
|
|
rsp_pdu = TAILQ_FIRST(&g_write_pdu_list);
|
|
|
|
CU_ASSERT(rsp_pdu != NULL);
|
|
|
|
login_rsph = (struct iscsi_bhs_login_rsp *)&rsp_pdu->bhs;
|
|
|
|
CU_ASSERT(login_rsph->status_class == status_class);
|
|
|
|
CU_ASSERT(login_rsph->status_detail == status_detail);
|
|
|
|
|
|
|
|
TAILQ_REMOVE(&g_write_pdu_list, rsp_pdu, tailq);
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_put_pdu(rsp_pdu);
|
2019-10-24 01:05:06 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
pdu_hdr_op_login_test(void)
|
|
|
|
{
|
|
|
|
struct spdk_iscsi_sess sess = {};
|
|
|
|
struct spdk_iscsi_conn conn = {};
|
|
|
|
struct spdk_iscsi_pdu pdu = {};
|
|
|
|
struct iscsi_bhs_login_req *login_reqh;
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
login_reqh = (struct iscsi_bhs_login_req *)&pdu.bhs;
|
|
|
|
|
|
|
|
/* Case 1 - On discovery session, target only accepts text requests with the
|
|
|
|
* SendTargets key and logout request with reason "close the session".
|
|
|
|
*/
|
|
|
|
sess.session_type = SESSION_TYPE_DISCOVERY;
|
|
|
|
conn.full_feature = true;
|
|
|
|
conn.sess = &sess;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_login(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == SPDK_ISCSI_CONNECTION_FATAL);
|
|
|
|
|
|
|
|
/* Case 2 - Data segment length is limited to be not more than 8KB, the default
|
|
|
|
* FirstBurstLength, for login request.
|
|
|
|
*/
|
|
|
|
sess.session_type = SESSION_TYPE_INVALID;
|
|
|
|
conn.full_feature = false;
|
|
|
|
conn.sess = NULL;
|
|
|
|
pdu.data_segment_len = SPDK_ISCSI_FIRST_BURST_LENGTH + 1;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_login(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_iscsi_reject(&pdu, ISCSI_REASON_PROTOCOL_ERROR);
|
|
|
|
|
|
|
|
/* Case 3 - PDU pool is empty */
|
|
|
|
pdu.data_segment_len = SPDK_ISCSI_FIRST_BURST_LENGTH;
|
|
|
|
g_pdu_pool_is_empty = true;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_login(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == SPDK_ISCSI_CONNECTION_FATAL);
|
|
|
|
|
|
|
|
/* Case 4 - A login request with the C bit set to 1 must have the T bit set to 0. */
|
|
|
|
g_pdu_pool_is_empty = false;
|
|
|
|
login_reqh->flags |= ISCSI_LOGIN_TRANSIT;
|
|
|
|
login_reqh->flags |= ISCSI_LOGIN_CONTINUE;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_login(&conn, &pdu);
|
2020-01-17 16:57:40 +00:00
|
|
|
CU_ASSERT(rc == 0);
|
2019-10-24 01:05:06 +00:00
|
|
|
check_login_response(ISCSI_CLASS_INITIATOR_ERROR, ISCSI_LOGIN_INITIATOR_ERROR);
|
|
|
|
|
|
|
|
/* Case 5 - Both version-min and version-max must be set to 0x00. */
|
|
|
|
login_reqh->flags = 0;
|
|
|
|
login_reqh->version_min = ISCSI_VERSION + 1;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_login(&conn, &pdu);
|
2020-01-17 16:57:40 +00:00
|
|
|
CU_ASSERT(rc == 0);
|
2019-10-24 01:05:06 +00:00
|
|
|
check_login_response(ISCSI_CLASS_INITIATOR_ERROR, ISCSI_LOGIN_UNSUPPORTED_VERSION);
|
|
|
|
|
|
|
|
/* Case 6 - T bit is set to 1 correctly but invalid stage code is set to NSG. */
|
|
|
|
login_reqh->version_min = ISCSI_VERSION;
|
|
|
|
login_reqh->flags |= ISCSI_LOGIN_TRANSIT;
|
|
|
|
login_reqh->flags |= ISCSI_NSG_RESERVED_CODE;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_login(&conn, &pdu);
|
2020-01-17 16:57:40 +00:00
|
|
|
CU_ASSERT(rc == 0);
|
2019-10-24 01:05:06 +00:00
|
|
|
check_login_response(ISCSI_CLASS_INITIATOR_ERROR, ISCSI_LOGIN_INITIATOR_ERROR);
|
|
|
|
|
|
|
|
/* Case 7 - Login request is correct. Login response is initialized and set to
|
|
|
|
* the current connection.
|
|
|
|
*/
|
|
|
|
login_reqh->flags = 0;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_login(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
CU_ASSERT(conn.login_rsp_pdu != NULL);
|
|
|
|
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_put_pdu(conn.login_rsp_pdu);
|
2019-10-24 01:05:06 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
pdu_hdr_op_text_test(void)
|
|
|
|
{
|
|
|
|
struct spdk_iscsi_sess sess = {};
|
|
|
|
struct spdk_iscsi_conn conn = {};
|
|
|
|
struct spdk_iscsi_pdu pdu = {};
|
|
|
|
struct iscsi_bhs_text_req *text_reqh;
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
text_reqh = (struct iscsi_bhs_text_req *)&pdu.bhs;
|
|
|
|
|
|
|
|
conn.sess = &sess;
|
|
|
|
|
|
|
|
/* Case 1 - Data segment length for text request must not be more than
|
|
|
|
* FirstBurstLength plus extra space to account for digests.
|
|
|
|
*/
|
2020-04-16 02:10:57 +00:00
|
|
|
pdu.data_segment_len = iscsi_get_max_immediate_data_size() + 1;
|
2019-10-24 01:05:06 +00:00
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_text(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_iscsi_reject(&pdu, ISCSI_REASON_PROTOCOL_ERROR);
|
|
|
|
|
|
|
|
/* Case 2 - A text request with the C bit set to 1 must have the F bit set to 0. */
|
2020-04-16 02:10:57 +00:00
|
|
|
pdu.data_segment_len = iscsi_get_max_immediate_data_size();
|
2019-10-24 01:05:06 +00:00
|
|
|
text_reqh->flags |= ISCSI_FLAG_FINAL;
|
|
|
|
text_reqh->flags |= ISCSI_TEXT_CONTINUE;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_text(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == -1);
|
|
|
|
|
|
|
|
/* Case 3 - ExpStatSN of the text request is expected to match StatSN of the current
|
|
|
|
* connection. But StarPort iSCSI initiator didn't follow the expectation. In this
|
|
|
|
* case we overwrite StatSN by ExpStatSN and processes the request as correct.
|
|
|
|
*/
|
|
|
|
text_reqh->flags = 0;
|
|
|
|
to_be32(&text_reqh->exp_stat_sn, 1234);
|
|
|
|
to_be32(&conn.StatSN, 4321);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_text(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
CU_ASSERT(conn.StatSN == 1234);
|
|
|
|
|
|
|
|
/* Case 4 - Text request is the first in the sequence of text requests and responses,
|
|
|
|
* and so its ITT is hold to the current connection.
|
|
|
|
*/
|
|
|
|
sess.current_text_itt = 0xffffffffU;
|
|
|
|
to_be32(&text_reqh->itt, 5678);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_text(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
CU_ASSERT(sess.current_text_itt == 5678);
|
|
|
|
|
|
|
|
/* Case 5 - If text request is sent as part of a sequence of text requests and responses,
|
|
|
|
* its ITT must be the same for all the text requests. But it was not. */
|
|
|
|
sess.current_text_itt = 5679;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_text(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_iscsi_reject(&pdu, ISCSI_REASON_PROTOCOL_ERROR);
|
|
|
|
|
|
|
|
/* Case 6 - Different from case 5, its ITT matches the value saved in the connection. */
|
|
|
|
text_reqh->flags = 0;
|
|
|
|
sess.current_text_itt = 5678;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_text(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
check_logout_response(uint8_t response, uint32_t stat_sn, uint32_t exp_cmd_sn,
|
|
|
|
uint32_t max_cmd_sn)
|
|
|
|
{
|
|
|
|
struct spdk_iscsi_pdu *rsp_pdu;
|
|
|
|
struct iscsi_bhs_logout_resp *logout_rsph;
|
|
|
|
|
|
|
|
rsp_pdu = TAILQ_FIRST(&g_write_pdu_list);
|
|
|
|
CU_ASSERT(rsp_pdu != NULL);
|
|
|
|
logout_rsph = (struct iscsi_bhs_logout_resp *)&rsp_pdu->bhs;
|
|
|
|
CU_ASSERT(logout_rsph->response == response);
|
|
|
|
CU_ASSERT(from_be32(&logout_rsph->stat_sn) == stat_sn);
|
|
|
|
CU_ASSERT(from_be32(&logout_rsph->exp_cmd_sn) == exp_cmd_sn);
|
|
|
|
CU_ASSERT(from_be32(&logout_rsph->max_cmd_sn) == max_cmd_sn);
|
|
|
|
|
|
|
|
TAILQ_REMOVE(&g_write_pdu_list, rsp_pdu, tailq);
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_put_pdu(rsp_pdu);
|
2019-10-24 01:05:06 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
pdu_hdr_op_logout_test(void)
|
|
|
|
{
|
|
|
|
struct spdk_iscsi_sess sess = {};
|
|
|
|
struct spdk_iscsi_conn conn = {};
|
|
|
|
struct spdk_iscsi_pdu pdu = {};
|
|
|
|
struct iscsi_bhs_logout_req *logout_reqh;
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
logout_reqh = (struct iscsi_bhs_logout_req *)&pdu.bhs;
|
|
|
|
|
|
|
|
/* Case 1 - Target can accept logout request only with the reason "close the session"
|
|
|
|
* on discovery session.
|
|
|
|
*/
|
|
|
|
logout_reqh->reason = 1;
|
|
|
|
conn.sess = &sess;
|
|
|
|
sess.session_type = SESSION_TYPE_DISCOVERY;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_logout(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == SPDK_ISCSI_CONNECTION_FATAL);
|
|
|
|
|
|
|
|
/* Case 2 - Session is not established yet but connection was closed successfully. */
|
|
|
|
conn.sess = NULL;
|
|
|
|
conn.StatSN = 1234;
|
|
|
|
to_be32(&logout_reqh->exp_stat_sn, 1234);
|
|
|
|
pdu.cmd_sn = 5678;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_logout(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_logout_response(0, 1234, 5678, 5678);
|
|
|
|
CU_ASSERT(conn.StatSN == 1235);
|
|
|
|
|
|
|
|
/* Case 3 - Session type is normal but CID was not found. Hence connection or session
|
|
|
|
* was not closed.
|
|
|
|
*/
|
|
|
|
sess.session_type = SESSION_TYPE_NORMAL;
|
|
|
|
sess.ExpCmdSN = 5679;
|
|
|
|
sess.connections = 1;
|
|
|
|
conn.sess = &sess;
|
2020-12-30 04:04:10 +00:00
|
|
|
conn.cid = 1;
|
2019-10-24 01:05:06 +00:00
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_logout(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_logout_response(1, 1235, 5679, 1);
|
|
|
|
CU_ASSERT(conn.StatSN == 1236);
|
|
|
|
CU_ASSERT(sess.MaxCmdSN == 1);
|
|
|
|
|
|
|
|
/* Case 4 - Session type is normal and CID was found. Connection or session was closed
|
|
|
|
* successfully.
|
|
|
|
*/
|
|
|
|
to_be16(&logout_reqh->cid, 1);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_logout(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_logout_response(0, 1236, 5679, 2);
|
|
|
|
CU_ASSERT(conn.StatSN == 1237);
|
|
|
|
CU_ASSERT(sess.MaxCmdSN == 2);
|
|
|
|
|
|
|
|
/* Case 5 - PDU pool is empty. */
|
|
|
|
g_pdu_pool_is_empty = true;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_logout(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == SPDK_ISCSI_CONNECTION_FATAL);
|
|
|
|
|
|
|
|
g_pdu_pool_is_empty = false;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
check_scsi_task(struct spdk_iscsi_pdu *pdu, enum spdk_scsi_data_dir dir)
|
|
|
|
{
|
|
|
|
struct spdk_iscsi_task *task;
|
|
|
|
|
|
|
|
task = pdu->task;
|
|
|
|
CU_ASSERT(task != NULL);
|
|
|
|
CU_ASSERT(task->pdu == pdu);
|
2020-11-17 16:22:36 +00:00
|
|
|
CU_ASSERT(task->scsi.dxfer_dir == (uint32_t)dir);
|
2019-10-24 01:05:06 +00:00
|
|
|
|
2020-04-15 20:30:47 +00:00
|
|
|
iscsi_task_put(task);
|
2019-10-24 01:05:06 +00:00
|
|
|
pdu->task = NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
pdu_hdr_op_scsi_test(void)
|
|
|
|
{
|
|
|
|
struct spdk_iscsi_sess sess = {};
|
|
|
|
struct spdk_iscsi_conn conn = {};
|
|
|
|
struct spdk_iscsi_pdu pdu = {};
|
|
|
|
struct spdk_scsi_dev dev = {};
|
|
|
|
struct spdk_scsi_lun lun = {};
|
|
|
|
struct iscsi_bhs_scsi_req *scsi_reqh;
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
scsi_reqh = (struct iscsi_bhs_scsi_req *)&pdu.bhs;
|
|
|
|
|
|
|
|
conn.sess = &sess;
|
|
|
|
conn.dev = &dev;
|
|
|
|
|
|
|
|
/* Case 1 - SCSI command is acceptable only on normal session. */
|
|
|
|
sess.session_type = SESSION_TYPE_DISCOVERY;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_scsi(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == SPDK_ISCSI_CONNECTION_FATAL);
|
|
|
|
|
|
|
|
/* Case 2 - Task pool is empty. */
|
|
|
|
g_task_pool_is_empty = true;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_scsi(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == SPDK_ISCSI_CONNECTION_FATAL);
|
|
|
|
|
|
|
|
g_task_pool_is_empty = false;
|
|
|
|
|
|
|
|
/* Case 3 - bidirectional operations (both R and W flags are set to 1) are not supported. */
|
|
|
|
sess.session_type = SESSION_TYPE_NORMAL;
|
|
|
|
scsi_reqh->read_bit = 1;
|
|
|
|
scsi_reqh->write_bit = 1;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_scsi(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == SPDK_ISCSI_CONNECTION_FATAL);
|
|
|
|
|
|
|
|
/* Case 4 - LUN is hot-removed, and return immediately. */
|
|
|
|
scsi_reqh->write_bit = 0;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_scsi(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
CU_ASSERT(pdu.task == NULL);
|
|
|
|
|
|
|
|
/* Case 5 - SCSI read command PDU is correct, and the configured iSCSI task is set to the PDU. */
|
2021-09-25 03:52:02 +00:00
|
|
|
TAILQ_INIT(&dev.luns);
|
|
|
|
TAILQ_INSERT_TAIL(&dev.luns, &lun, tailq);
|
2019-10-24 01:05:06 +00:00
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_scsi(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_scsi_task(&pdu, SPDK_SCSI_DIR_FROM_DEV);
|
|
|
|
|
|
|
|
/* Case 6 - For SCSI write command PDU, its data segment length must not be more than
|
|
|
|
* FirstBurstLength plus extra space to account for digests.
|
|
|
|
*/
|
|
|
|
scsi_reqh->read_bit = 0;
|
|
|
|
scsi_reqh->write_bit = 1;
|
2020-04-16 02:10:57 +00:00
|
|
|
pdu.data_segment_len = iscsi_get_max_immediate_data_size() + 1;
|
2019-10-24 01:05:06 +00:00
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_scsi(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_iscsi_reject(&pdu, ISCSI_REASON_PROTOCOL_ERROR);
|
|
|
|
|
|
|
|
/* Case 7 - For SCSI write command PDU, its data segment length must not be more than
|
|
|
|
* Expected Data Transfer Length (EDTL).
|
|
|
|
*/
|
2020-04-16 02:10:57 +00:00
|
|
|
pdu.data_segment_len = iscsi_get_max_immediate_data_size();
|
2019-10-24 01:05:06 +00:00
|
|
|
to_be32(&scsi_reqh->expected_data_xfer_len, pdu.data_segment_len - 1);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_scsi(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_iscsi_reject(&pdu, ISCSI_REASON_PROTOCOL_ERROR);
|
|
|
|
|
|
|
|
/* Case 8 - If ImmediateData is not enabled for the session, SCSI write command PDU
|
|
|
|
* cannot have data segment.
|
|
|
|
*/
|
|
|
|
to_be32(&scsi_reqh->expected_data_xfer_len, pdu.data_segment_len);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_scsi(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_iscsi_reject(&pdu, ISCSI_REASON_PROTOCOL_ERROR);
|
|
|
|
|
|
|
|
/* Case 9 - For SCSI write command PDU, its data segment length must not be more
|
|
|
|
* than FirstBurstLength.
|
|
|
|
*/
|
|
|
|
sess.ImmediateData = true;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_scsi(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_iscsi_reject(&pdu, ISCSI_REASON_PROTOCOL_ERROR);
|
|
|
|
|
|
|
|
/* Case 10 - SCSI write command PDU is correct, and the configured iSCSI task is set to the PDU. */
|
|
|
|
sess.FirstBurstLength = pdu.data_segment_len;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_scsi(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_scsi_task(&pdu, SPDK_SCSI_DIR_TO_DEV);
|
|
|
|
|
|
|
|
/* Case 11 - R and W must not both be 0 when EDTL is not 0. */
|
|
|
|
scsi_reqh->write_bit = 0;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_scsi(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_iscsi_reject(&pdu, ISCSI_REASON_INVALID_PDU_FIELD);
|
|
|
|
|
|
|
|
/* Case 11 - R and W are both 0 and EDTL is also 0, and hence SCSI command PDU is accepted. */
|
|
|
|
to_be32(&scsi_reqh->expected_data_xfer_len, 0);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_scsi(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_scsi_task(&pdu, SPDK_SCSI_DIR_NONE);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
check_iscsi_task_mgmt_response(uint8_t response, uint32_t task_tag, uint32_t stat_sn,
|
|
|
|
uint32_t exp_cmd_sn, uint32_t max_cmd_sn)
|
|
|
|
{
|
|
|
|
struct spdk_iscsi_pdu *rsp_pdu;
|
|
|
|
struct iscsi_bhs_task_resp *rsph;
|
|
|
|
|
|
|
|
rsp_pdu = TAILQ_FIRST(&g_write_pdu_list);
|
|
|
|
CU_ASSERT(rsp_pdu != NULL);
|
|
|
|
rsph = (struct iscsi_bhs_task_resp *)&rsp_pdu->bhs;
|
|
|
|
CU_ASSERT(rsph->response == response);
|
|
|
|
CU_ASSERT(from_be32(&rsph->itt) == task_tag);
|
|
|
|
CU_ASSERT(from_be32(&rsph->exp_cmd_sn) == exp_cmd_sn);
|
|
|
|
CU_ASSERT(from_be32(&rsph->max_cmd_sn) == max_cmd_sn);
|
|
|
|
|
|
|
|
TAILQ_REMOVE(&g_write_pdu_list, rsp_pdu, tailq);
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_put_pdu(rsp_pdu);
|
2019-10-24 01:05:06 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
pdu_hdr_op_task_mgmt_test(void)
|
|
|
|
{
|
|
|
|
struct spdk_iscsi_sess sess = {};
|
|
|
|
struct spdk_iscsi_conn conn = {};
|
|
|
|
struct spdk_iscsi_pdu pdu = {};
|
|
|
|
struct spdk_scsi_dev dev = {};
|
|
|
|
struct spdk_scsi_lun lun = {};
|
|
|
|
struct iscsi_bhs_task_req *task_reqh;
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
/* TBD: This test covers only error paths before creating iSCSI task for now.
|
|
|
|
* Testing iSCSI task creation in iscsi_pdu_hdr_op_task() by UT is not simple
|
|
|
|
* and do it separately later.
|
|
|
|
*/
|
|
|
|
|
|
|
|
task_reqh = (struct iscsi_bhs_task_req *)&pdu.bhs;
|
|
|
|
|
|
|
|
conn.sess = &sess;
|
|
|
|
conn.dev = &dev;
|
|
|
|
|
|
|
|
/* Case 1 - Task Management Function request PDU is acceptable only on normal session. */
|
|
|
|
sess.session_type = SESSION_TYPE_DISCOVERY;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_task(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == SPDK_ISCSI_CONNECTION_FATAL);
|
|
|
|
|
|
|
|
/* Case 2 - LUN is hot removed. "LUN does not exist" response is sent. */
|
|
|
|
sess.session_type = SESSION_TYPE_NORMAL;
|
|
|
|
task_reqh->immediate = 0;
|
|
|
|
to_be32(&task_reqh->itt, 1234);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_task(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_iscsi_task_mgmt_response(ISCSI_TASK_FUNC_RESP_LUN_NOT_EXIST, 1234, 0, 0, 1);
|
|
|
|
|
|
|
|
/* Case 3 - Unassigned function is specified. "Function rejected" response is sent. */
|
2021-09-25 03:52:02 +00:00
|
|
|
TAILQ_INIT(&dev.luns);
|
|
|
|
TAILQ_INSERT_TAIL(&dev.luns, &lun, tailq);
|
2019-10-24 01:05:06 +00:00
|
|
|
task_reqh->flags = 0;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_task(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_iscsi_task_mgmt_response(ISCSI_TASK_FUNC_REJECTED, 1234, 0, 0, 2);
|
|
|
|
|
|
|
|
/* Case 4 - CLEAR TASK SET is not supported. "Task management function not supported"
|
|
|
|
* response is sent.
|
|
|
|
*/
|
|
|
|
task_reqh->flags = ISCSI_TASK_FUNC_CLEAR_TASK_SET;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_task(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_iscsi_task_mgmt_response(ISCSI_TASK_FUNC_RESP_FUNC_NOT_SUPPORTED, 1234, 0, 0, 3);
|
|
|
|
|
|
|
|
/* Case 5 - CLEAR ACA is not supported. "Task management function not supported" is sent. */
|
|
|
|
task_reqh->flags = ISCSI_TASK_FUNC_CLEAR_ACA;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_task(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_iscsi_task_mgmt_response(ISCSI_TASK_FUNC_RESP_FUNC_NOT_SUPPORTED, 1234, 0, 0, 4);
|
|
|
|
|
|
|
|
/* Case 6 - TARGET WARM RESET is not supported. "Task management function not supported
|
|
|
|
* is sent.
|
|
|
|
*/
|
|
|
|
task_reqh->flags = ISCSI_TASK_FUNC_TARGET_WARM_RESET;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_task(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_iscsi_task_mgmt_response(ISCSI_TASK_FUNC_RESP_FUNC_NOT_SUPPORTED, 1234, 0, 0, 5);
|
|
|
|
|
|
|
|
/* Case 7 - TARGET COLD RESET is not supported. "Task management function not supported
|
|
|
|
* is sent.
|
|
|
|
*/
|
|
|
|
task_reqh->flags = ISCSI_TASK_FUNC_TARGET_COLD_RESET;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_task(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_iscsi_task_mgmt_response(ISCSI_TASK_FUNC_RESP_FUNC_NOT_SUPPORTED, 1234, 0, 0, 6);
|
|
|
|
|
|
|
|
/* Case 8 - TASK REASSIGN is not supported. "Task management function not supported" is sent. */
|
|
|
|
task_reqh->flags = ISCSI_TASK_FUNC_TASK_REASSIGN;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_task(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_iscsi_task_mgmt_response(ISCSI_TASK_FUNC_RESP_FUNC_NOT_SUPPORTED, 1234, 0, 0, 7);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
pdu_hdr_op_nopout_test(void)
|
|
|
|
{
|
|
|
|
struct spdk_iscsi_sess sess = {};
|
|
|
|
struct spdk_iscsi_conn conn = {};
|
|
|
|
struct spdk_iscsi_pdu pdu = {};
|
|
|
|
struct iscsi_bhs_nop_out *nopout_reqh;
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
nopout_reqh = (struct iscsi_bhs_nop_out *)&pdu.bhs;
|
|
|
|
|
|
|
|
conn.sess = &sess;
|
|
|
|
|
|
|
|
/* Case 1 - NOP-Out PDU is acceptable only on normal session. */
|
|
|
|
sess.session_type = SESSION_TYPE_DISCOVERY;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_nopout(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == SPDK_ISCSI_CONNECTION_FATAL);
|
|
|
|
|
|
|
|
/* Case 2 - The length of the reflected ping data is limited to MaxRecvDataSegmentLength. */
|
|
|
|
sess.session_type = SESSION_TYPE_NORMAL;
|
|
|
|
pdu.data_segment_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH + 1;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_nopout(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_iscsi_reject(&pdu, ISCSI_REASON_PROTOCOL_ERROR);
|
|
|
|
|
|
|
|
/* Case 3 - If Initiator Task Tag contains 0xffffffff, the I bit must be set
|
|
|
|
* to 1 and Target Transfer Tag should be copied from NOP-In PDU. This case
|
|
|
|
* satisfies the former but doesn't satisfy the latter, but ignore the error
|
|
|
|
* for now.
|
|
|
|
*/
|
|
|
|
pdu.data_segment_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
conn.id = 1234;
|
|
|
|
to_be32(&nopout_reqh->ttt, 1235);
|
|
|
|
to_be32(&nopout_reqh->itt, 0xffffffffU);
|
|
|
|
nopout_reqh->immediate = 1;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_nopout(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
|
|
|
|
/* Case 4 - This case doesn't satisfy the above former. This error is not ignored. */
|
|
|
|
nopout_reqh->immediate = 0;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_nopout(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == SPDK_ISCSI_CONNECTION_FATAL);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
check_iscsi_r2t(struct spdk_iscsi_task *task, uint32_t len)
|
|
|
|
{
|
|
|
|
struct spdk_iscsi_pdu *rsp_pdu;
|
|
|
|
struct iscsi_bhs_r2t *rsph;
|
|
|
|
|
|
|
|
rsp_pdu = TAILQ_FIRST(&g_write_pdu_list);
|
|
|
|
CU_ASSERT(rsp_pdu != NULL);
|
|
|
|
rsph = (struct iscsi_bhs_r2t *)&rsp_pdu->bhs;
|
|
|
|
CU_ASSERT(rsph->opcode == ISCSI_OP_R2T);
|
|
|
|
CU_ASSERT(from_be64(&rsph->lun) == spdk_scsi_lun_id_int_to_fmt(task->lun_id));
|
2021-02-16 01:17:25 +00:00
|
|
|
CU_ASSERT(from_be32(&rsph->buffer_offset) + len == task->next_r2t_offset);
|
2019-10-24 01:05:06 +00:00
|
|
|
CU_ASSERT(from_be32(&rsph->desired_xfer_len) == len);
|
|
|
|
|
|
|
|
TAILQ_REMOVE(&g_write_pdu_list, rsp_pdu, tailq);
|
2020-04-16 02:10:57 +00:00
|
|
|
iscsi_put_pdu(rsp_pdu);
|
2019-10-24 01:05:06 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
pdu_hdr_op_data_test(void)
|
|
|
|
{
|
|
|
|
struct spdk_iscsi_sess sess = {};
|
|
|
|
struct spdk_iscsi_conn conn = {};
|
|
|
|
struct spdk_iscsi_pdu pdu = {};
|
|
|
|
struct spdk_iscsi_task primary = {};
|
|
|
|
struct spdk_scsi_dev dev = {};
|
|
|
|
struct spdk_scsi_lun lun = {};
|
|
|
|
struct iscsi_bhs_data_out *data_reqh;
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
data_reqh = (struct iscsi_bhs_data_out *)&pdu.bhs;
|
|
|
|
|
|
|
|
conn.sess = &sess;
|
|
|
|
conn.dev = &dev;
|
2020-06-29 09:11:48 +00:00
|
|
|
TAILQ_INIT(&conn.active_r2t_tasks);
|
2019-10-24 01:05:06 +00:00
|
|
|
|
|
|
|
/* Case 1 - SCSI Data-Out PDU is acceptable only on normal session. */
|
|
|
|
sess.session_type = SESSION_TYPE_DISCOVERY;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_data(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == SPDK_ISCSI_CONNECTION_FATAL);
|
|
|
|
|
|
|
|
/* Case 2 - Data segment length must not be more than MaxRecvDataSegmentLength. */
|
|
|
|
sess.session_type = SESSION_TYPE_NORMAL;
|
|
|
|
pdu.data_segment_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH + 1;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_data(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_iscsi_reject(&pdu, ISCSI_REASON_PROTOCOL_ERROR);
|
|
|
|
|
|
|
|
/* Case 3 - R2T task whose Target Transfer Tag matches is not found. */
|
|
|
|
pdu.data_segment_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_data(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_iscsi_reject(&pdu, ISCSI_REASON_INVALID_PDU_FIELD);
|
|
|
|
|
|
|
|
/* Case 4 - R2T task whose Target Transfer Tag matches is found but data segment length
|
|
|
|
* is more than Desired Data Transfer Length of the R2T.
|
|
|
|
*/
|
|
|
|
primary.desired_data_transfer_length = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH - 1;
|
|
|
|
conn.pending_r2t = 1;
|
2020-06-29 09:11:48 +00:00
|
|
|
TAILQ_INSERT_TAIL(&conn.active_r2t_tasks, &primary, link);
|
2019-10-24 01:05:06 +00:00
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_data(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == SPDK_ISCSI_CONNECTION_FATAL);
|
|
|
|
|
|
|
|
/* Case 5 - Initiator task tag doesn't match tag of R2T task. */
|
|
|
|
primary.desired_data_transfer_length = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
to_be32(&data_reqh->itt, 1);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_data(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_iscsi_reject(&pdu, ISCSI_REASON_INVALID_PDU_FIELD);
|
|
|
|
|
|
|
|
/* Case 6 - DataSN doesn't match the Data-Out PDU number within the current
|
|
|
|
* output sequence.
|
|
|
|
*/
|
|
|
|
to_be32(&data_reqh->itt, 0);
|
|
|
|
to_be32(&data_reqh->data_sn, 1);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_data(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_iscsi_reject(&pdu, ISCSI_REASON_PROTOCOL_ERROR);
|
|
|
|
|
|
|
|
/* Case 7 - Output sequence must be in increasing buffer offset and must not
|
|
|
|
* be overlaid but they are not satisfied.
|
|
|
|
*/
|
|
|
|
to_be32(&data_reqh->data_sn, 0);
|
|
|
|
to_be32(&data_reqh->buffer_offset, 4096);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_data(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == SPDK_ISCSI_CONNECTION_FATAL);
|
|
|
|
|
|
|
|
/* Case 8 - Data segment length must not exceed MaxBurstLength. */
|
|
|
|
to_be32(&data_reqh->buffer_offset, 0);
|
|
|
|
sess.MaxBurstLength = pdu.data_segment_len - 1;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_data(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == SPDK_ISCSI_CONNECTION_FATAL);
|
|
|
|
|
|
|
|
/* Case 9 - LUN is hot removed. */
|
|
|
|
sess.MaxBurstLength = pdu.data_segment_len * 4;
|
|
|
|
to_be32(&data_reqh->data_sn, primary.r2t_datasn);
|
|
|
|
to_be32(&data_reqh->buffer_offset, primary.next_expected_r2t_offset);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_data(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
2021-02-16 01:17:25 +00:00
|
|
|
check_iscsi_reject(&pdu, ISCSI_REASON_PROTOCOL_ERROR);
|
2019-10-24 01:05:06 +00:00
|
|
|
|
2021-02-16 01:17:25 +00:00
|
|
|
/* Case 10 - SCSI Data-Out PDU is correct and processed. Its F bit is 0 and hence
|
|
|
|
* R2T is not sent.
|
2019-10-24 01:05:06 +00:00
|
|
|
*/
|
2021-09-25 03:52:02 +00:00
|
|
|
TAILQ_INIT(&dev.luns);
|
|
|
|
TAILQ_INSERT_TAIL(&dev.luns, &lun, tailq);
|
2019-10-24 01:05:06 +00:00
|
|
|
to_be32(&data_reqh->data_sn, primary.r2t_datasn);
|
|
|
|
to_be32(&data_reqh->buffer_offset, primary.next_expected_r2t_offset);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_data(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
2021-02-16 01:17:25 +00:00
|
|
|
CU_ASSERT(!pdu.is_rejected);
|
2021-02-14 21:39:06 +00:00
|
|
|
CU_ASSERT(pdu.data_buf_len == SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH);
|
2019-10-24 01:05:06 +00:00
|
|
|
pdu.task = NULL;
|
|
|
|
|
2021-02-16 01:17:25 +00:00
|
|
|
/* Case 11 - SCSI Data-Out PDU is correct and processed. Its F bit is 1 and hence
|
|
|
|
* R2T is sent.
|
2019-10-24 01:05:06 +00:00
|
|
|
*/
|
|
|
|
data_reqh->flags |= ISCSI_FLAG_FINAL;
|
|
|
|
to_be32(&data_reqh->data_sn, primary.r2t_datasn);
|
|
|
|
to_be32(&data_reqh->buffer_offset, primary.next_expected_r2t_offset);
|
|
|
|
primary.scsi.transfer_len = pdu.data_segment_len * 5;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_op_data(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
2021-02-16 01:17:25 +00:00
|
|
|
CU_ASSERT(!pdu.is_rejected);
|
|
|
|
check_iscsi_r2t(&primary, pdu.data_segment_len * 4);
|
2019-10-24 01:05:06 +00:00
|
|
|
}
|
|
|
|
|
2021-02-08 15:28:44 +00:00
|
|
|
/* Test an ISCSI_OP_TEXT PDU with CONTINUE bit set but
|
|
|
|
* no data.
|
|
|
|
*/
|
|
|
|
static void
|
|
|
|
empty_text_with_cbit_test(void)
|
|
|
|
{
|
|
|
|
struct spdk_iscsi_sess sess = {};
|
|
|
|
struct spdk_iscsi_conn conn = {};
|
|
|
|
struct spdk_scsi_dev dev = {};
|
|
|
|
struct spdk_iscsi_pdu *req_pdu;
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
req_pdu = iscsi_get_pdu(&conn);
|
|
|
|
|
|
|
|
sess.ExpCmdSN = 0;
|
|
|
|
sess.MaxCmdSN = 64;
|
|
|
|
sess.session_type = SESSION_TYPE_NORMAL;
|
|
|
|
sess.MaxBurstLength = 1024;
|
|
|
|
|
|
|
|
conn.full_feature = 1;
|
|
|
|
conn.sess = &sess;
|
|
|
|
conn.dev = &dev;
|
|
|
|
conn.state = ISCSI_CONN_STATE_RUNNING;
|
|
|
|
|
|
|
|
memset(&req_pdu->bhs, 0, sizeof(req_pdu->bhs));
|
|
|
|
req_pdu->bhs.opcode = ISCSI_OP_TEXT;
|
|
|
|
req_pdu->bhs.flags = ISCSI_TEXT_CONTINUE;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_handle(&conn, req_pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
CU_ASSERT(!req_pdu->is_rejected);
|
|
|
|
rc = iscsi_pdu_payload_handle(&conn, req_pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
|
|
|
|
iscsi_put_pdu(req_pdu);
|
|
|
|
}
|
|
|
|
|
2021-03-01 13:05:05 +00:00
|
|
|
static void
|
|
|
|
check_pdu_payload_read(struct spdk_iscsi_pdu *pdu, struct spdk_mobj *mobj,
|
|
|
|
int rc, int index, uint32_t read_offset)
|
|
|
|
{
|
|
|
|
uint64_t buf_offset;
|
|
|
|
uint32_t *data;
|
|
|
|
uint32_t i;
|
|
|
|
|
|
|
|
data = (uint32_t *)pdu->data;
|
|
|
|
buf_offset = (uint64_t)pdu->data - (uint64_t)mobj->buf;
|
|
|
|
|
|
|
|
CU_ASSERT(pdu->mobj[index] == mobj);
|
|
|
|
CU_ASSERT(pdu->data_from_mempool == true);
|
|
|
|
CU_ASSERT(buf_offset == 0 || pdu->data_offset == 0);
|
|
|
|
CU_ASSERT(mobj->data_len + pdu->data_offset == buf_offset + pdu->data_valid_bytes);
|
|
|
|
CU_ASSERT(rc > 0 || pdu->data_valid_bytes == pdu->data_segment_len);
|
|
|
|
|
|
|
|
for (i = 0; i < pdu->data_valid_bytes - pdu->data_offset; i += 4) {
|
|
|
|
CU_ASSERT(data[i / 4] == (uint32_t)(read_offset + i));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
pdu_payload_read_test(void)
|
|
|
|
{
|
|
|
|
struct spdk_iscsi_conn conn = {};
|
|
|
|
struct spdk_iscsi_pdu pdu = {};
|
|
|
|
struct spdk_mobj mobj1 = {}, mobj2 = {};
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
g_iscsi.FirstBurstLength = SPDK_ISCSI_FIRST_BURST_LENGTH;
|
|
|
|
|
2022-11-21 09:29:09 +00:00
|
|
|
alloc_mock_mobj(&mobj1, SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH);
|
|
|
|
alloc_mock_mobj(&mobj2, SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH);
|
2021-03-01 13:05:05 +00:00
|
|
|
|
|
|
|
MOCK_SET(spdk_mempool_get, &mobj1);
|
|
|
|
|
|
|
|
/* The following tests assume that a iscsi_conn_read_data() call could read
|
|
|
|
* the required length of the data and all read lengths are 4 bytes multiples.
|
|
|
|
* The latter is to verify data is copied to the correct offset by using data patterns.
|
|
|
|
*/
|
|
|
|
|
|
|
|
/* Case 1: data segment size is equal with max immediate data size. */
|
|
|
|
pdu.data_segment_len = iscsi_get_max_immediate_data_size();
|
|
|
|
pdu.data_buf_len = pdu.data_segment_len;
|
|
|
|
g_conn_read_len = 0;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_payload_read(&conn, &pdu);
|
|
|
|
check_pdu_payload_read(&pdu, &mobj1, rc, 0, 0);
|
|
|
|
|
|
|
|
memset(&pdu, 0, sizeof(pdu));
|
|
|
|
mobj1.data_len = 0;
|
|
|
|
|
|
|
|
/* Case 2: data segment size is equal with SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH. */
|
|
|
|
pdu.data_segment_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
pdu.data_buf_len = pdu.data_segment_len;
|
|
|
|
g_conn_read_len = 0;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_payload_read(&conn, &pdu);
|
|
|
|
check_pdu_payload_read(&pdu, &mobj1, rc, 0, 0);
|
|
|
|
|
|
|
|
memset(&pdu, 0, sizeof(pdu));
|
|
|
|
mobj1.data_len = 0;
|
|
|
|
|
|
|
|
/* Case 3: data segment size is larger than SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH.
|
|
|
|
* This should result in error.
|
|
|
|
*/
|
|
|
|
pdu.data_segment_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH + 1;
|
|
|
|
pdu.data_buf_len = pdu.data_segment_len;
|
|
|
|
g_conn_read_len = 0;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_payload_read(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc < 0);
|
|
|
|
|
|
|
|
/* Case 4: read starts from the middle of the 1st data buffer, the 1st data buffer
|
|
|
|
* ran out, allocate the 2nd data buffer, and read the remaining data to the 2nd
|
|
|
|
* data buffer.
|
|
|
|
*/
|
|
|
|
mobj1.data_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH / 2;
|
|
|
|
pdu.data_segment_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
pdu.data_buf_len = SPDK_BDEV_BUF_SIZE_WITH_MD(SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH);
|
|
|
|
pdu.mobj[0] = &mobj1;
|
|
|
|
pdu.data = (void *)((uint64_t)mobj1.buf + SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH / 2);
|
|
|
|
pdu.data_from_mempool = true;
|
|
|
|
g_conn_read_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH / 2;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_payload_read(&conn, &pdu);
|
|
|
|
check_pdu_payload_read(&pdu, &mobj1, rc, 0, SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH / 2);
|
|
|
|
|
|
|
|
MOCK_SET(spdk_mempool_get, &mobj2);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_payload_read(&conn, &pdu);
|
|
|
|
check_pdu_payload_read(&pdu, &mobj2, rc, 1, SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH);
|
|
|
|
|
2021-10-21 06:29:34 +00:00
|
|
|
/* Case 5: data segment size is SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH, data digest
|
|
|
|
* is enabled, and reading PDU data is split between data segment and data digest.
|
|
|
|
*/
|
|
|
|
conn.data_digest = true;
|
|
|
|
memset(&pdu, 0, sizeof(pdu));
|
|
|
|
pdu.crc32c = SPDK_CRC32C_INITIAL;
|
|
|
|
pdu.data = mobj1.buf;
|
|
|
|
pdu.data_segment_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
pdu.mobj[0] = &mobj1;
|
|
|
|
pdu.data_valid_bytes = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
mobj1.data_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
|
|
|
|
/* generate data digest. */
|
|
|
|
g_data_digest = spdk_crc32c_update(mobj1.buf, SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH,
|
|
|
|
SPDK_CRC32C_INITIAL);
|
|
|
|
g_data_digest ^= SPDK_CRC32C_XOR;
|
|
|
|
g_conn_read_data_digest = true;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_payload_read(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
CU_ASSERT(pdu.ddigest_valid_bytes == ISCSI_DIGEST_LEN);
|
|
|
|
CU_ASSERT(pdu.mobj[1] == NULL);
|
|
|
|
|
|
|
|
g_conn_read_data_digest = false;
|
|
|
|
g_conn_read_len = 0;
|
|
|
|
MOCK_SET(spdk_mempool_get, &mobj1);
|
|
|
|
mobj1.data_len = 0;
|
|
|
|
|
|
|
|
g_conn_read_len = 0;
|
2021-03-01 13:05:05 +00:00
|
|
|
MOCK_CLEAR(spdk_mempool_get);
|
|
|
|
|
|
|
|
free(mobj1.buf);
|
|
|
|
free(mobj2.buf);
|
|
|
|
}
|
|
|
|
|
2021-02-25 19:34:01 +00:00
|
|
|
static void
|
|
|
|
check_pdu_hdr_handle(struct spdk_iscsi_pdu *pdu, struct spdk_mobj *mobj, uint32_t offset,
|
|
|
|
struct spdk_iscsi_task *primary)
|
|
|
|
{
|
|
|
|
CU_ASSERT(pdu->mobj[0] == mobj);
|
|
|
|
CU_ASSERT(pdu->data == NULL || pdu->data == (void *)((uint64_t)mobj->buf + offset));
|
|
|
|
CU_ASSERT(primary->mobj == NULL);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
check_pdu_payload_handle(struct spdk_iscsi_pdu *pdu, struct spdk_iscsi_task *primary,
|
|
|
|
struct spdk_mobj *pdu_mobj0, struct spdk_mobj *pdu_mobj1,
|
|
|
|
struct spdk_mobj *primary_mobj, uint32_t primary_offset)
|
|
|
|
{
|
|
|
|
CU_ASSERT(pdu->mobj[0] == pdu_mobj0);
|
|
|
|
CU_ASSERT(pdu->mobj[1] == pdu_mobj1);
|
|
|
|
CU_ASSERT(primary->mobj == primary_mobj);
|
|
|
|
CU_ASSERT(primary->current_data_offset == primary_offset);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
check_write_subtask_submit(struct spdk_scsi_lun *lun, struct spdk_mobj *mobj,
|
|
|
|
struct spdk_iscsi_pdu *pdu,
|
|
|
|
int index, uint32_t offset, uint32_t length)
|
|
|
|
{
|
|
|
|
struct spdk_scsi_task *scsi_task;
|
|
|
|
struct spdk_iscsi_task *subtask;
|
|
|
|
uint32_t *data;
|
|
|
|
uint32_t i;
|
|
|
|
|
|
|
|
scsi_task = TAILQ_FIRST(&lun->tasks);
|
|
|
|
SPDK_CU_ASSERT_FATAL(scsi_task != NULL);
|
|
|
|
TAILQ_REMOVE(&lun->tasks, scsi_task, scsi_link);
|
|
|
|
|
|
|
|
subtask = iscsi_task_from_scsi_task(scsi_task);
|
|
|
|
|
|
|
|
CU_ASSERT(iscsi_task_get_pdu(subtask) == pdu);
|
|
|
|
CU_ASSERT(pdu->mobj[index] == mobj);
|
|
|
|
CU_ASSERT(subtask->scsi.offset == offset);
|
|
|
|
CU_ASSERT(subtask->scsi.length == length);
|
|
|
|
CU_ASSERT(subtask->scsi.iovs[0].iov_base == mobj->buf);
|
|
|
|
CU_ASSERT(subtask->scsi.iovs[0].iov_len == length);
|
|
|
|
|
|
|
|
data = (uint32_t *)mobj->buf;
|
|
|
|
for (i = 0; i < length; i += 4) {
|
|
|
|
CU_ASSERT(data[i / 4] == offset + i);
|
|
|
|
}
|
|
|
|
|
|
|
|
free(subtask);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
data_out_pdu_sequence_test(void)
|
|
|
|
{
|
|
|
|
struct spdk_scsi_lun lun = { .tasks = TAILQ_HEAD_INITIALIZER(lun.tasks), };
|
2021-09-25 03:52:02 +00:00
|
|
|
struct spdk_scsi_dev dev = { .luns = TAILQ_HEAD_INITIALIZER(dev.luns), };
|
2021-02-25 19:34:01 +00:00
|
|
|
struct spdk_iscsi_sess sess = {
|
|
|
|
.session_type = SESSION_TYPE_NORMAL,
|
|
|
|
.MaxBurstLength = SPDK_ISCSI_MAX_BURST_LENGTH,
|
|
|
|
};
|
|
|
|
struct spdk_iscsi_conn conn = {
|
|
|
|
.full_feature = true,
|
|
|
|
.state = ISCSI_CONN_STATE_RUNNING,
|
|
|
|
.sess = &sess,
|
|
|
|
.dev = &dev,
|
|
|
|
.active_r2t_tasks = TAILQ_HEAD_INITIALIZER(conn.active_r2t_tasks),
|
|
|
|
};
|
|
|
|
struct spdk_iscsi_task primary = {};
|
|
|
|
struct spdk_iscsi_pdu pdu = {};
|
|
|
|
struct spdk_mobj mobj1 = {}, mobj2 = {}, mobj3 = {};
|
|
|
|
struct iscsi_bhs_data_out *data_reqh;
|
|
|
|
int rc;
|
|
|
|
|
2021-09-25 03:52:02 +00:00
|
|
|
TAILQ_INSERT_TAIL(&dev.luns, &lun, tailq);
|
|
|
|
|
2022-11-21 09:29:09 +00:00
|
|
|
alloc_mock_mobj(&mobj1, SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH);
|
|
|
|
alloc_mock_mobj(&mobj2, SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH);
|
|
|
|
alloc_mock_mobj(&mobj3, SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH);
|
2021-02-25 19:34:01 +00:00
|
|
|
|
|
|
|
/* Test scenario is as follows.
|
|
|
|
*
|
|
|
|
* Some iSCSI initiator sends a Data-OUT PDU sequence such that the size of
|
|
|
|
* the data segment of any Data-OUT PDU is not block size multiples.
|
|
|
|
* Test if such complex Data-OUT PDU sequence is processed correctly.
|
|
|
|
*
|
|
|
|
* Desired Data Transfer Length is 5 * SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH / 2.
|
|
|
|
* Number of Data-OUT PDUs is 4. Length of the data segment of the first two PDUs are
|
|
|
|
* SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH / 2 - 4. Length of the data segment of the
|
|
|
|
* third PDU is SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH. Length of the data segment
|
|
|
|
* of the final PDU is SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH / 2 + 8.
|
|
|
|
*
|
|
|
|
* Three data buffers should be used and three subtasks should be created and submitted.
|
|
|
|
*
|
|
|
|
* The test scenario assume that a iscsi_conn_read_data() call could read
|
|
|
|
* the required length of the data and all read lengths are 4 bytes multiples.
|
|
|
|
* The latter is to verify data is copied to the correct offset by using data patterns.
|
|
|
|
*/
|
|
|
|
|
|
|
|
primary.scsi.transfer_len = 5 * SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH / 2;
|
|
|
|
primary.desired_data_transfer_length = primary.scsi.transfer_len;
|
|
|
|
TAILQ_INSERT_TAIL(&conn.active_r2t_tasks, &primary, link);
|
|
|
|
conn.pending_r2t = 1;
|
|
|
|
g_conn_read_len = 0;
|
|
|
|
|
|
|
|
/* The 1st Data-OUT PDU */
|
|
|
|
data_reqh = (struct iscsi_bhs_data_out *)&pdu.bhs;
|
|
|
|
pdu.bhs.opcode = ISCSI_OP_SCSI_DATAOUT;
|
|
|
|
pdu.data_segment_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH / 2 - 4;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_handle(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_hdr_handle(&pdu, NULL, 0, &primary);
|
|
|
|
|
|
|
|
MOCK_SET(spdk_mempool_get, &mobj1);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_payload_read(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_payload_read(&pdu, &mobj1, rc, 0, 0);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_payload_handle(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_payload_handle(&pdu, &primary, NULL, NULL, &mobj1, 0);
|
|
|
|
|
|
|
|
/* The 2nd Data-OUT PDU */
|
|
|
|
memset(&pdu, 0, sizeof(pdu));
|
|
|
|
pdu.bhs.opcode = ISCSI_OP_SCSI_DATAOUT;
|
|
|
|
pdu.data_segment_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH / 2 - 4;
|
|
|
|
to_be32(&data_reqh->data_sn, 1);
|
|
|
|
to_be32(&data_reqh->buffer_offset, SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH / 2 - 4);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_handle(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_hdr_handle(&pdu, &mobj1, SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH / 2 - 4, &primary);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_payload_read(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_payload_read(&pdu, &mobj1, rc, 0, SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH / 2 - 4);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_payload_handle(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_payload_handle(&pdu, &primary, NULL, NULL, &mobj1, 0);
|
|
|
|
|
|
|
|
/* The 3rd Data-OUT PDU */
|
|
|
|
memset(&pdu, 0, sizeof(pdu));
|
|
|
|
pdu.bhs.opcode = ISCSI_OP_SCSI_DATAOUT;
|
|
|
|
pdu.data_segment_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH;
|
|
|
|
to_be32(&data_reqh->data_sn, 2);
|
|
|
|
to_be32(&data_reqh->buffer_offset, SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH - 8);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_handle(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_hdr_handle(&pdu, &mobj1, SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH - 8, &primary);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_payload_read(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc > 0);
|
|
|
|
check_pdu_payload_read(&pdu, &mobj1, rc, 0, SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH - 8);
|
|
|
|
|
|
|
|
MOCK_SET(spdk_mempool_get, &mobj2);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_payload_read(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_payload_read(&pdu, &mobj2, rc, 1, SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_payload_handle(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_payload_handle(&pdu, &primary, &mobj1, NULL, &mobj2,
|
|
|
|
SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH);
|
|
|
|
|
|
|
|
check_write_subtask_submit(&lun, &mobj1, &pdu, 0, 0, SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH);
|
|
|
|
|
|
|
|
/* The 4th and final Data-OUT PDU */
|
|
|
|
memset(&pdu, 0, sizeof(pdu));
|
|
|
|
pdu.bhs.opcode = ISCSI_OP_SCSI_DATAOUT;
|
|
|
|
pdu.data_segment_len = SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH / 2 + 8;
|
|
|
|
data_reqh->flags |= ISCSI_FLAG_FINAL;
|
|
|
|
to_be32(&data_reqh->data_sn, 3);
|
|
|
|
to_be32(&data_reqh->buffer_offset, 2 * SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH - 8);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_handle(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_hdr_handle(&pdu, &mobj2, SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH - 8, &primary);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_payload_read(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc > 0);
|
|
|
|
check_pdu_payload_read(&pdu, &mobj2, rc, 0, 2 * SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH - 8);
|
|
|
|
|
|
|
|
MOCK_SET(spdk_mempool_get, &mobj3);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_payload_read(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_payload_read(&pdu, &mobj3, rc, 1, 2 * SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_payload_handle(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_payload_handle(&pdu, &primary, &mobj2, &mobj3, NULL,
|
|
|
|
5 * SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH / 2);
|
|
|
|
|
|
|
|
check_write_subtask_submit(&lun, &mobj2, &pdu, 0, SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH,
|
|
|
|
SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH);
|
|
|
|
|
|
|
|
check_write_subtask_submit(&lun, &mobj3, &pdu, 1, 2 * SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH,
|
|
|
|
SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH / 2);
|
|
|
|
|
|
|
|
CU_ASSERT(TAILQ_EMPTY(&lun.tasks));
|
|
|
|
|
|
|
|
MOCK_CLEAR(spdk_mempool_get);
|
|
|
|
|
|
|
|
free(mobj1.buf);
|
|
|
|
free(mobj2.buf);
|
|
|
|
free(mobj3.buf);
|
|
|
|
}
|
|
|
|
|
2021-09-29 05:16:50 +00:00
|
|
|
static void
|
|
|
|
immediate_data_and_data_out_pdu_sequence_test(void)
|
|
|
|
{
|
|
|
|
struct spdk_scsi_lun lun = { .tasks = TAILQ_HEAD_INITIALIZER(lun.tasks), };
|
|
|
|
struct spdk_scsi_dev dev = { .luns = TAILQ_HEAD_INITIALIZER(dev.luns), };
|
|
|
|
struct spdk_iscsi_sess sess = {
|
|
|
|
.session_type = SESSION_TYPE_NORMAL,
|
|
|
|
.MaxBurstLength = SPDK_ISCSI_MAX_BURST_LENGTH,
|
|
|
|
.ImmediateData = true,
|
|
|
|
.FirstBurstLength = SPDK_ISCSI_FIRST_BURST_LENGTH,
|
|
|
|
};
|
|
|
|
struct spdk_iscsi_conn conn = {
|
|
|
|
.full_feature = true,
|
|
|
|
.state = ISCSI_CONN_STATE_RUNNING,
|
|
|
|
.sess = &sess,
|
|
|
|
.dev = &dev,
|
|
|
|
.active_r2t_tasks = TAILQ_HEAD_INITIALIZER(conn.active_r2t_tasks),
|
|
|
|
.ttt = 1,
|
|
|
|
};
|
|
|
|
struct spdk_iscsi_pdu pdu = {};
|
|
|
|
struct spdk_mobj mobj = {};
|
|
|
|
struct spdk_iscsi_task *primary;
|
|
|
|
struct iscsi_bhs_scsi_req *scsi_reqh;
|
|
|
|
struct iscsi_bhs_data_out *data_reqh;
|
|
|
|
int rc;
|
|
|
|
|
|
|
|
TAILQ_INSERT_TAIL(&dev.luns, &lun, tailq);
|
|
|
|
|
2022-11-21 09:29:09 +00:00
|
|
|
alloc_mock_mobj(&mobj, SPDK_ISCSI_MAX_RECV_DATA_SEGMENT_LENGTH);
|
2021-09-29 05:16:50 +00:00
|
|
|
|
|
|
|
/* Test scenario is as follows.
|
|
|
|
*
|
|
|
|
* Some iSCSI initiator sends an immediate data and more solicited data
|
|
|
|
* through R2T within the same SCSI write such that the size of the data
|
|
|
|
* segment of a SCSI Write PDU or any Data-OUT PDU is not block size multiples.
|
|
|
|
* Test if such complex SCSI write is processed correctly.
|
|
|
|
*
|
|
|
|
* Desired Data Transfer Length of a SCSI Write is 65536.
|
|
|
|
* PDU sequences are:
|
|
|
|
* Host sent SCSI Write with 5792 bytes and F = 1
|
|
|
|
* Target sent a R2T
|
|
|
|
* Host sent Data-OUT with 15880 bytes
|
|
|
|
* Host sent Data-OUT with 11536 bytes
|
|
|
|
* Host sent Data-OUT with 2848 bytes
|
|
|
|
* Host sent Data-OUT with 11536 bytes
|
|
|
|
* Host sent Data-OUT with 5744 bytes
|
|
|
|
* Host sent Data-OUT with 12200 bytes and F = 1
|
|
|
|
*
|
|
|
|
* One data buffer should be used and one subtask should be created and submitted.
|
|
|
|
*
|
|
|
|
* The test scenario assume that a iscsi_conn_read_data() call could read
|
|
|
|
* the required length of the data and all read lengths are 4 bytes multiples.
|
|
|
|
* The latter is to verify data is copied to the correct offset by using data patterns.
|
|
|
|
*/
|
|
|
|
|
|
|
|
g_conn_read_len = 0;
|
|
|
|
|
|
|
|
/* SCSI Write PDU with immediate data */
|
|
|
|
scsi_reqh = (struct iscsi_bhs_scsi_req *)&pdu.bhs;
|
|
|
|
scsi_reqh->opcode = ISCSI_OP_SCSI;
|
|
|
|
scsi_reqh->write_bit = 1;
|
|
|
|
scsi_reqh->final_bit = 1;
|
|
|
|
pdu.data_segment_len = 5792;
|
|
|
|
to_be32(&scsi_reqh->expected_data_xfer_len, 65536);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_handle(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
|
|
|
|
primary = pdu.task;
|
|
|
|
SPDK_CU_ASSERT_FATAL(primary != NULL);
|
|
|
|
|
|
|
|
CU_ASSERT(primary->scsi.transfer_len == 65536);
|
|
|
|
CU_ASSERT(primary->scsi.dxfer_dir == SPDK_SCSI_DIR_TO_DEV);
|
|
|
|
CU_ASSERT(pdu.data_buf_len == 65536);
|
|
|
|
|
|
|
|
MOCK_SET(spdk_mempool_get, &mobj);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_payload_read(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_payload_read(&pdu, &mobj, rc, 0, 0);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_payload_handle(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
CU_ASSERT(primary->next_expected_r2t_offset == 5792);
|
|
|
|
CU_ASSERT(primary->current_r2t_length == 0);
|
|
|
|
CU_ASSERT(primary->next_r2t_offset == 65536);
|
|
|
|
CU_ASSERT(primary->ttt == 2);
|
|
|
|
CU_ASSERT(primary == TAILQ_FIRST(&conn.active_r2t_tasks));
|
|
|
|
|
|
|
|
check_pdu_payload_handle(&pdu, primary, NULL, NULL, &mobj, 0);
|
|
|
|
|
|
|
|
data_reqh = (struct iscsi_bhs_data_out *)&pdu.bhs;
|
|
|
|
|
|
|
|
/* The 1st Data-OUT PDU */
|
|
|
|
memset(&pdu, 0, sizeof(pdu));
|
|
|
|
data_reqh->opcode = ISCSI_OP_SCSI_DATAOUT;
|
|
|
|
to_be32(&data_reqh->ttt, 2);
|
|
|
|
to_be32(&data_reqh->buffer_offset, 5792);
|
|
|
|
pdu.data_segment_len = 15880;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_handle(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_hdr_handle(&pdu, &mobj, 5792, primary);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_payload_read(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_payload_read(&pdu, &mobj, rc, 0, 5792);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_payload_handle(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_payload_handle(&pdu, primary, NULL, NULL, &mobj, 0);
|
|
|
|
|
|
|
|
/* The 2nd Data-OUT PDU */
|
|
|
|
memset(&pdu, 0, sizeof(pdu));
|
|
|
|
data_reqh->opcode = ISCSI_OP_SCSI_DATAOUT;
|
|
|
|
to_be32(&data_reqh->ttt, 2);
|
|
|
|
to_be32(&data_reqh->buffer_offset, 21672);
|
|
|
|
to_be32(&data_reqh->data_sn, 1);
|
|
|
|
pdu.data_segment_len = 11536;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_handle(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_hdr_handle(&pdu, &mobj, 21672, primary);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_payload_read(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_payload_read(&pdu, &mobj, rc, 0, 21672);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_payload_handle(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_payload_handle(&pdu, primary, NULL, NULL, &mobj, 0);
|
|
|
|
|
|
|
|
/* The 3rd Data-OUT PDU */
|
|
|
|
memset(&pdu, 0, sizeof(pdu));
|
|
|
|
data_reqh->opcode = ISCSI_OP_SCSI_DATAOUT;
|
|
|
|
to_be32(&data_reqh->ttt, 2);
|
|
|
|
to_be32(&data_reqh->buffer_offset, 33208);
|
|
|
|
to_be32(&data_reqh->data_sn, 2);
|
|
|
|
pdu.data_segment_len = 2848;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_handle(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_hdr_handle(&pdu, &mobj, 33208, primary);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_payload_read(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_payload_read(&pdu, &mobj, rc, 0, 33208);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_payload_handle(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_payload_handle(&pdu, primary, NULL, NULL, &mobj, 0);
|
|
|
|
|
|
|
|
/* The 4th Data-OUT PDU */
|
|
|
|
memset(&pdu, 0, sizeof(pdu));
|
|
|
|
data_reqh->opcode = ISCSI_OP_SCSI_DATAOUT;
|
|
|
|
to_be32(&data_reqh->ttt, 2);
|
|
|
|
to_be32(&data_reqh->buffer_offset, 36056);
|
|
|
|
to_be32(&data_reqh->data_sn, 3);
|
|
|
|
pdu.data_segment_len = 11536;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_handle(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_hdr_handle(&pdu, &mobj, 36056, primary);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_payload_read(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_payload_read(&pdu, &mobj, rc, 0, 36056);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_payload_handle(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_payload_handle(&pdu, primary, NULL, NULL, &mobj, 0);
|
|
|
|
|
|
|
|
/* The 5th Data-OUT PDU */
|
|
|
|
memset(&pdu, 0, sizeof(pdu));
|
|
|
|
data_reqh->opcode = ISCSI_OP_SCSI_DATAOUT;
|
|
|
|
to_be32(&data_reqh->ttt, 2);
|
|
|
|
to_be32(&data_reqh->buffer_offset, 47592);
|
|
|
|
to_be32(&data_reqh->data_sn, 4);
|
|
|
|
pdu.data_segment_len = 5744;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_handle(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_hdr_handle(&pdu, &mobj, 47592, primary);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_payload_read(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_payload_read(&pdu, &mobj, rc, 0, 47592);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_payload_handle(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_payload_handle(&pdu, primary, NULL, NULL, &mobj, 0);
|
|
|
|
|
|
|
|
/* The 6th and final Data-OUT PDU */
|
|
|
|
memset(&pdu, 0, sizeof(pdu));
|
|
|
|
pdu.bhs.opcode = ISCSI_OP_SCSI_DATAOUT;
|
|
|
|
data_reqh->flags |= ISCSI_FLAG_FINAL;
|
|
|
|
to_be32(&data_reqh->ttt, 2);
|
|
|
|
to_be32(&data_reqh->buffer_offset, 53336);
|
|
|
|
to_be32(&data_reqh->data_sn, 5);
|
|
|
|
pdu.data_segment_len = 12200;
|
|
|
|
|
|
|
|
rc = iscsi_pdu_hdr_handle(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_hdr_handle(&pdu, &mobj, 53336, primary);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_payload_read(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_payload_read(&pdu, &mobj, rc, 0, 53336);
|
|
|
|
|
|
|
|
rc = iscsi_pdu_payload_handle(&conn, &pdu);
|
|
|
|
CU_ASSERT(rc == 0);
|
|
|
|
check_pdu_payload_handle(&pdu, primary, &mobj, NULL, NULL, 65536);
|
|
|
|
|
|
|
|
check_write_subtask_submit(&lun, &mobj, &pdu, 0, 0, 65536);
|
|
|
|
|
|
|
|
CU_ASSERT(TAILQ_EMPTY(&lun.tasks));
|
|
|
|
|
|
|
|
MOCK_CLEAR(spdk_mempool_get);
|
|
|
|
|
|
|
|
free(primary);
|
|
|
|
free(mobj.buf);
|
|
|
|
}
|
|
|
|
|
2016-11-22 19:47:04 +00:00
|
|
|
int
|
|
|
|
main(int argc, char **argv)
|
|
|
|
{
|
|
|
|
CU_pSuite suite = NULL;
|
|
|
|
unsigned int num_failures;
|
|
|
|
|
2020-03-11 17:59:24 +00:00
|
|
|
CU_set_error_action(CUEA_ABORT);
|
|
|
|
CU_initialize_registry();
|
2016-11-22 19:47:04 +00:00
|
|
|
|
|
|
|
suite = CU_add_suite("iscsi_suite", NULL, NULL);
|
|
|
|
|
2020-03-11 19:15:39 +00:00
|
|
|
CU_ADD_TEST(suite, op_login_check_target_test);
|
|
|
|
CU_ADD_TEST(suite, op_login_session_normal_test);
|
|
|
|
CU_ADD_TEST(suite, maxburstlength_test);
|
|
|
|
CU_ADD_TEST(suite, underflow_for_read_transfer_test);
|
|
|
|
CU_ADD_TEST(suite, underflow_for_zero_read_transfer_test);
|
|
|
|
CU_ADD_TEST(suite, underflow_for_request_sense_test);
|
|
|
|
CU_ADD_TEST(suite, underflow_for_check_condition_test);
|
|
|
|
CU_ADD_TEST(suite, add_transfer_task_test);
|
|
|
|
CU_ADD_TEST(suite, get_transfer_task_test);
|
|
|
|
CU_ADD_TEST(suite, del_transfer_task_test);
|
|
|
|
CU_ADD_TEST(suite, clear_all_transfer_tasks_test);
|
|
|
|
CU_ADD_TEST(suite, build_iovs_test);
|
|
|
|
CU_ADD_TEST(suite, build_iovs_with_md_test);
|
|
|
|
CU_ADD_TEST(suite, pdu_hdr_op_login_test);
|
|
|
|
CU_ADD_TEST(suite, pdu_hdr_op_text_test);
|
|
|
|
CU_ADD_TEST(suite, pdu_hdr_op_logout_test);
|
|
|
|
CU_ADD_TEST(suite, pdu_hdr_op_scsi_test);
|
|
|
|
CU_ADD_TEST(suite, pdu_hdr_op_task_mgmt_test);
|
|
|
|
CU_ADD_TEST(suite, pdu_hdr_op_nopout_test);
|
|
|
|
CU_ADD_TEST(suite, pdu_hdr_op_data_test);
|
2021-02-08 15:28:44 +00:00
|
|
|
CU_ADD_TEST(suite, empty_text_with_cbit_test);
|
2021-03-01 13:05:05 +00:00
|
|
|
CU_ADD_TEST(suite, pdu_payload_read_test);
|
2021-02-25 19:34:01 +00:00
|
|
|
CU_ADD_TEST(suite, data_out_pdu_sequence_test);
|
2021-09-29 05:16:50 +00:00
|
|
|
CU_ADD_TEST(suite, immediate_data_and_data_out_pdu_sequence_test);
|
2016-11-22 19:47:04 +00:00
|
|
|
|
|
|
|
CU_basic_set_mode(CU_BRM_VERBOSE);
|
|
|
|
CU_basic_run_tests();
|
|
|
|
num_failures = CU_get_number_of_failures();
|
|
|
|
CU_cleanup_registry();
|
|
|
|
return num_failures;
|
|
|
|
}
|