From e38f29772df596feb8cfbc6850da5b8d100c7e3c Mon Sep 17 00:00:00 2001 From: Eric Weber Date: Fri, 28 Apr 2023 11:14:00 -0500 Subject: [PATCH] Remove deprecated mkfs-ext4-parameters setting Signed-off-by: Eric Weber --- chart/questions.yaml | 5 ----- chart/templates/default-setting.yaml | 1 - chart/values.yaml | 1 - 3 files changed, 7 deletions(-) diff --git a/chart/questions.yaml b/chart/questions.yaml index e9fc8a4..b9ad3cf 100644 --- a/chart/questions.yaml +++ b/chart/questions.yaml @@ -459,11 +459,6 @@ If this setting is enabled, Longhorn will **not** block `kubectl drain` action o - "allow-if-replica-is-stopped" - "always-allow" default: "block-if-contains-last-replica" - - variable: defaultSettings.mkfsExt4Parameters - label: Custom mkfs.ext4 parameters - description: "Allows setting additional filesystem creation parameters for ext4. For older host kernels it might be necessary to disable the optional ext4 metadata_csum feature by specifying `-O ^64bit,^metadata_csum`." - group: "Longhorn Default Settings" - type: string - variable: defaultSettings.disableReplicaRebuild label: Disable Replica Rebuild description: "This setting disable replica rebuild cross the whole cluster, eviction and data locality feature won't work if this setting is true. But doesn't have any impact to any current replica rebuild and restore disaster recovery volume." diff --git a/chart/templates/default-setting.yaml b/chart/templates/default-setting.yaml index f65b7f1..0ef6458 100644 --- a/chart/templates/default-setting.yaml +++ b/chart/templates/default-setting.yaml @@ -53,7 +53,6 @@ data: {{ if not (kindIs "invalid" .Values.defaultSettings.nodeDownPodDeletionPolicy) }}node-down-pod-deletion-policy: {{ .Values.defaultSettings.nodeDownPodDeletionPolicy }}{{ end }} {{ if not (kindIs "invalid" .Values.defaultSettings.allowNodeDrainWithLastHealthyReplica) }}allow-node-drain-with-last-healthy-replica: {{ .Values.defaultSettings.allowNodeDrainWithLastHealthyReplica }}{{ end }} {{ if not (kindIs "invalid" .Values.defaultSettings.nodeDrainPolicy) }}node-drain-policy: {{ .Values.defaultSettings.nodeDrainPolicy }}{{ end }} - {{ if not (kindIs "invalid" .Values.defaultSettings.mkfsExt4Parameters) }}mkfs-ext4-parameters: {{ .Values.defaultSettings.mkfsExt4Parameters }}{{ end }} {{ if not (kindIs "invalid" .Values.defaultSettings.disableReplicaRebuild) }}disable-replica-rebuild: {{ .Values.defaultSettings.disableReplicaRebuild }}{{ end }} {{ if not (kindIs "invalid" .Values.defaultSettings.replicaReplenishmentWaitInterval) }}replica-replenishment-wait-interval: {{ .Values.defaultSettings.replicaReplenishmentWaitInterval }}{{ end }} {{ if not (kindIs "invalid" .Values.defaultSettings.concurrentReplicaRebuildPerNodeLimit) }}concurrent-replica-rebuild-per-node-limit: {{ .Values.defaultSettings.concurrentReplicaRebuildPerNodeLimit }}{{ end }} diff --git a/chart/values.yaml b/chart/values.yaml index 3941b45..e6894b5 100644 --- a/chart/values.yaml +++ b/chart/values.yaml @@ -134,7 +134,6 @@ defaultSettings: nodeDownPodDeletionPolicy: ~ allowNodeDrainWithLastHealthyReplica: ~ nodeDrainPolicy : ~ - mkfsExt4Parameters: ~ disableReplicaRebuild: ~ replicaReplenishmentWaitInterval: ~ concurrentReplicaRebuildPerNodeLimit: ~