ivampiresp/longhorn
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

enhancement: Add API Changes in the template

Browse Source 
Signed-off-by: Sheng Yang <sheng.yang@rancher.com>
This commit is contained in:
Sheng Yang 2020-03-31 16:43:20 -07:00 committed by Sheng Yang
parent 92bb35b2f3
commit c3bf0238ac
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
enhancements/20200331-replace-filesystem-id-key-in-disk-map.md
View File

@ -49,8 +49,6 @@ After the enhancement, when the users add more disks to the node, API gateway wi
1. If one of the disks already exists, the other disks will get condition `ready = false`, with the message indicating that they're pointing to the same filesystem as one of the existing disks. 1. If one of the disks already exists, the other disks will get condition `ready = false`, with the message indicating that they're pointing to the same filesystem as one of the existing disks.
1. If there is more than one disk exists and pointing to the same filesystem. Longhorn will identify which disk is the valid one using `diskUUID` and set the condition of other disks to `ready = false`. 1. If there is more than one disk exists and pointing to the same filesystem. Longhorn will identify which disk is the valid one using `diskUUID` and set the condition of other disks to `ready = false`.
## Design
### API changes ### API changes
1. API input for the diskUpdate call will be a map[string]DiskSpec instead of []DiskSpec. 1. API input for the diskUpdate call will be a map[string]DiskSpec instead of []DiskSpec.
1. API no longer validates duplicate filesystem ID. 1. API no longer validates duplicate filesystem ID.
@ -58,6 +56,8 @@ After the enhancement, when the users add more disks to the node, API gateway wi
### UI changes ### UI changes
UI can let the user customize the disk name. By default UI can generate name like `disk-<random>` for the disks. UI can let the user customize the disk name. By default UI can generate name like `disk-<random>` for the disks.
## Design
### Implementation Overview ### Implementation Overview
The validation of will be done in the node controller `syncDiskStatus`. The validation of will be done in the node controller `syncDiskStatus`.

2
enhancements/YYYYMMDD-template.md
View File

@ -40,6 +40,8 @@ The experience details should be in the `User Experience In Detail` later.
Detail what user need to do to use this enhancement. Include as much detail as possible so that people can understand the "how" of the system. The goal here is to make this feel real for users without getting bogged down. Detail what user need to do to use this enhancement. Include as much detail as possible so that people can understand the "how" of the system. The goal here is to make this feel real for users without getting bogged down.
### API changes
## Design ## Design
### Implementation Overview ### Implementation Overview