ivampiresp/longhorn
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update 20200319-default-disks-and-node-configuration.md

Browse Source 
Signed-off-by: Sheng Yang <sheng.yang@rancher.com>
This commit is contained in:
Sheng Yang 2020-03-20 10:03:41 -07:00 committed by GitHub
parent 4726f112b5
commit 0745f00b09
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
enhancements/20200319-default-disks-and-node-configuration.md
View File

@ -4,11 +4,11 @@
This enhancement allows the user to customize the default disks and node configurations in Longhorn for newly added nodes using Kubernetes label and annotation, instead of using Longhorn API or UI. This enhancement allows the user to customize the default disks and node configurations in Longhorn for newly added nodes using Kubernetes label and annotation, instead of using Longhorn API or UI.
### Related PR ### Related Issues
https://github.com/longhorn/longhorn-manager/pull/514 https://github.com/longhorn/longhorn/issues/1053
https://github.com/longhorn/longhorn-tests/pull/275 https://github.com/longhorn/longhorn/issues/991
## Motivation ## Motivation
@ -111,7 +111,9 @@ The process will be done as a part of the node controller reconciliation logic i
##### Notice ##### Notice
If one of the following conditions is satisfied, no partial configuration will be applied and the whole annotation will be discarded. Then no change will be done for the node tag/disks. If the label/annotations failed validation, no partial configuration will be applied and the whole annotation will be ignored. No change will be done for the node tag/disks.
The validation failure can be caused by:
1. The annotation format is invalid and cannot be parsed to tags/disks configuration. 1. The annotation format is invalid and cannot be parsed to tags/disks configuration.
2. The format is valid but there is an unqualified tag in the tag list. 2. The format is valid but there is an unqualified tag in the tag list.
3. The format is valid but there is an invalid disk parameter in the disk list. 3. The format is valid but there is an invalid disk parameter in the disk list.
@ -160,4 +162,4 @@ Now they will see that the node tags and disks are created correctly and match t
### Upgrade strategy ### Upgrade strategy
None. N/A.