822325ca28
idle.sh sometimes fails because the app_thread's idle time is less than busy time. For rpc "framework_set_scheduler dynamic" will initialize the dpdk_governor which finally call rte_power_init. This process is time consuming on some systems which may make app_thread busy. We can allow the app_thread to be busy for the first sample. This is one solution. It also works if we call sleep for some time after calling rpc framework_set_scheduler. Change-Id: Ia2f4b2f35e94657ce093ce261438ab710399435a Signed-off-by: Richael Zhuang <richael.zhuang@arm.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16825 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Michal Berger <michal.berger@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
69 lines
1.9 KiB
Bash
Executable File
69 lines
1.9 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# SPDX-License-Identifier: BSD-3-Clause
|
|
# Copyright (C) 2020 Intel Corporation
|
|
# All rights reserved.
|
|
#
|
|
|
|
testdir=$(readlink -f "$(dirname "$0")")
|
|
rootdir=$(readlink -f "$testdir/../../")
|
|
|
|
source "$rootdir/test/common/autotest_common.sh"
|
|
source "$testdir/common.sh"
|
|
|
|
trap 'killprocess "$spdk_pid"' EXIT
|
|
|
|
thread_stats() {
|
|
local thread
|
|
busy_threads=0
|
|
|
|
get_thread_stats
|
|
|
|
# Simply verify if threads stay idle
|
|
for thread in "${!thread_map[@]}"; do
|
|
if ((idle[thread] < busy[thread])); then
|
|
printf 'Waiting for %s to become idle\n' "${thread_map[thread]}"
|
|
((++busy_threads))
|
|
elif ((idle[thread] > busy[thread])); then
|
|
printf '%s is idle\n' "${thread_map[thread]}"
|
|
fi
|
|
done
|
|
}
|
|
|
|
idle() {
|
|
local reactor_framework
|
|
local reactors thread
|
|
local thread_cpumask
|
|
local threads
|
|
|
|
exec_under_dynamic_scheduler "${SPDK_APP[@]}" -m "$spdk_cpumask" --main-core "$spdk_main_core"
|
|
|
|
# The expectation here is that when SPDK app is idle the following is true:
|
|
# - all threads are assigned to main lcore
|
|
# - threads are not being moved between lcores
|
|
|
|
xtrace_disable
|
|
while ((samples++ < 5)); do
|
|
cpumask=0
|
|
reactor_framework=$(rpc_cmd framework_get_reactors | jq -r '.reactors[]')
|
|
threads=($(
|
|
jq -r "select(.lcore == $spdk_main_core) | .lw_threads[].name" <<< "$reactor_framework"
|
|
))
|
|
|
|
for thread in "${threads[@]}"; do
|
|
thread_cpumask=0x$(jq -r "select(.lcore == $spdk_main_core) | .lw_threads[] | select(.name == \"$thread\") | .cpumask" <<< "$reactor_framework")
|
|
printf 'SPDK cpumask: %s Thread %s cpumask: %s\n' "$spdk_cpumask" "$thread" "$thread_cpumask"
|
|
done
|
|
|
|
thread_stats
|
|
|
|
# Allow app_thread is busy for the first sample. Because on some system the dpdk_governor
|
|
# initiation process on app_thread is time consuming. This may make the busy time greater
|
|
# than idle time which causes the test to fail.
|
|
((samples == 1 && busy_threads <= 1 || samples > 1 && busy_threads == 0))
|
|
done
|
|
|
|
xtrace_restore
|
|
}
|
|
|
|
idle
|