Spdk/include/spdk_internal/accel_module.h
Konrad Sztyber 3fbe74fd82 accel: don't modify user iovs when allocating buffers
It is quite common for a user to use the exact same iovec (in memory) to
describe buffers for two different operations.  If that iovec was
describing accel buffer, accel would modify it replacing it with an
actual buffer.  This is broken if that iovec was used by some other task
in a sequence, as accel wouldn't be aware that it has been changed too.

To address this, accel will use a new iovec from the aux_iovs array.  It
means that accel buffers always *must* be passed using a single iovec.
Theoretically, users could chunk that buffer into several iovecs, but
spdk_accel_get_buf() always returns a single buffer, so, in practice,
this should never happen, and therefore is unsupported.

Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com>
Change-Id: I25271bc032987dd6028fb7b3adde061657759b4b
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17039
Community-CI: Mellanox Build Bot
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
2023-03-13 21:02:27 +00:00

260 lines
8.0 KiB
C

/* SPDX-License-Identifier: BSD-3-Clause
* Copyright (C) 2020 Intel Corporation.
* Copyright (c) 2022 NVIDIA CORPORATION & AFFILIATES
* All rights reserved.
*/
#ifndef SPDK_ACCEL_MODULE_H
#define SPDK_ACCEL_MODULE_H
#include "spdk/stdinc.h"
#include "spdk/accel.h"
#include "spdk/queue.h"
#include "spdk/config.h"
struct spdk_accel_module_if;
struct spdk_accel_task;
void spdk_accel_task_complete(struct spdk_accel_task *task, int status);
/** Some reasonable key length used with strnlen() */
#define SPDK_ACCEL_CRYPTO_KEY_MAX_HEX_LENGTH (256 + 1)
struct spdk_accel_crypto_key {
void *priv; /**< Module private data */
char *key; /**< Key in binary form */
size_t key_size; /**< Key size in bytes */
char *key2; /**< Key2 in binary form */
size_t key2_size; /**< Key2 size in bytes */
struct spdk_accel_module_if *module_if; /**< Accel module the key belongs to */
struct spdk_accel_crypto_key_create_param param; /**< User input parameters */
TAILQ_ENTRY(spdk_accel_crypto_key) link;
};
/**
* Describes user's buffers in remote memory domains in case a module doesn't support memory domains
* and accel needs to pull/push the data before submitting a task. Should only be used by accel
* itself and should not be touched by accel modules.
*/
struct spdk_accel_bounce_buffer {
struct iovec *orig_iovs;
uint32_t orig_iovcnt;
struct spdk_memory_domain *orig_domain;
void *orig_domain_ctx;
struct iovec iov;
};
enum spdk_accel_aux_iov_type {
SPDK_ACCEL_AUX_IOV_SRC,
SPDK_ACCEL_AUX_IOV_DST,
SPDK_ACCEL_AUX_IOV_SRC2,
SPDK_ACCEL_AUX_IOV_DST2,
SPDK_ACCEL_AXU_IOV_VIRT_SRC,
SPDK_ACCEL_AXU_IOV_VIRT_DST,
SPDK_ACCEL_AUX_IOV_MAX,
};
struct spdk_accel_task {
struct accel_io_channel *accel_ch;
spdk_accel_completion_cb cb_fn;
void *cb_arg;
spdk_accel_step_cb step_cb_fn;
void *step_cb_arg;
struct spdk_memory_domain *src_domain;
void *src_domain_ctx;
struct spdk_memory_domain *dst_domain;
void *dst_domain_ctx;
union {
struct {
struct iovec *iovs; /* iovs passed by the caller */
uint32_t iovcnt; /* iovcnt passed by the caller */
} s;
struct {
void **srcs;
uint32_t cnt;
} nsrcs;
};
union {
struct {
struct iovec *iovs; /* iovs passed by the caller */
uint32_t iovcnt; /* iovcnt passed by the caller */
} d;
struct {
struct iovec *iovs;
uint32_t iovcnt;
} s2;
};
union {
struct {
struct iovec *iovs;
uint32_t iovcnt;
} d2;
uint32_t seed;
uint64_t fill_pattern;
struct spdk_accel_crypto_key *crypto_key;
};
union {
uint32_t *crc_dst;
uint32_t *output_size;
uint32_t block_size; /* for crypto op */
};
struct {
struct spdk_accel_bounce_buffer s;
struct spdk_accel_bounce_buffer d;
} bounce;
enum accel_opcode op_code;
uint64_t iv; /* Initialization vector (tweak) for crypto op */
int flags;
int status;
struct iovec aux_iovs[SPDK_ACCEL_AUX_IOV_MAX];
TAILQ_ENTRY(spdk_accel_task) link;
TAILQ_ENTRY(spdk_accel_task) seq_link;
};
struct spdk_accel_module_if {
/** Initialization function for the module. Called by the spdk
* application during startup.
*
* Modules are required to define this function.
*/
int (*module_init)(void);
/** Finish function for the module. Called by the spdk application
* before the spdk application exits to perform any necessary cleanup.
*
* Modules are not required to define this function.
*/
void (*module_fini)(void *ctx);
/**
* Write Acceleration module configuration into provided JSON context.
*/
void (*write_config_json)(struct spdk_json_write_ctx *w);
/**
* Returns the allocation size required for the modules to use for context.
*/
size_t (*get_ctx_size)(void);
const char *name;
bool (*supports_opcode)(enum accel_opcode);
struct spdk_io_channel *(*get_io_channel)(void);
int (*submit_tasks)(struct spdk_io_channel *ch, struct spdk_accel_task *accel_task);
/**
* Create crypto key function. Module is responsible to fill all necessary parameters in
* \b spdk_accel_crypto_key structure
*/
int (*crypto_key_init)(struct spdk_accel_crypto_key *key);
void (*crypto_key_deinit)(struct spdk_accel_crypto_key *key);
/**
* Returns memory domains supported by the module. If NULL, the module does not support
* memory domains. The `domains` array can be NULL, in which case this function only
* returns the number of supported memory domains.
*
* \param domains Memory domain array.
* \param num_domains Size of the `domains` array.
*
* \return Number of supported memory domains.
*/
int (*get_memory_domains)(struct spdk_memory_domain **domains, int num_domains);
TAILQ_ENTRY(spdk_accel_module_if) tailq;
};
void spdk_accel_module_list_add(struct spdk_accel_module_if *accel_module);
#define SPDK_ACCEL_MODULE_REGISTER(name, module) \
static void __attribute__((constructor)) _spdk_accel_module_register_##name(void) \
{ \
spdk_accel_module_list_add(module); \
}
/**
* Called by an accel module when cleanup initiated during .module_fini has completed
*/
void spdk_accel_module_finish(void);
/**
* Platform driver responsible for executing tasks in a sequence. If no driver is selected, tasks
* are submitted to accel modules. All drivers are required to be aware of memory domains.
*/
struct spdk_accel_driver {
/** Name of the driver */
const char *name;
/**
* Executes a sequence of accel operations. The driver should notify accel about each
* completed task using `spdk_accel_task_complete()`. Once all tasks are completed or the
* driver cannot proceed with a given task (e.g. because it doesn't handle specific opcode),
* accel should be notified via `spdk_accel_sequence_continue()`. If there are tasks left
* in a sequence, the first will be submitted to a module, while the rest will be sent back
* to the driver. `spdk_accel_sequence_continue()` should only be called if this function
* succeeds (i.e. returns 0).
*
* \param Sequence of tasks to execute.
*
* \return 0 on success, negative errno on failure.
*/
int (*execute_sequence)(struct spdk_accel_sequence *seq);
TAILQ_ENTRY(spdk_accel_driver) tailq;
};
/**
* Notifies accel that a driver has finished executing a sequence (or its part) and accel should
* continue processing it.
*
* \param seq Sequence object.
*/
void spdk_accel_sequence_continue(struct spdk_accel_sequence *seq);
void spdk_accel_driver_register(struct spdk_accel_driver *driver);
#define SPDK_ACCEL_DRIVER_REGISTER(name, driver) \
static void __attribute__((constructor)) _spdk_accel_driver_register_##name(void) \
{ \
spdk_accel_driver_register(driver); \
}
typedef void (*spdk_accel_sequence_get_buf_cb)(struct spdk_accel_sequence *seq, void *cb_arg);
/**
* Allocates memory for an accel buffer in a given sequence. The callback is only executed if the
* buffer couldn't be allocated immediately.
*
* \param seq Sequence object.
* \param buf Accel buffer to allocate.
* \param domain Accel memory domain.
* \param domain_ctx Memory domain context.
* \param cb_fn Callback to be executed once the buffer is allocated.
* \param cb_ctx Argument to be passed to `cb_fn`.
*
* \return true if the buffer was immediately allocated, false otherwise.
*/
bool spdk_accel_alloc_sequence_buf(struct spdk_accel_sequence *seq, void *buf,
struct spdk_memory_domain *domain, void *domain_ctx,
spdk_accel_sequence_get_buf_cb cb_fn, void *cb_ctx);
/**
* Returns the first task remaining to be executed in a given sequence.
*
* \param seq Sequence object.
*
* \return the first remaining task or NULL if all tasks are already completed.
*/
struct spdk_accel_task *spdk_accel_sequence_first_task(struct spdk_accel_sequence *seq);
/**
* Returns the next remaining task that follows a given task in a sequence.
*
* \param task Accel task. This task must be still oustanding (i.e. it wasn't completed through
* `spdk_accel_task_complete()`).
*
* \return the next task or NULL if `task` was the last task in a sequence.
*/
struct spdk_accel_task *spdk_accel_sequence_next_task(struct spdk_accel_task *task);
#endif