Recently, checked the spdk_io_device_unregister function, it will have deferred free behaviour, and the io_device will possibly be freed in put_io_channel function. And this means that it is not safe to directly call: spdk_io_device_unregister (io_device, NULL); Then free io_device relately resource. Because there will be channel to use the resources associated with io_device. Then we will possibly cause a NULL pointer access. I found this issue in bdev rbd module, and I think that the same issue could happen in other modules. So it is better to put the resource free function as the call back function. Change-Id: Icc1f86d72b672faefb3b7f416030b818a8cf45ce Signed-off-by: Ziye Yang <ziye.yang@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7646 Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> |
||
---|---|---|
.. | ||
accel | ||
bdev | ||
blob | ||
blobfs | ||
env_dpdk | ||
event | ||
sock | ||
Makefile |