3faf457f56
We cannot rely on DSM/DEALLOCATE as a write zeroes alternative, even if DLFEAT reports that deallocated blocks will be read as all zeroes. DEALLOCATE is advisory, meaning that blocks may not actually be deallocated. In cases where they are not deallocated, they will not be read back later as zeroes. QEMU 6.0 started reporting DLFEAT as returning zeroes for deallocated blocks but for some of our write zeroes tests, blocks aren't actually deallocated. We may be able to add quirks in the future if we know that a controller reliably deallocates blocks, but for now we need to revert this completely. Note that since bdev/nvme module now does not support write zeroes in any cases, we need to disable the write zeroes call in the unit tests. Fixes issue #1932. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I79f0673774b621a9ffcc46891728cc7719e34cdb Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7723 Community-CI: Broadcom CI Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> |
||
|---|---|---|
| .. | ||
| bdev_nvme_cuse_rpc.c | ||
| bdev_nvme_rpc.c | ||
| bdev_nvme.c | ||
| bdev_nvme.h | ||
| bdev_ocssd_rpc.c | ||
| bdev_ocssd.c | ||
| bdev_ocssd.h | ||
| common.c | ||
| common.h | ||
| Makefile | ||
| nvme_rpc.c | ||
| vbdev_opal_rpc.c | ||
| vbdev_opal.c | ||
| vbdev_opal.h | ||