In SPDK, declarations have the return type on the same line. Definitions have the return type on a separate line. Astyle has an option for enforcing this. Unfortunately, it seems to have two bugs: 1) It doesn't work correctly at all on C++ files. 2) It often fails on functions that return enums, or long type names Deal with 1) by adjusting the check_format.sh script to only tell astyle to fix return type line breaks for C files and not C++. Deal with 2) by adding a few typedefs to work around the problem. Change-Id: Idf28281466cab8411ce252d5f02ab384166790c6 Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13437 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Dong Yi <dongx.yi@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
80 lines
2.2 KiB
C
80 lines
2.2 KiB
C
/* SPDX-License-Identifier: BSD-3-Clause
|
|
* Copyright (c) Intel Corporation.
|
|
* All rights reserved.
|
|
*/
|
|
|
|
#include "spdk/stdinc.h"
|
|
|
|
#include "spdk_cunit.h"
|
|
#include "spdk/log.h"
|
|
|
|
#include "log/log.c"
|
|
#include "log/log_flags.c"
|
|
|
|
static void
|
|
log_test(void)
|
|
{
|
|
spdk_log_set_level(SPDK_LOG_ERROR);
|
|
CU_ASSERT_EQUAL(spdk_log_get_level(), SPDK_LOG_ERROR);
|
|
spdk_log_set_level(SPDK_LOG_WARN);
|
|
CU_ASSERT_EQUAL(spdk_log_get_level(), SPDK_LOG_WARN);
|
|
spdk_log_set_level(SPDK_LOG_NOTICE);
|
|
CU_ASSERT_EQUAL(spdk_log_get_level(), SPDK_LOG_NOTICE);
|
|
spdk_log_set_level(SPDK_LOG_INFO);
|
|
CU_ASSERT_EQUAL(spdk_log_get_level(), SPDK_LOG_INFO);
|
|
spdk_log_set_level(SPDK_LOG_DEBUG);
|
|
CU_ASSERT_EQUAL(spdk_log_get_level(), SPDK_LOG_DEBUG);
|
|
|
|
spdk_log_set_print_level(SPDK_LOG_ERROR);
|
|
CU_ASSERT_EQUAL(spdk_log_get_print_level(), SPDK_LOG_ERROR);
|
|
spdk_log_set_print_level(SPDK_LOG_WARN);
|
|
CU_ASSERT_EQUAL(spdk_log_get_print_level(), SPDK_LOG_WARN);
|
|
spdk_log_set_print_level(SPDK_LOG_NOTICE);
|
|
CU_ASSERT_EQUAL(spdk_log_get_print_level(), SPDK_LOG_NOTICE);
|
|
spdk_log_set_print_level(SPDK_LOG_INFO);
|
|
CU_ASSERT_EQUAL(spdk_log_get_print_level(), SPDK_LOG_INFO);
|
|
spdk_log_set_print_level(SPDK_LOG_DEBUG);
|
|
CU_ASSERT_EQUAL(spdk_log_get_print_level(), SPDK_LOG_DEBUG);
|
|
|
|
#ifdef DEBUG
|
|
CU_ASSERT(spdk_log_get_flag("LOG") == false);
|
|
|
|
spdk_log_set_flag("log");
|
|
CU_ASSERT(spdk_log_get_flag("LOG") == true);
|
|
|
|
spdk_log_clear_flag("LOG");
|
|
CU_ASSERT(spdk_log_get_flag("LOG") == false);
|
|
#endif
|
|
|
|
spdk_log_open(NULL);
|
|
spdk_log_set_flag("log");
|
|
SPDK_WARNLOG("log warning unit test\n");
|
|
SPDK_DEBUGLOG(log, "log test\n");
|
|
SPDK_LOGDUMP(log, "log dump test:", "log dump", 8);
|
|
spdk_log_dump(stderr, "spdk dump test:", "spdk dump", 9);
|
|
/* Test spdk_log_dump with more than 16 chars and less than 32 chars */
|
|
spdk_log_dump(stderr, "spdk dump test:", "spdk dump 16 more chars", 23);
|
|
|
|
spdk_log_close();
|
|
}
|
|
|
|
int
|
|
main(int argc, char **argv)
|
|
{
|
|
CU_pSuite suite = NULL;
|
|
unsigned int num_failures;
|
|
|
|
CU_set_error_action(CUEA_ABORT);
|
|
CU_initialize_registry();
|
|
|
|
suite = CU_add_suite("log", NULL, NULL);
|
|
|
|
CU_ADD_TEST(suite, log_test);
|
|
|
|
CU_basic_set_mode(CU_BRM_VERBOSE);
|
|
CU_basic_run_tests();
|
|
num_failures = CU_get_number_of_failures();
|
|
CU_cleanup_registry();
|
|
return num_failures;
|
|
}
|