Before this change, a negative `--shm-id` value is rejected by `spdk_app_parse_args()` and this function simply errors out after detecting it. However, `build_eal_cmdline()` has a dedicated branch checking for a negative `opts->shm_id` and passes `--no-shconf` down to DPDK as a parameter, so we cannot disable the shared config support in DPDK. After this change, a negative value `--shm-id` is accepted, but if it cannot be parsed as an integer, `spdk_app_parse_args()` errors out as before. In result we can disable shared config support in DPDK by passing `--shm-id=-1` to SPDK application. Signed-off-by: Kefu Chai <tchaikov@gmail.com> Change-Id: Ibe089f13638eefa9ac28c5c99e303bcc3102f307 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/14097 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> |
||
---|---|---|
.. | ||
app_rpc.c | ||
app.c | ||
log_rpc.c | ||
Makefile | ||
reactor.c | ||
scheduler_static.c | ||
spdk_event.map |