6146c67856
Bdevperf tool had not called spdk_poller_unregister() called on the same thread that called spdk_poller_register(). But it had not caused any issue because spdk_poller_unregister() simply set the state to unregistered. This design flaw has been fixed recently. However the new pause feature has been added to poller and this design flaw might cause any unexpected behavior if paused poller is unregistered. We do not know any other case such that spdk_poller_unregister() is not called on the same thread that called spdk_poller_register(), but we have no way to know it even if it exists. Hence let's add assert for such cases. Parsing poller lists managed by thread may be another option but spdk_poller_unregister() is performance critical. So we do not check list. Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I9d91daaeb81fa33d5f042dbe7ddbd8ab6ea98d55 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/479391 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Alexey Marchuk <alexeymar@mellanox.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> |
||
|---|---|---|
| .. | ||
| Makefile | ||
| thread.c | ||