Write pm filepath first to offset 4K. Then write the super block to offset 0. This ensures the backing device isn't really valid until both are written (avoiding the case where the super block got written but not the path.) Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I55508aa67b4179e658827c982cd955d009a3f321 Reviewed-on: https://review.gerrithub.io/432505 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: <spdk-ci.pdl@broadcom.com>
437 lines
13 KiB
C
437 lines
13 KiB
C
/*-
|
|
* BSD LICENSE
|
|
*
|
|
* Copyright (c) Intel Corporation.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
*
|
|
* * Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in
|
|
* the documentation and/or other materials provided with the
|
|
* distribution.
|
|
* * Neither the name of Intel Corporation nor the names of its
|
|
* contributors may be used to endorse or promote products derived
|
|
* from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include "spdk/stdinc.h"
|
|
|
|
#include "spdk_cunit.h"
|
|
|
|
#include "reduce/reduce.c"
|
|
#include "spdk_internal/mock.h"
|
|
#include "common/lib/test_env.c"
|
|
|
|
static struct spdk_reduce_vol *g_vol;
|
|
static int g_ziperrno;
|
|
static char *g_volatile_pm_buf;
|
|
static char *g_persistent_pm_buf;
|
|
static bool g_backing_dev_closed;
|
|
static char *g_backing_dev_buf;
|
|
|
|
#define TEST_MD_PATH "/tmp/meta.data"
|
|
|
|
static void
|
|
sync_pm_buf(const void *addr, size_t length)
|
|
{
|
|
uint64_t offset = (char *)addr - g_volatile_pm_buf;
|
|
|
|
memcpy(&g_persistent_pm_buf[offset], addr, length);
|
|
}
|
|
|
|
int
|
|
pmem_msync(const void *addr, size_t length)
|
|
{
|
|
sync_pm_buf(addr, length);
|
|
return 0;
|
|
}
|
|
|
|
void
|
|
pmem_persist(const void *addr, size_t len)
|
|
{
|
|
sync_pm_buf(addr, len);
|
|
}
|
|
|
|
static void
|
|
get_pm_file_size(void)
|
|
{
|
|
struct spdk_reduce_vol_params params;
|
|
int64_t pm_size, expected_pm_size;
|
|
|
|
params.vol_size = 0;
|
|
params.chunk_size = 0;
|
|
params.backing_io_unit_size = 0;
|
|
CU_ASSERT(spdk_reduce_get_pm_file_size(¶ms) == -EINVAL);
|
|
|
|
/*
|
|
* Select a valid backing_io_unit_size. This should still fail since
|
|
* vol_size and chunk_size are still 0.
|
|
*/
|
|
params.backing_io_unit_size = 4096;
|
|
CU_ASSERT(spdk_reduce_get_pm_file_size(¶ms) == -EINVAL);
|
|
|
|
/*
|
|
* Select a valid chunk_size. This should still fail since val_size
|
|
* is still 0.
|
|
*/
|
|
params.chunk_size = 4096 * 4;
|
|
CU_ASSERT(spdk_reduce_get_pm_file_size(¶ms) == -EINVAL);
|
|
|
|
/* Select a valid vol_size. This should return a proper pm_size. */
|
|
params.vol_size = 4096 * 4 * 100;
|
|
pm_size = spdk_reduce_get_pm_file_size(¶ms);
|
|
expected_pm_size = sizeof(struct spdk_reduce_vol_superblock);
|
|
/* 100 chunks in logical map * 8 bytes per chunk */
|
|
expected_pm_size += 100 * sizeof(uint64_t);
|
|
/* 100 chunks * 4 backing io units per chunk * 8 bytes per backing io unit */
|
|
expected_pm_size += 100 * 4 * sizeof(uint64_t);
|
|
/* reduce allocates some extra chunks too for in-flight writes when logical map
|
|
* is full. REDUCE_EXTRA_CHUNKS is a private #ifdef in reduce.c.
|
|
*/
|
|
expected_pm_size += REDUCE_NUM_EXTRA_CHUNKS * 4 * sizeof(uint64_t);
|
|
/* reduce will add some padding so numbers may not match exactly. Make sure
|
|
* they are close though.
|
|
*/
|
|
CU_ASSERT((pm_size - expected_pm_size) < REDUCE_PM_SIZE_ALIGNMENT);
|
|
}
|
|
|
|
static void
|
|
get_backing_device_size(void)
|
|
{
|
|
struct spdk_reduce_vol_params params;
|
|
int64_t backing_size, expected_backing_size;
|
|
|
|
params.vol_size = 0;
|
|
params.chunk_size = 0;
|
|
params.backing_io_unit_size = 0;
|
|
CU_ASSERT(spdk_reduce_get_backing_device_size(¶ms) == -EINVAL);
|
|
|
|
/*
|
|
* Select a valid backing_io_unit_size. This should still fail since
|
|
* vol_size and chunk_size are still 0.
|
|
*/
|
|
params.backing_io_unit_size = 4096;
|
|
CU_ASSERT(spdk_reduce_get_backing_device_size(¶ms) == -EINVAL);
|
|
|
|
/*
|
|
* Select a valid chunk_size. This should still fail since val_size
|
|
* is still 0.
|
|
*/
|
|
params.chunk_size = 4096 * 4;
|
|
CU_ASSERT(spdk_reduce_get_backing_device_size(¶ms) == -EINVAL);
|
|
|
|
/* Select a valid vol_size. This should return a proper backing device size. */
|
|
params.vol_size = 4096 * 4 * 100;
|
|
backing_size = spdk_reduce_get_backing_device_size(¶ms);
|
|
expected_backing_size = params.vol_size;
|
|
/* reduce allocates some extra chunks too for in-flight writes when logical map
|
|
* is full. REDUCE_EXTRA_CHUNKS is a private #ifdef in reduce.c. Backing device
|
|
* must have space allocated for these extra chunks.
|
|
*/
|
|
expected_backing_size += REDUCE_NUM_EXTRA_CHUNKS * params.chunk_size;
|
|
/* Account for superblock as well. */
|
|
expected_backing_size += sizeof(struct spdk_reduce_vol_superblock);
|
|
CU_ASSERT(backing_size == expected_backing_size);
|
|
}
|
|
|
|
static void
|
|
pm_file_close(struct spdk_reduce_pm_file *pm_file)
|
|
{
|
|
free(g_volatile_pm_buf);
|
|
g_volatile_pm_buf = NULL;
|
|
}
|
|
|
|
static void
|
|
pm_file_destroy(void)
|
|
{
|
|
CU_ASSERT(g_persistent_pm_buf != NULL);
|
|
free(g_persistent_pm_buf);
|
|
g_persistent_pm_buf = NULL;
|
|
}
|
|
|
|
static int
|
|
pm_file_init(struct spdk_reduce_pm_file *pm_file, struct spdk_reduce_vol_params *params)
|
|
{
|
|
pm_file->size = spdk_reduce_get_pm_file_size(params);
|
|
|
|
CU_ASSERT(g_persistent_pm_buf == NULL);
|
|
g_persistent_pm_buf = calloc(1, pm_file->size);
|
|
SPDK_CU_ASSERT_FATAL(g_persistent_pm_buf != NULL);
|
|
|
|
CU_ASSERT(g_volatile_pm_buf == NULL);
|
|
g_volatile_pm_buf = calloc(1, pm_file->size);
|
|
SPDK_CU_ASSERT_FATAL(g_volatile_pm_buf != NULL);
|
|
|
|
memcpy(pm_file->path, TEST_MD_PATH, strlen(TEST_MD_PATH));
|
|
pm_file->path[strlen(TEST_MD_PATH)] = '\0';
|
|
|
|
pm_file->pm_buf = g_volatile_pm_buf;
|
|
pm_file->close = pm_file_close;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void
|
|
init_cb(void *cb_arg, struct spdk_reduce_vol *vol, int ziperrno)
|
|
{
|
|
g_vol = vol;
|
|
g_ziperrno = ziperrno;
|
|
}
|
|
|
|
static void
|
|
unload_cb(void *cb_arg, int ziperrno)
|
|
{
|
|
g_ziperrno = ziperrno;
|
|
}
|
|
|
|
static void
|
|
init_failure(void)
|
|
{
|
|
struct spdk_reduce_vol_params params = {};
|
|
struct spdk_reduce_backing_dev backing_dev = {};
|
|
struct spdk_reduce_pm_file pm_file = {};
|
|
|
|
backing_dev.blocklen = 512;
|
|
|
|
params.vol_size = 1024 * 1024; /* 1MB */
|
|
params.chunk_size = 16 * 1024;
|
|
params.backing_io_unit_size = backing_dev.blocklen;
|
|
|
|
/* backing_dev and pm_file have an invalid size. This should fail. */
|
|
g_vol = NULL;
|
|
g_ziperrno = 0;
|
|
spdk_reduce_vol_init(¶ms, &backing_dev, &pm_file, init_cb, NULL);
|
|
CU_ASSERT(g_ziperrno == -EINVAL);
|
|
SPDK_CU_ASSERT_FATAL(g_vol == NULL);
|
|
|
|
/* backing_dev now has valid size, but pm_file is still invalid.
|
|
* This should fail.
|
|
*/
|
|
backing_dev.blockcnt = spdk_reduce_get_backing_device_size(¶ms) / backing_dev.blocklen;
|
|
|
|
g_vol = NULL;
|
|
g_ziperrno = 0;
|
|
spdk_reduce_vol_init(¶ms, &backing_dev, &pm_file, init_cb, NULL);
|
|
CU_ASSERT(g_ziperrno == -EINVAL);
|
|
SPDK_CU_ASSERT_FATAL(g_vol == NULL);
|
|
|
|
/* pm_file now has valid size, but uuid is still all zeroes.
|
|
* This should fail.
|
|
*/
|
|
pm_file_init(&pm_file, ¶ms);
|
|
|
|
g_vol = NULL;
|
|
g_ziperrno = 0;
|
|
spdk_reduce_vol_init(¶ms, &backing_dev, &pm_file, init_cb, NULL);
|
|
CU_ASSERT(g_ziperrno == -EINVAL);
|
|
SPDK_CU_ASSERT_FATAL(g_vol == NULL);
|
|
|
|
pm_file_close(&pm_file);
|
|
pm_file_destroy();
|
|
}
|
|
|
|
static void
|
|
backing_dev_readv(struct spdk_reduce_backing_dev *backing_dev, struct iovec *iov, int iovcnt,
|
|
uint64_t lba, uint32_t lba_count, struct spdk_reduce_vol_cb_args *args)
|
|
{
|
|
char *offset;
|
|
int i;
|
|
|
|
offset = g_backing_dev_buf + lba * backing_dev->blocklen;
|
|
for (i = 0; i < iovcnt; i++) {
|
|
memcpy(iov[i].iov_base, offset, iov[i].iov_len);
|
|
offset += iov[i].iov_len;
|
|
}
|
|
args->cb_fn(args->cb_arg, 0);
|
|
}
|
|
|
|
static void
|
|
backing_dev_writev(struct spdk_reduce_backing_dev *backing_dev, struct iovec *iov, int iovcnt,
|
|
uint64_t lba, uint32_t lba_count, struct spdk_reduce_vol_cb_args *args)
|
|
{
|
|
char *offset;
|
|
int i;
|
|
|
|
offset = g_backing_dev_buf + lba * backing_dev->blocklen;
|
|
for (i = 0; i < iovcnt; i++) {
|
|
memcpy(offset, iov[i].iov_base, iov[i].iov_len);
|
|
offset += iov[i].iov_len;
|
|
}
|
|
args->cb_fn(args->cb_arg, 0);
|
|
}
|
|
|
|
static void
|
|
backing_dev_unmap(struct spdk_reduce_backing_dev *backing_dev,
|
|
uint64_t lba, uint32_t lba_count, struct spdk_reduce_vol_cb_args *args)
|
|
{
|
|
char *offset;
|
|
|
|
offset = g_backing_dev_buf + lba * backing_dev->blocklen;
|
|
memset(offset, 0, lba_count * backing_dev->blocklen);
|
|
args->cb_fn(args->cb_arg, 0);
|
|
}
|
|
|
|
static void
|
|
backing_dev_close(struct spdk_reduce_backing_dev *backing_dev)
|
|
{
|
|
g_backing_dev_closed = true;
|
|
}
|
|
|
|
static void
|
|
backing_dev_destroy(struct spdk_reduce_backing_dev *backing_dev)
|
|
{
|
|
/* We don't free this during backing_dev_close so that we can test init/unload/load
|
|
* scenarios.
|
|
*/
|
|
free(g_backing_dev_buf);
|
|
g_backing_dev_buf = NULL;
|
|
}
|
|
|
|
static void
|
|
backing_dev_init(struct spdk_reduce_backing_dev *backing_dev, struct spdk_reduce_vol_params *params)
|
|
{
|
|
int64_t size;
|
|
|
|
size = spdk_reduce_get_backing_device_size(params);
|
|
backing_dev->blocklen = params->backing_io_unit_size;
|
|
backing_dev->blockcnt = size / backing_dev->blocklen;
|
|
backing_dev->readv = backing_dev_readv;
|
|
backing_dev->writev = backing_dev_writev;
|
|
backing_dev->unmap = backing_dev_unmap;
|
|
backing_dev->close = backing_dev_close;
|
|
|
|
g_backing_dev_buf = calloc(1, size);
|
|
SPDK_CU_ASSERT_FATAL(g_backing_dev_buf != NULL);
|
|
}
|
|
|
|
static void
|
|
init_md(void)
|
|
{
|
|
struct spdk_reduce_vol_params params = {};
|
|
struct spdk_reduce_vol_params *persistent_params;
|
|
struct spdk_reduce_backing_dev backing_dev = {};
|
|
struct spdk_reduce_pm_file pm_file = {};
|
|
|
|
params.vol_size = 1024 * 1024; /* 1MB */
|
|
params.chunk_size = 16 * 1024;
|
|
params.backing_io_unit_size = 512;
|
|
spdk_uuid_generate(¶ms.uuid);
|
|
|
|
backing_dev_init(&backing_dev, ¶ms);
|
|
pm_file_init(&pm_file, ¶ms);
|
|
|
|
g_vol = NULL;
|
|
g_ziperrno = -1;
|
|
spdk_reduce_vol_init(¶ms, &backing_dev, &pm_file, init_cb, NULL);
|
|
CU_ASSERT(g_ziperrno == 0);
|
|
SPDK_CU_ASSERT_FATAL(g_vol != NULL);
|
|
/* Confirm that reduce persisted the params to metadata. */
|
|
CU_ASSERT(memcmp(g_persistent_pm_buf, SPDK_REDUCE_SIGNATURE, 8) == 0);
|
|
persistent_params = (struct spdk_reduce_vol_params *)(g_persistent_pm_buf + 8);
|
|
CU_ASSERT(memcmp(persistent_params, ¶ms, sizeof(params)) == 0);
|
|
|
|
g_ziperrno = -1;
|
|
g_backing_dev_closed = false;
|
|
spdk_reduce_vol_unload(g_vol, unload_cb, NULL);
|
|
CU_ASSERT(g_ziperrno == 0);
|
|
CU_ASSERT(g_backing_dev_closed == true);
|
|
CU_ASSERT(g_volatile_pm_buf == NULL);
|
|
|
|
pm_file_destroy();
|
|
backing_dev_destroy(&backing_dev);
|
|
}
|
|
|
|
static void
|
|
init_backing_dev(void)
|
|
{
|
|
struct spdk_reduce_vol_params params = {};
|
|
struct spdk_reduce_vol_params *persistent_params;
|
|
struct spdk_reduce_backing_dev backing_dev = {};
|
|
struct spdk_reduce_pm_file pm_file = {};
|
|
|
|
params.vol_size = 1024 * 1024; /* 1MB */
|
|
params.chunk_size = 16 * 1024;
|
|
params.backing_io_unit_size = 512;
|
|
spdk_uuid_generate(¶ms.uuid);
|
|
|
|
backing_dev_init(&backing_dev, ¶ms);
|
|
pm_file_init(&pm_file, ¶ms);
|
|
|
|
g_vol = NULL;
|
|
g_ziperrno = -1;
|
|
spdk_reduce_vol_init(¶ms, &backing_dev, &pm_file, init_cb, NULL);
|
|
CU_ASSERT(g_ziperrno == 0);
|
|
SPDK_CU_ASSERT_FATAL(g_vol != NULL);
|
|
/* Confirm that libreduce persisted the params to the backing device. */
|
|
CU_ASSERT(memcmp(g_backing_dev_buf, SPDK_REDUCE_SIGNATURE, 8) == 0);
|
|
persistent_params = (struct spdk_reduce_vol_params *)(g_backing_dev_buf + 8);
|
|
CU_ASSERT(memcmp(persistent_params, ¶ms, sizeof(params)) == 0);
|
|
CU_ASSERT(backing_dev.close != NULL);
|
|
/* Confirm that the path to the persistent memory metadata file was persisted to
|
|
* the backing device.
|
|
*/
|
|
CU_ASSERT(strncmp(TEST_MD_PATH,
|
|
g_backing_dev_buf + REDUCE_BACKING_DEV_PATH_OFFSET,
|
|
REDUCE_PATH_MAX) == 0);
|
|
|
|
g_ziperrno = -1;
|
|
g_backing_dev_closed = false;
|
|
spdk_reduce_vol_unload(g_vol, unload_cb, NULL);
|
|
CU_ASSERT(g_ziperrno == 0);
|
|
CU_ASSERT(g_backing_dev_closed == true);
|
|
|
|
pm_file_destroy();
|
|
backing_dev_destroy(&backing_dev);
|
|
}
|
|
|
|
int
|
|
main(int argc, char **argv)
|
|
{
|
|
CU_pSuite suite = NULL;
|
|
unsigned int num_failures;
|
|
|
|
if (CU_initialize_registry() != CUE_SUCCESS) {
|
|
return CU_get_error();
|
|
}
|
|
|
|
suite = CU_add_suite("reduce", NULL, NULL);
|
|
if (suite == NULL) {
|
|
CU_cleanup_registry();
|
|
return CU_get_error();
|
|
}
|
|
|
|
if (
|
|
CU_add_test(suite, "get_pm_file_size", get_pm_file_size) == NULL ||
|
|
CU_add_test(suite, "get_backing_device_size", get_backing_device_size) == NULL ||
|
|
CU_add_test(suite, "init_failure", init_failure) == NULL ||
|
|
CU_add_test(suite, "init_md", init_md) == NULL ||
|
|
CU_add_test(suite, "init_backing_dev", init_backing_dev) == NULL
|
|
) {
|
|
CU_cleanup_registry();
|
|
return CU_get_error();
|
|
}
|
|
|
|
CU_basic_set_mode(CU_BRM_VERBOSE);
|
|
CU_basic_run_tests();
|
|
num_failures = CU_get_number_of_failures();
|
|
CU_cleanup_registry();
|
|
return num_failures;
|
|
}
|