In SPDK, declarations have the return type on the same line. Definitions have the return type on a separate line. Astyle has an option for enforcing this. Unfortunately, it seems to have two bugs: 1) It doesn't work correctly at all on C++ files. 2) It often fails on functions that return enums, or long type names Deal with 1) by adjusting the check_format.sh script to only tell astyle to fix return type line breaks for C files and not C++. Deal with 2) by adding a few typedefs to work around the problem. Change-Id: Idf28281466cab8411ce252d5f02ab384166790c6 Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13437 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Dong Yi <dongx.yi@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
146 lines
2.7 KiB
C
146 lines
2.7 KiB
C
/* SPDX-License-Identifier: BSD-3-Clause
|
|
* Copyright (c) Intel Corporation.
|
|
* All rights reserved.
|
|
*/
|
|
|
|
#include "spdk/env.h"
|
|
#include "ocf_env.h"
|
|
|
|
#include "mpool.h"
|
|
|
|
struct env_mpool {
|
|
env_allocator *allocator[env_mpool_max];
|
|
/* Handles to memory pools */
|
|
|
|
uint32_t hdr_size;
|
|
/* Data header size (constant allocation part) */
|
|
|
|
uint32_t elem_size;
|
|
/* Per element size increment (variable allocation part) */
|
|
|
|
uint32_t mpool_max;
|
|
/* Max mpool allocation order */
|
|
|
|
bool fallback;
|
|
/* Fallback to vmalloc */
|
|
};
|
|
|
|
struct env_mpool *env_mpool_create(uint32_t hdr_size, uint32_t elem_size,
|
|
int flags, int mpool_max, bool fallback,
|
|
const uint32_t limits[env_mpool_max],
|
|
const char *name_prefix, bool zero)
|
|
{
|
|
int i;
|
|
char name[OCF_ALLOCATOR_NAME_MAX] = {};
|
|
int ret;
|
|
int size;
|
|
|
|
struct env_mpool *mpool = env_zalloc(sizeof(struct env_mpool), ENV_MEM_NOIO);
|
|
if (!mpool) {
|
|
return NULL;
|
|
}
|
|
|
|
mpool->hdr_size = hdr_size;
|
|
mpool->elem_size = elem_size;
|
|
mpool->mpool_max = mpool_max;
|
|
mpool->fallback = fallback;
|
|
|
|
for (i = 0; i < min(env_mpool_max, mpool_max + 1); i++) {
|
|
ret = snprintf(name, sizeof(name), "%s_%u", name_prefix, (1 << i));
|
|
if (ret < 0 || ret >= (int)sizeof(name)) {
|
|
goto err;
|
|
}
|
|
|
|
size = hdr_size + (elem_size * (1 << i));
|
|
|
|
mpool->allocator[i] = env_allocator_create_extended(size, name,
|
|
limits ? limits[i] : -1, zero);
|
|
|
|
if (!mpool->allocator[i]) {
|
|
goto err;
|
|
}
|
|
}
|
|
|
|
return mpool;
|
|
|
|
err:
|
|
env_mpool_destroy(mpool);
|
|
return NULL;
|
|
}
|
|
|
|
void
|
|
env_mpool_destroy(struct env_mpool *mpool)
|
|
{
|
|
if (mpool) {
|
|
int i;
|
|
|
|
for (i = 0; i < env_mpool_max; i++) {
|
|
if (mpool->allocator[i]) {
|
|
env_allocator_destroy(mpool->allocator[i]);
|
|
}
|
|
}
|
|
|
|
env_free(mpool);
|
|
}
|
|
}
|
|
|
|
static env_allocator *
|
|
env_mpool_get_allocator(struct env_mpool *mpool,
|
|
uint32_t count)
|
|
{
|
|
unsigned int idx;
|
|
|
|
if (unlikely(count == 0)) {
|
|
return mpool->allocator[env_mpool_1];
|
|
}
|
|
|
|
idx = 31 - __builtin_clz(count);
|
|
|
|
if (__builtin_ffs(count) <= idx) {
|
|
idx++;
|
|
}
|
|
|
|
if (idx >= env_mpool_max || idx > mpool->mpool_max) {
|
|
return NULL;
|
|
}
|
|
|
|
return mpool->allocator[idx];
|
|
}
|
|
|
|
void *
|
|
env_mpool_new(struct env_mpool *mpool, uint32_t count)
|
|
{
|
|
void *items = NULL;
|
|
env_allocator *allocator;
|
|
size_t size = mpool->hdr_size + (mpool->elem_size * count);
|
|
|
|
allocator = env_mpool_get_allocator(mpool, count);
|
|
|
|
if (allocator) {
|
|
items = env_allocator_new(allocator);
|
|
} else if (mpool->fallback) {
|
|
items = env_vmalloc(size);
|
|
}
|
|
|
|
return items;
|
|
}
|
|
|
|
bool
|
|
env_mpool_del(struct env_mpool *mpool,
|
|
void *items, uint32_t count)
|
|
{
|
|
env_allocator *allocator;
|
|
|
|
allocator = env_mpool_get_allocator(mpool, count);
|
|
|
|
if (allocator) {
|
|
env_allocator_del(allocator, items);
|
|
} else if (mpool->fallback) {
|
|
env_vfree(items);
|
|
} else {
|
|
return false;
|
|
}
|
|
|
|
return true;
|
|
}
|