56d35c5d13
Static analyzers don't see CU_ASSERT_FATAL as truly fatal, and will complain that code later in the function may try to dereference a NULL pointer. So we added SPDK_CU_ASSERT_FATAL which should be used instead. This still trips people up sometimes though - the static analyzer complains and then the developer will add other checks that pointers are not NULL. So instead, forbid use of CU_ASSERT_FATAL through check_format.sh and explain why. While here, fix up all of the existing CU_ASSERT_FATAL usages to either CU_ASSERT or SPDK_CU_ASSERT_FATAL. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I7974c8c85ddb89ed1b7d882db3a2eb0882ea0217 Reviewed-on: https://review.gerrithub.io/418111 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> |
||
|---|---|---|
| .. | ||
| conn.c | ||
| init_grp.c | ||
| iscsi.c | ||
| param.c | ||
| portal_grp.c | ||
| tgt_node.c | ||
| common.c | ||
| Makefile | ||