c8734543bc
By passing the pointer to struct spdk_nvmf_transport_poll_group to spdk_nvmf_tcp_req_parse_sgl(), we can remove spdk_nvmf_tcp_req_fill_iovs() and inline spdk_nvmf_request_get_buffers() into spdk_nvmf_tcp_req_parse_sgl(). Pointers to struct spdk_nvmf_request are used in many lines of spdk_nvmf_tcp_req_parse_sgl(). Caching and using them simplifies and improves readability a little for spdk_nvmf_tcp_req_parse_sgl(). We can pass pointer to not struct spdk_nvmf_tcp_transport but struct spdk_nvmf_transport to spdk_nvmf_tcp_req_parse_sgl(). Ordering the pointer to struct spdk_nvmf_tcp_req first in parameters of spdk_nvmf_tcp_req_parse_sgl() matches the function name. Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Change-Id: I9f0d33b48383800c3b0a738eb24b11ffed7e6e60 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/469640 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ziye Yang <ziye.yang@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Alexey Marchuk <alexeymar@mellanox.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> |
||
|---|---|---|
| .. | ||
| ctrlr_bdev.c | ||
| ctrlr_discovery.c | ||
| ctrlr.c | ||
| fc_ls.c | ||
| fc.c | ||
| Makefile | ||
| nvmf_fc.h | ||
| nvmf_internal.h | ||
| nvmf_rpc.c | ||
| nvmf.c | ||
| rdma.c | ||
| subsystem.c | ||
| tcp.c | ||
| transport.c | ||
| transport.h | ||