21b37d4ee6
The current implementation of nvme_assert in the unit test nvme_impl.h
just prints the message and continues.
We should not be triggering assert conditions, even in the unit test
code, so make nvme_assert actually call assert(). This lets us catch
mistakes in the unit tests more easily.
Also fix the two unit tests that currently trigger an assert:
- The I/O splitting test in nvme_ns_cmd_ut was passing an invalid
combination of NULL payload with non-zero lba_count.
- The ctrlr_cmd test was passing an invalid number of entries to
nvme_ctrlr_cmd_get_error_page(). This case should probably not be an
assert but rather an error code. However, the function does not
return a status code currently, so it is not trivial to make that
change. For now, just drop the asserting test case and the code added
to the test to work around it.
While we're here, fix the macros in the unit test nvme_impl.h so they
are usable in single-line conditionals without braces - that is the
whole point of the do { ... } while (0) pattern, so there should be no
trailing semicolon.
Change-Id: Iad503c5c5d19a426d48c80d9a7d6da12ff2c982a
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
120 lines
3.7 KiB
C
120 lines
3.7 KiB
C
/*-
|
|
* BSD LICENSE
|
|
*
|
|
* Copyright(c) 2010-2015 Intel Corporation. All rights reserved.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
*
|
|
* * Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in
|
|
* the documentation and/or other materials provided with the
|
|
* distribution.
|
|
* * Neither the name of Intel Corporation nor the names of its
|
|
* contributors may be used to endorse or promote products derived
|
|
* from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#ifndef __NVME_IMPL_H__
|
|
#define __NVME_IMPL_H__
|
|
|
|
#include <assert.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <stdint.h>
|
|
#include <pthread.h>
|
|
|
|
static inline void *
|
|
nvme_malloc(const char *tag, size_t size, unsigned align, uint64_t *phys_addr)
|
|
{
|
|
void *buf = calloc(1, size);
|
|
*phys_addr = (uint64_t)buf;
|
|
return buf;
|
|
}
|
|
|
|
#define nvme_free(buf) free(buf)
|
|
#define OUTBUF_SIZE 1024
|
|
extern char outbuf[OUTBUF_SIZE];
|
|
#define nvme_printf(ctrlr, fmt, args...) snprintf(outbuf, OUTBUF_SIZE, fmt, ##args)
|
|
#define nvme_get_num_ioq() 8
|
|
#define nvme_get_ioq_idx() 0
|
|
#define nvme_assert(check, str) \
|
|
do \
|
|
{ \
|
|
if (!(check)) { \
|
|
printf str; \
|
|
assert(check); \
|
|
} \
|
|
} \
|
|
while (0)
|
|
|
|
uint64_t nvme_vtophys(void *buf);
|
|
#define nvme_alloc_request(bufp) \
|
|
do \
|
|
{ \
|
|
*bufp = malloc(sizeof(struct nvme_request)); \
|
|
} \
|
|
while (0)
|
|
|
|
#define nvme_free_request(buf) free(buf)
|
|
#define nvme_pcicfg_read32(handle, var, offset) do { *(var) = 0xFFFFFFFFu; } while (0)
|
|
#define nvme_pcicfg_write32(handle, var, offset) do { (void)(var); } while (0)
|
|
|
|
static inline
|
|
int nvme_pcicfg_map_bar(void *pci_handle, int bar, int read_only, void **addr)
|
|
{
|
|
*addr = NULL;
|
|
return 0;
|
|
}
|
|
|
|
static inline int
|
|
nvme_pcicfg_unmap_bar(void *devhandle, uint32_t bar, void *addr)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
typedef pthread_mutex_t nvme_mutex_t;
|
|
|
|
#define nvme_mutex_init(x) pthread_mutex_init((x), NULL)
|
|
#define nvme_mutex_destroy(x) pthread_mutex_destroy((x))
|
|
#define nvme_mutex_lock pthread_mutex_lock
|
|
#define nvme_mutex_unlock pthread_mutex_unlock
|
|
#define NVME_MUTEX_INITIALIZER PTHREAD_MUTEX_INITIALIZER
|
|
|
|
static inline int
|
|
nvme_mutex_init_recursive(nvme_mutex_t *mtx)
|
|
{
|
|
pthread_mutexattr_t attr;
|
|
|
|
if (pthread_mutexattr_init(&attr)) {
|
|
return -1;
|
|
}
|
|
if (pthread_mutexattr_settype(&attr, PTHREAD_MUTEX_RECURSIVE)) {
|
|
return -1;
|
|
}
|
|
return pthread_mutex_init(mtx, &attr);
|
|
}
|
|
|
|
/**
|
|
* Copy a struct nvme_command from one memory location to another.
|
|
*/
|
|
#define nvme_copy_command(dst, src) memcpy((dst), (src), sizeof(struct nvme_command))
|
|
|
|
#endif /* __NVME_IMPL_H__ */
|