c2f38258f9
The results of access control procedure for login in the spdk_iscsi_tgt_node_access() is defined in the following table: +------------------------------+ |iscsi name |netmask |result | +------------------------------+ +------------------------------+ |denied |- |denied | +------------------------------+ |allowed |allowed |allowed | +------------------------------+ |allowed |denied |next IG | +------------------------------+ |not found |- |next IG | +------------------------------+ However current implementation have redundant repetition in the spdk_iscsi_tgt_node_access() and the above definition is not visible. Hence refactor spdk_iscsi_tgt_node_access(). Besides refactor spdk_iscsi_tgt_node_allow_iscsi_name() because it has redundant repetition too. Add UT code for these changes. Change-Id: If06d87c1246c85439ee0482149bd887a7b53b169 Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/379935 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> |
||
|---|---|---|
| .. | ||
| init_grp.c | ||
| iscsi.c | ||
| param.c | ||
| tgt_node.c | ||
| common.c | ||
| Makefile | ||