Spdk/test/unit/lib/iscsi
Shuhei Matsumoto 64a268e2e1 iscsi: Fix double dequeue of the primary write task in error handling
By running random, 64KB, 70% write, and 30% read workload and periodical
TCP disconnection from the initiator, segmentation fault have occurred.

By investigation, when the last write task completed and dequeued
the primary write task in spdk_iscsi_task_cpl(), the primary write task
was already dequeued in spdk_clear_all_transfer_task().

This patch dequeues all primary write tasks after all outstanding
tasks complete.

After starting to exit the connection, the connection will not receive
any command. Hence waiting for completion of all pending tasks first will
avoid double dequeue safely.

Change-Id: I8e2b6b756be3a6e096675acc81cdb93fb6a7e350
Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-on: https://review.gerrithub.io/430397
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-10-23 17:58:52 +00:00
..
conn.c iscsi: Fix double dequeue of the primary write task in error handling 2018-10-23 17:58:52 +00:00
init_grp.c iscsi: Add JSON config/info dump for initiator group. 2018-05-10 19:38:26 +00:00
iscsi.c test/unit: fix scan-build errors in iscsi tests 2018-08-31 00:01:09 +00:00
param.c test: fix typos in the test directory 2018-08-27 19:39:31 +00:00
portal_grp.c test/unit: remove more scan-build errors 2018-07-09 19:45:40 +00:00
tgt_node.c iscsi: Add JSON config/info dump for target node. 2018-05-04 17:45:48 +00:00
common.c test/unit: fix scan-build errors in iscsi tests 2018-08-31 00:01:09 +00:00
Makefile iscsi&iscsi/ut: Unify cpumask decode between iSCSI.conf and JSON-RPC 2018-01-19 15:47:57 -05:00