The first optimization to eliminate memcpy was too aggressive and did so for the read-modify-write operation as well. This didn't affect the fio tests used that the time but bdevio catches it right away. When over writing a chunk with data, we first need to read the old data before applying the new. This patch uses the scratch buffer for old data as sending it to the user buffer results in it not being written at the end of the read-modify-write. There is at least one more bug fix coming after this also found with bdevio but passed with fio Signed-off-by: paul luse <paul.e.luse@intel.com> Change-Id: I8fe074056434bb4757c68077e2df446861edfd94 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/461032 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> |
||
---|---|---|
.. | ||
Makefile | ||
reduce.c |