In SPDK, declarations have the return type on the same line. Definitions have the return type on a separate line. Astyle has an option for enforcing this. Unfortunately, it seems to have two bugs: 1) It doesn't work correctly at all on C++ files. 2) It often fails on functions that return enums, or long type names Deal with 1) by adjusting the check_format.sh script to only tell astyle to fix return type line breaks for C files and not C++. Deal with 2) by adding a few typedefs to work around the problem. Change-Id: Idf28281466cab8411ce252d5f02ab384166790c6 Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13437 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Dong Yi <dongx.yi@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com> |
||
---|---|---|
.. | ||
.gitignore | ||
Makefile | ||
overhead.c | ||
README |
This application measures the software overhead of I/O submission and completion for both the SPDK NVMe driver and an AIO file handle. It runs a random read, queue depth = 1 workload to a single device, and captures TSC as follows: * Submission: capture TSC before and after the I/O submission call (SPDK or AIO). * Completion: capture TSC before and after the I/O completion check. Only record the TSC delta if the I/O completion check resulted in a completed I/O. Also use heuristics in the AIO case to account for time spent in interrupt handling outside of the actual I/O completion check. Usage: To test software overhead for a 4KB I/O over a 10 second period: SPDK: overhead -s 4096 -t 10 AIO: overhead -s 4096 -t 10 /dev/nvme0n1 Note that for the SPDK case, it will only use the first namespace on the first controller found by SPDK. If a different namespace is desired, attach controllers individually to the kernel NVMe driver to ensure they will not be enumerated by SPDK.