889ee6194a
They were initially developed to bump code coverage, but now with upcoming vhost changes they are too much of a wart to keep updating. They heavily rely on vhost internals and are not particularly useful for testing. Right now these tests allocate a vhost target struct, hack its internals and try to call *_unregister() on it, hoping to trigger some expected error. One way to properly test the Vhost library would be to mock rte_vhost_* functions and use the spdk/vhost.h API to manage targets/devices. However, this is a greater refactor and would more likely fit in a multi-threaded unit test environment. Change-Id: Ia6cb0e1f7d0d57aef35050427396f895fb3bd7e1 Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com> Reviewed-on: https://review.gerrithub.io/407390 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Pawel Wodkowski <pawelx.wodkowski@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> |
||
|---|---|---|
| .. | ||
| vhost.c | ||
| Makefile | ||
| test_vhost.c | ||