9f872d2040
This keeps original behavior, allowing scheduler to move the thread if no core mask was specified - something the in-tree test scripts do now. This original behavior made it easier to just start bdev_svc as a dumb background process to speed up nvme test programs running as secondary processes. But if the user wants to specify a core mask to use bdev_svc for other purposes, we shouldn't unaffinitize the thread. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I169a71d71c18ca7d6d1660e8401e84fc19a8cc9b Reviewed-on: https://review.gerrithub.io/409774 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
113 lines
3.3 KiB
C
113 lines
3.3 KiB
C
/*-
|
|
* BSD LICENSE
|
|
*
|
|
* Copyright (c) Intel Corporation.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
*
|
|
* * Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in
|
|
* the documentation and/or other materials provided with the
|
|
* distribution.
|
|
* * Neither the name of Intel Corporation nor the names of its
|
|
* contributors may be used to endorse or promote products derived
|
|
* from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include "spdk/stdinc.h"
|
|
|
|
#include "spdk/env.h"
|
|
#include "spdk/event.h"
|
|
|
|
static char g_path[256];
|
|
static bool g_unaffinitize_thread = false;
|
|
|
|
static void
|
|
bdev_svc_usage(void)
|
|
{
|
|
}
|
|
|
|
static void
|
|
bdev_svc_parse_arg(int ch, char *arg)
|
|
{
|
|
}
|
|
|
|
static void
|
|
bdev_svc_start(void *arg1, void *arg2)
|
|
{
|
|
int fd;
|
|
int shm_id = (intptr_t)arg1;
|
|
|
|
if (g_unaffinitize_thread) {
|
|
spdk_unaffinitize_thread();
|
|
}
|
|
|
|
snprintf(g_path, sizeof(g_path), "/var/run/spdk_bdev%d", shm_id);
|
|
fd = open(g_path, O_CREAT | O_EXCL | O_RDWR, S_IFREG);
|
|
if (fd < 0) {
|
|
fprintf(stderr, "could not create sentinel file %s\n", g_path);
|
|
exit(1);
|
|
}
|
|
close(fd);
|
|
}
|
|
|
|
static void
|
|
bdev_svc_shutdown(void)
|
|
{
|
|
unlink(g_path);
|
|
spdk_app_stop(0);
|
|
}
|
|
|
|
int
|
|
main(int argc, char **argv)
|
|
{
|
|
int rc;
|
|
struct spdk_app_opts opts = {};
|
|
|
|
/* default value in opts structure */
|
|
spdk_app_opts_init(&opts);
|
|
|
|
opts.name = "bdev_svc";
|
|
opts.shutdown_cb = bdev_svc_shutdown;
|
|
opts.max_delay_us = 1000 * 1000;
|
|
|
|
if ((rc = spdk_app_parse_args(argc, argv, &opts, "",
|
|
bdev_svc_parse_arg, bdev_svc_usage)) !=
|
|
SPDK_APP_PARSE_ARGS_SUCCESS) {
|
|
exit(rc);
|
|
}
|
|
|
|
/* User did not specify a reactor mask. Test scripts may do this when using
|
|
* bdev_svc as a primary process to speed up nvme test programs by running
|
|
* them as secondary processes. In that case, we will unaffinitize the thread
|
|
* in the bdev_svc_start routine, which will allow the scheduler to move this
|
|
* thread so it doesn't conflict with pinned threads in the secondary processes.
|
|
*/
|
|
if (opts.reactor_mask == NULL) {
|
|
g_unaffinitize_thread = true;
|
|
}
|
|
|
|
rc = spdk_app_start(&opts, bdev_svc_start, (void *)(intptr_t)opts.shm_id, NULL);
|
|
|
|
spdk_app_fini();
|
|
|
|
return rc;
|
|
}
|