081d8a8458
A recent change to the bdevio test changed one of the
tests from a 30x4K IO to a 30xLBA IO.
This has started giving us nightly test failures (see
issue #2499). It is because now the 30 * LBA (512B)
is 15KB which all fits within one 16KiB reduce chunk,
yet we only allocate REDUCE_MAX_IOVS
(17) iovs per reduce IO context. Previously when
they were 4KiB each, we would only need 4 iovecs
(16KiB / 4KiB).
We may need to think through this a bit more, to
make this more dynamic (based on the chunk size
and underlying block size), but for now let's at
least increase this enough to handle the most
common 16KiB chunk / 512B LBA case.
While here, run bdevio as part of per-patch testing,
that would have helped us catch this issue before the
a6e022463 patch got merged.
Fixes #2499.
Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: I2140c5b9d038b202edfdcbb2bfee059140f7703a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12672
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Karol Latecki <karol.latecki@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
120 lines
3.2 KiB
Bash
Executable File
120 lines
3.2 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
|
|
set -e
|
|
|
|
testdir=$(readlink -f $(dirname $0))
|
|
rootdir=$(readlink -f $testdir/../..)
|
|
plugindir=$rootdir/examples/bdev/fio_plugin
|
|
rpc_py="$rootdir/scripts/rpc.py"
|
|
source "$rootdir/scripts/common.sh"
|
|
source "$rootdir/test/common/autotest_common.sh"
|
|
source "$rootdir/test/nvmf/common.sh"
|
|
|
|
function error_cleanup() {
|
|
# force delete pmem file and wipe on-disk metadata
|
|
rm -rf /tmp/pmem
|
|
$SPDK_EXAMPLE_DIR/perf -q 1 -o 131072 -w write -t 2
|
|
}
|
|
|
|
function destroy_vols() {
|
|
# Gracefully destroy the vols via bdev_compress_delete API.
|
|
# bdev_compress_delete will delete the on-disk metadata as well as
|
|
# the persistent memory file containing its metadata.
|
|
$rpc_py bdev_compress_delete COMP_lvs0/lv0
|
|
$rpc_py bdev_lvol_delete_lvstore -l lvs0
|
|
}
|
|
|
|
function create_vols() {
|
|
$rootdir/scripts/gen_nvme.sh | $rpc_py load_subsystem_config
|
|
waitforbdev Nvme0n1
|
|
|
|
$rpc_py bdev_lvol_create_lvstore Nvme0n1 lvs0
|
|
$rpc_py bdev_lvol_create -t -l lvs0 lv0 100
|
|
waitforbdev lvs0/lv0
|
|
|
|
$rpc_py compress_set_pmd -p "$pmd"
|
|
if [ -z "$1" ]; then
|
|
$rpc_py bdev_compress_create -b lvs0/lv0 -p /tmp/pmem
|
|
else
|
|
$rpc_py bdev_compress_create -b lvs0/lv0 -p /tmp/pmem -l $1
|
|
fi
|
|
waitforbdev COMP_lvs0/lv0
|
|
}
|
|
|
|
function run_bdevio() {
|
|
$rootdir/test/bdev/bdevio/bdevio -w &
|
|
bdevio_pid=$!
|
|
trap 'killprocess $bdevio_pid; error_cleanup; exit 1' SIGINT SIGTERM EXIT
|
|
waitforlisten $bdevio_pid
|
|
create_vols
|
|
$rootdir/test/bdev/bdevio/tests.py perform_tests
|
|
destroy_vols
|
|
trap - SIGINT SIGTERM EXIT
|
|
killprocess $bdevio_pid
|
|
}
|
|
|
|
function run_bdevperf() {
|
|
$rootdir/test/bdev/bdevperf/bdevperf -z -q $1 -o $2 -w verify -t $3 -C -m 0x6 &
|
|
bdevperf_pid=$!
|
|
trap 'killprocess $bdevperf_pid; error_cleanup; exit 1' SIGINT SIGTERM EXIT
|
|
waitforlisten $bdevperf_pid
|
|
create_vols $4
|
|
$rootdir/test/bdev/bdevperf/bdevperf.py perform_tests
|
|
destroy_vols
|
|
trap - SIGINT SIGTERM EXIT
|
|
killprocess $bdevperf_pid
|
|
}
|
|
|
|
test_type=$1
|
|
case "$test_type" in
|
|
qat)
|
|
pmd=1
|
|
;;
|
|
isal)
|
|
pmd=2
|
|
;;
|
|
*)
|
|
echo "invalid pmd name"
|
|
exit 1
|
|
;;
|
|
esac
|
|
|
|
mkdir -p /tmp/pmem
|
|
|
|
# per patch bdevperf uses slightly different params than nightly
|
|
# logical block size same as underlying device, then 512 then 4096
|
|
run_bdevperf 32 4096 3
|
|
run_bdevperf 32 4096 3 512
|
|
run_bdevperf 32 4096 3 4096
|
|
run_bdevio
|
|
|
|
if [ $RUN_NIGHTLY -eq 1 ]; then
|
|
run_bdevperf 64 16384 30
|
|
|
|
# run perf on nvmf target w/compressed vols
|
|
export TEST_TRANSPORT=tcp && nvmftestinit
|
|
nvmfappstart -m 0x7
|
|
trap "nvmftestfini; error_cleanup; exit 1" SIGINT SIGTERM EXIT
|
|
|
|
# Create an NVMe-oF subsystem and add compress bdevs as namespaces
|
|
$rpc_py nvmf_create_transport -t $TEST_TRANSPORT -u 8192
|
|
create_vols
|
|
$rpc_py nvmf_create_subsystem nqn.2016-06.io.spdk:cnode0 -a -s SPDK0
|
|
$rpc_py nvmf_subsystem_add_ns nqn.2016-06.io.spdk:cnode0 COMP_lvs0/lv0
|
|
$rpc_py nvmf_subsystem_add_listener nqn.2016-06.io.spdk:cnode0 -t $TEST_TRANSPORT -a $NVMF_FIRST_TARGET_IP -s $NVMF_PORT
|
|
|
|
# Start random read writes in the background
|
|
$SPDK_EXAMPLE_DIR/perf -r "trtype:$TEST_TRANSPORT adrfam:IPv4 traddr:$NVMF_FIRST_TARGET_IP trsvcid:$NVMF_PORT" -o 4096 -q 64 -s 512 -w randrw -t 30 -c 0x18 -M 50 &
|
|
perf_pid=$!
|
|
|
|
# Wait for I/O to complete
|
|
trap 'killprocess $perf_pid; compress_err_cleanup; exit 1' SIGINT SIGTERM EXIT
|
|
wait $perf_pid
|
|
destroy_vols
|
|
|
|
trap - SIGINT SIGTERM EXIT
|
|
nvmftestfini
|
|
fi
|
|
|
|
rm -rf /tmp/pmem
|