This is a small clean up. Use custom JSON decoders for the io_type and error_type parameters in the bdev_error_injection_error RPC. Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com> Change-Id: I528fe4a31fac7eddb8ec33594b90e107d71693be Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15024 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com> Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com>
194 lines
5.2 KiB
C
194 lines
5.2 KiB
C
/* SPDX-License-Identifier: BSD-3-Clause
|
|
* Copyright (c) Intel Corporation.
|
|
* All rights reserved.
|
|
*/
|
|
|
|
#include "spdk/stdinc.h"
|
|
#include "spdk/string.h"
|
|
#include "spdk/rpc.h"
|
|
#include "spdk/util.h"
|
|
#include "spdk/string.h"
|
|
#include "spdk/log.h"
|
|
#include "vbdev_error.h"
|
|
|
|
static int
|
|
rpc_error_bdev_decode_io_type(const struct spdk_json_val *val, void *out)
|
|
{
|
|
uint32_t *io_type = out;
|
|
|
|
if (spdk_json_strequal(val, "read") == true) {
|
|
*io_type = SPDK_BDEV_IO_TYPE_READ;
|
|
} else if (spdk_json_strequal(val, "write") == true) {
|
|
*io_type = SPDK_BDEV_IO_TYPE_WRITE;
|
|
} else if (spdk_json_strequal(val, "flush") == true) {
|
|
*io_type = SPDK_BDEV_IO_TYPE_FLUSH;
|
|
} else if (spdk_json_strequal(val, "unmap") == true) {
|
|
*io_type = SPDK_BDEV_IO_TYPE_UNMAP;
|
|
} else if (spdk_json_strequal(val, "all") == true) {
|
|
*io_type = 0xffffffff;
|
|
} else if (spdk_json_strequal(val, "clear") == true) {
|
|
*io_type = 0;
|
|
} else {
|
|
SPDK_NOTICELOG("Invalid parameter value: io_type\n");
|
|
return -EINVAL;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int
|
|
rpc_error_bdev_decode_error_type(const struct spdk_json_val *val, void *out)
|
|
{
|
|
uint32_t *error_type = out;
|
|
|
|
if (spdk_json_strequal(val, "failure") == true) {
|
|
*error_type = VBDEV_IO_FAILURE;
|
|
} else if (spdk_json_strequal(val, "pending") == true) {
|
|
*error_type = VBDEV_IO_PENDING;
|
|
} else {
|
|
SPDK_NOTICELOG("Invalid parameter value: error_type\n");
|
|
return -EINVAL;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
struct rpc_bdev_error_create {
|
|
char *base_name;
|
|
};
|
|
|
|
static void
|
|
free_rpc_bdev_error_create(struct rpc_bdev_error_create *req)
|
|
{
|
|
free(req->base_name);
|
|
}
|
|
|
|
static const struct spdk_json_object_decoder rpc_bdev_error_create_decoders[] = {
|
|
{"base_name", offsetof(struct rpc_bdev_error_create, base_name), spdk_json_decode_string},
|
|
};
|
|
|
|
static void
|
|
rpc_bdev_error_create(struct spdk_jsonrpc_request *request,
|
|
const struct spdk_json_val *params)
|
|
{
|
|
struct rpc_bdev_error_create req = {};
|
|
int rc = 0;
|
|
|
|
if (spdk_json_decode_object(params, rpc_bdev_error_create_decoders,
|
|
SPDK_COUNTOF(rpc_bdev_error_create_decoders),
|
|
&req)) {
|
|
SPDK_ERRLOG("spdk_json_decode_object failed\n");
|
|
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR,
|
|
"spdk_json_decode_object failed");
|
|
goto cleanup;
|
|
}
|
|
|
|
rc = vbdev_error_create(req.base_name);
|
|
if (rc) {
|
|
spdk_jsonrpc_send_error_response(request, rc, spdk_strerror(-rc));
|
|
goto cleanup;
|
|
}
|
|
|
|
spdk_jsonrpc_send_bool_response(request, true);
|
|
|
|
cleanup:
|
|
free_rpc_bdev_error_create(&req);
|
|
}
|
|
SPDK_RPC_REGISTER("bdev_error_create", rpc_bdev_error_create, SPDK_RPC_RUNTIME)
|
|
|
|
struct rpc_delete_error {
|
|
char *name;
|
|
};
|
|
|
|
static void
|
|
free_rpc_delete_error(struct rpc_delete_error *r)
|
|
{
|
|
free(r->name);
|
|
}
|
|
|
|
static const struct spdk_json_object_decoder rpc_delete_error_decoders[] = {
|
|
{"name", offsetof(struct rpc_delete_error, name), spdk_json_decode_string},
|
|
};
|
|
|
|
static void
|
|
rpc_bdev_error_delete_cb(void *cb_arg, int bdeverrno)
|
|
{
|
|
struct spdk_jsonrpc_request *request = cb_arg;
|
|
|
|
if (bdeverrno == 0) {
|
|
spdk_jsonrpc_send_bool_response(request, true);
|
|
} else {
|
|
spdk_jsonrpc_send_error_response(request, bdeverrno, spdk_strerror(-bdeverrno));
|
|
}
|
|
}
|
|
|
|
static void
|
|
rpc_bdev_error_delete(struct spdk_jsonrpc_request *request,
|
|
const struct spdk_json_val *params)
|
|
{
|
|
struct rpc_delete_error req = {NULL};
|
|
|
|
if (spdk_json_decode_object(params, rpc_delete_error_decoders,
|
|
SPDK_COUNTOF(rpc_delete_error_decoders),
|
|
&req)) {
|
|
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR,
|
|
"spdk_json_decode_object failed");
|
|
goto cleanup;
|
|
}
|
|
|
|
vbdev_error_delete(req.name, rpc_bdev_error_delete_cb, request);
|
|
|
|
cleanup:
|
|
free_rpc_delete_error(&req);
|
|
}
|
|
SPDK_RPC_REGISTER("bdev_error_delete", rpc_bdev_error_delete, SPDK_RPC_RUNTIME)
|
|
|
|
struct rpc_error_information {
|
|
char *name;
|
|
uint32_t io_type;
|
|
uint32_t error_type;
|
|
uint32_t num;
|
|
};
|
|
|
|
static const struct spdk_json_object_decoder rpc_error_information_decoders[] = {
|
|
{"name", offsetof(struct rpc_error_information, name), spdk_json_decode_string},
|
|
{"io_type", offsetof(struct rpc_error_information, io_type), rpc_error_bdev_decode_io_type},
|
|
{"error_type", offsetof(struct rpc_error_information, error_type), rpc_error_bdev_decode_error_type},
|
|
{"num", offsetof(struct rpc_error_information, num), spdk_json_decode_uint32, true},
|
|
};
|
|
|
|
static void
|
|
free_rpc_error_information(struct rpc_error_information *p)
|
|
{
|
|
free(p->name);
|
|
}
|
|
|
|
static void
|
|
rpc_bdev_error_inject_error(struct spdk_jsonrpc_request *request,
|
|
const struct spdk_json_val *params)
|
|
{
|
|
struct rpc_error_information req = {.num = 1};
|
|
int rc = 0;
|
|
|
|
if (spdk_json_decode_object(params, rpc_error_information_decoders,
|
|
SPDK_COUNTOF(rpc_error_information_decoders),
|
|
&req)) {
|
|
SPDK_ERRLOG("spdk_json_decode_object failed\n");
|
|
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR,
|
|
"spdk_json_decode_object failed");
|
|
goto cleanup;
|
|
}
|
|
|
|
rc = vbdev_error_inject_error(req.name, req.io_type, req.error_type, req.num);
|
|
if (rc) {
|
|
spdk_jsonrpc_send_error_response(request, rc, spdk_strerror(-rc));
|
|
goto cleanup;
|
|
}
|
|
|
|
spdk_jsonrpc_send_bool_response(request, true);
|
|
|
|
cleanup:
|
|
free_rpc_error_information(&req);
|
|
}
|
|
SPDK_RPC_REGISTER("bdev_error_inject_error", rpc_bdev_error_inject_error, SPDK_RPC_RUNTIME)
|