Spdk/lib/iscsi
Shuhei Matsumoto 92ef1a64ec iscsi and ut/iscsi: return code to fail of IG creation
spdk_iscsi_init_grp_create_from_configfile() returns 0 even if
creating an initiator group (IG) is failed due to empty netmask or
initiator name. This will be unexpected behavior for end users.
Hence change the return code from 0 to -ENVAL for this failure.

Besides do the following.

Change other error return codes in the function by using errno too.

Current IG don't have any UT code in repository. UT code to confirm
this fix is also submitted.

Change-Id: Ic918feb5c6a3e772b325664d881b2673b553a217
Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-on: https://review.gerrithub.io/384408
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-11-21 16:06:30 -05:00
..
acceptor.c event: Pollers must now be unregistered from the thread they run on. 2017-11-17 11:11:23 -05:00
acceptor.h iscsi: login poller per portal and portal cache 2017-10-06 17:00:45 -04:00
conn.c event: Pollers must now be unregistered from the thread they run on. 2017-11-17 11:11:23 -05:00
conn.h iscsi: login poller per portal and portal cache 2017-10-06 17:00:45 -04:00
init_grp.c iscsi and ut/iscsi: return code to fail of IG creation 2017-11-21 16:06:30 -05:00
init_grp.h iscsi: delete spdk_iscsi_init_grp_destroy_by_tag() 2017-11-03 14:08:47 -04:00
iscsi_rpc.c iscsi: turn <add/delete name&mask of IG> into functions 2017-11-03 14:08:47 -04:00
iscsi_subsystem.c env/dpdk: use rte_virt2iova instead of rte_virt2phys for DPDK 17.11 2017-11-15 17:52:05 -05:00
iscsi.c iscsi: change the return value of ACL func to bool 2017-11-14 15:44:40 -05:00
iscsi.h iscsi: shutdown iscsi library as part of subsystem fini path 2017-11-13 14:57:49 -05:00
Makefile util: add CRC32 utility functions 2017-08-02 19:47:35 -04:00
md5.c include: Move the remainder of the code base to stdinc.h 2017-05-08 13:20:36 -07:00
md5.h include: Move the remainder of the code base to stdinc.h 2017-05-08 13:20:36 -07:00
param.c iscsi: remove global data members for non-configurable parameters 2017-11-03 12:18:02 -04:00
param.h include: Move the remainder of the code base to stdinc.h 2017-05-08 13:20:36 -07:00
portal_grp.c net&iscsi: force overwrite "*" and "[*]" by wildcard 2017-11-14 15:44:40 -05:00
portal_grp.h iscsi: login poller per portal and portal cache 2017-10-06 17:00:45 -04:00
task.c scsi: Remove cb_event. It is no longer necessary. 2017-06-22 10:47:31 -04:00
task.h iscsi: change iscsi_bhs_scsi_req variable names. 2017-07-18 13:14:16 -04:00
tgt_node.c iscsi: change the return value of ACL func to bool 2017-11-14 15:44:40 -05:00
tgt_node.h iscsi: change the return value of ACL func to bool 2017-11-14 15:44:40 -05:00