9c10093483
Commit aaba5d introduced a build warning with some
compilers. While fixing it, I realized the function was
difficult to immediately understand. So in addition to fixing
the build warning, I also made the following changes:
* Improved names for local variables
* Use TAILQ_INIT for local TAILQ instead of TAILQ_HEAD_INITIALIZER.
* Add comments explaining more clearly what the nested loops are
doing.
* Use TAILQ_SWAP instead of a FOREACH + REMOVE + INSERT.
Fixes: aaba5d ("subsystem: Gather list changed conditions.")
Fixes issue #2978.
Signed-off-by: Jim Harris <james.r.harris@intel.com>
Change-Id: Ic8740b5706537938d62a0acfac62625b2424b85f
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17496
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Mike Gerdts <mgerdts@nvidia.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Community-CI: Mellanox Build Bot
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
|
||
|---|---|---|
| .. | ||
| json_config.c | ||
| Makefile | ||
| rpc.c | ||
| spdk_init.map | ||
| subsystem_rpc.c | ||
| subsystem.c | ||
| subsystem.h | ||