7962ce312d
SPDK uses constructor functions for registration functionality in several different areas - RPCs, bdev modules, event tracing, etc. Since these functions are not explicitly referenced, the linker will remove these constructor functions from the linked application unless their library is included using the --whole-archive linker option. SPDK has tried to minimize the number of libraries linked with --whole-archive to only those that are necessary. But there are still a lot of exceptions that we need to work around. The benefit to trying to restrict it is minimal - for example, an nvmf_tgt binary built before this patch is 4746320 bytes on my system, but linking all of the libraries with --whole-archive only increases it to 4784080 bytes - a difference of less than 1%. Note that DPDK also links all libraries with --whole-archive by default. This will also simplify some upcoming changes around shared library dependencies - we will be able to blindly use --whole-archive when linking the shared library as well. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Iab0dbbace06a3d15c835491e55683ab4cf9e53fe Reviewed-on: https://review.gerrithub.io/432917 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
59 lines
2.0 KiB
Makefile
59 lines
2.0 KiB
Makefile
#
|
|
# BSD LICENSE
|
|
#
|
|
# Copyright (c) Intel Corporation.
|
|
# All rights reserved.
|
|
#
|
|
# Redistribution and use in source and binary forms, with or without
|
|
# modification, are permitted provided that the following conditions
|
|
# are met:
|
|
#
|
|
# * Redistributions of source code must retain the above copyright
|
|
# notice, this list of conditions and the following disclaimer.
|
|
# * Redistributions in binary form must reproduce the above copyright
|
|
# notice, this list of conditions and the following disclaimer in
|
|
# the documentation and/or other materials provided with the
|
|
# distribution.
|
|
# * Neither the name of Intel Corporation nor the names of its
|
|
# contributors may be used to endorse or promote products derived
|
|
# from this software without specific prior written permission.
|
|
#
|
|
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
#
|
|
|
|
include $(SPDK_ROOT_DIR)/mk/spdk.common.mk
|
|
include $(SPDK_ROOT_DIR)/mk/spdk.app.mk
|
|
include $(SPDK_ROOT_DIR)/mk/spdk.mock.unittest.mk
|
|
|
|
C_SRCS = $(TEST_FILE)
|
|
|
|
CFLAGS += -I$(SPDK_ROOT_DIR)/lib
|
|
CFLAGS += -I$(SPDK_ROOT_DIR)/test
|
|
|
|
SPDK_LIB_LIST += thread util log sock
|
|
|
|
LIBS += -lcunit $(SPDK_STATIC_LIB_LINKER_ARGS)
|
|
|
|
APP = $(TEST_FILE:.c=)
|
|
|
|
all: $(APP)
|
|
@:
|
|
|
|
$(APP) : $(OBJS) $(SPDK_LIB_FILES) $(ADDITIONAL_LIBS)
|
|
$(LINK_C)
|
|
|
|
clean:
|
|
$(CLEAN_C) $(APP)
|
|
|
|
include $(SPDK_ROOT_DIR)/mk/spdk.deps.mk
|