Spdk/test/bdev
Mike Gerdts c6ffad06fa test/bdev: improper check of mkfs.ext4 return
Before this fix, nbd_with_lvol_verify() would compare the string output
of mkfs.ext4 ("Dicarding device blocks...") with 0. If the shell does
not cast an invalid number to 0, test in the if statement will evaluate
to false.

The intent of the test in the if statement seems to be to check the exit
code from mkfs.ext4. This commit implements that assumed intent.
Additionally, mkfs_ret is now a local variable.

Signed-off-by: Mike Gerdts <mgerdts@nvidia.com>
Change-Id: I6c0de7b3f70674fb442abbcc9164f65a1ad55d40
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15276
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
Reviewed-by: Xinrui Mao <xinrui.mao@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2022-11-18 00:09:41 +00:00
..
bdevio add (c) and SPDX header to python files as needed 2022-11-10 08:28:53 +00:00
bdevperf bdevperf: promote bdevperf from test to example application 2022-11-16 09:52:41 +00:00
bdev_raid.sh module/raid: remove raid_cfg 2022-11-17 08:55:17 +00:00
blockdev.sh bdevperf: promote bdevperf from test to example application 2022-11-16 09:52:41 +00:00
Makefile bdevperf: promote bdevperf from test to example application 2022-11-16 09:52:41 +00:00
nbd_common.sh test/bdev: improper check of mkfs.ext4 return 2022-11-18 00:09:41 +00:00
nonarray.json json: fix parsing json problems when json config is invalid. 2022-09-02 07:32:21 +00:00
nonenclosed.json json: fix parsing json problems when json config is invalid. 2022-09-02 07:32:21 +00:00