Before this fix, nbd_with_lvol_verify() would compare the string output of mkfs.ext4 ("Dicarding device blocks...") with 0. If the shell does not cast an invalid number to 0, test in the if statement will evaluate to false. The intent of the test in the if statement seems to be to check the exit code from mkfs.ext4. This commit implements that assumed intent. Additionally, mkfs_ret is now a local variable. Signed-off-by: Mike Gerdts <mgerdts@nvidia.com> Change-Id: I6c0de7b3f70674fb442abbcc9164f65a1ad55d40 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/15276 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com> Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com> Reviewed-by: Xinrui Mao <xinrui.mao@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> |
||
---|---|---|
.. | ||
bdevio | ||
bdevperf | ||
bdev_raid.sh | ||
blockdev.sh | ||
Makefile | ||
nbd_common.sh | ||
nonarray.json | ||
nonenclosed.json |