ccdbd2ed51
nblocks is zero based, so read path was missing the increment. NVMe device that cuse represents can be of any block_size, so rather than hardcoding 512 - actually verify it. Both paths didn't request enough of a buffer from cuse. Reported-by: Niklas Cassel Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Change-Id: I228dc2572bc94ecbcb913e950d912a7ab5be9434 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4037 Community-CI: Broadcom CI Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
109 lines
3.1 KiB
Bash
Executable File
109 lines
3.1 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
|
|
testdir=$(readlink -f $(dirname $0))
|
|
rootdir=$(readlink -f $testdir/../../..)
|
|
source $rootdir/scripts/common.sh
|
|
source $rootdir/test/common/autotest_common.sh
|
|
|
|
rm -Rf $testdir/match_files
|
|
mkdir $testdir/match_files
|
|
|
|
KERNEL_OUT=$testdir/match_files/kernel.out
|
|
CUSE_OUT=$testdir/match_files/cuse.out
|
|
|
|
NVME_CMD=/usr/local/src/nvme-cli/nvme
|
|
rpc_py=$rootdir/scripts/rpc.py
|
|
|
|
bdf=$(get_first_nvme_bdf)
|
|
|
|
PCI_WHITELIST="${bdf}" $rootdir/scripts/setup.sh reset
|
|
sleep 1
|
|
nvme_name=$(get_nvme_ctrlr_from_bdf ${bdf})
|
|
if [[ -z "$nvme_name" ]]; then
|
|
echo "setup.sh failed bind kernel driver to ${bdf}"
|
|
return 1
|
|
fi
|
|
|
|
ctrlr="/dev/${nvme_name}"
|
|
ns="/dev/${nvme_name}n1"
|
|
|
|
waitforblk "${nvme_name}n1"
|
|
|
|
oacs=$(${NVME_CMD} id-ctrl $ctrlr | grep oacs | cut -d: -f2)
|
|
oacs_firmware=$((oacs & 0x4))
|
|
|
|
${NVME_CMD} get-ns-id $ns > ${KERNEL_OUT}.1
|
|
${NVME_CMD} id-ns $ns > ${KERNEL_OUT}.2
|
|
${NVME_CMD} list-ns $ns > ${KERNEL_OUT}.3
|
|
|
|
${NVME_CMD} id-ctrl $ctrlr > ${KERNEL_OUT}.4
|
|
${NVME_CMD} list-ctrl $ctrlr > ${KERNEL_OUT}.5
|
|
if [ "$oacs_firmware" -ne "0" ]; then
|
|
${NVME_CMD} fw-log $ctrlr > ${KERNEL_OUT}.6
|
|
fi
|
|
${NVME_CMD} smart-log $ctrlr
|
|
${NVME_CMD} error-log $ctrlr > ${KERNEL_OUT}.7
|
|
${NVME_CMD} get-feature $ctrlr -f 1 -s 1 -l 100 > ${KERNEL_OUT}.8
|
|
${NVME_CMD} get-log $ctrlr -i 1 -l 100 > ${KERNEL_OUT}.9
|
|
${NVME_CMD} reset $ctrlr > ${KERNEL_OUT}.10
|
|
|
|
$rootdir/scripts/setup.sh
|
|
|
|
$SPDK_BIN_DIR/spdk_tgt -m 0x3 &
|
|
spdk_tgt_pid=$!
|
|
trap 'kill -9 ${spdk_tgt_pid}; exit 1' SIGINT SIGTERM EXIT
|
|
|
|
waitforlisten $spdk_tgt_pid
|
|
|
|
$rpc_py bdev_nvme_attach_controller -b Nvme0 -t PCIe -a ${bdf}
|
|
$rpc_py bdev_nvme_cuse_register -n Nvme0
|
|
|
|
ctrlr="/dev/spdk/nvme0"
|
|
ns="${ctrlr}n1"
|
|
waitforfile "$ns"
|
|
|
|
$rpc_py bdev_get_bdevs
|
|
$rpc_py bdev_nvme_get_controllers
|
|
|
|
${NVME_CMD} get-ns-id $ns > ${CUSE_OUT}.1
|
|
${NVME_CMD} id-ns $ns > ${CUSE_OUT}.2
|
|
${NVME_CMD} list-ns $ns > ${CUSE_OUT}.3
|
|
|
|
${NVME_CMD} id-ctrl $ctrlr > ${CUSE_OUT}.4
|
|
${NVME_CMD} list-ctrl $ctrlr > ${CUSE_OUT}.5
|
|
if [ "$oacs_firmware" -ne "0" ]; then
|
|
${NVME_CMD} fw-log $ctrlr > ${CUSE_OUT}.6
|
|
fi
|
|
${NVME_CMD} smart-log $ctrlr
|
|
${NVME_CMD} error-log $ctrlr > ${CUSE_OUT}.7
|
|
${NVME_CMD} get-feature $ctrlr -f 1 -s 1 -l 100 > ${CUSE_OUT}.8
|
|
${NVME_CMD} get-log $ctrlr -i 1 -l 100 > ${CUSE_OUT}.9
|
|
${NVME_CMD} reset $ctrlr > ${CUSE_OUT}.10
|
|
|
|
for i in {1..10}; do
|
|
if [ -f "${KERNEL_OUT}.${i}" ] && [ -f "${CUSE_OUT}.${i}" ]; then
|
|
sed -i "s/${nvme_name}/nvme0/g" ${KERNEL_OUT}.${i}
|
|
diff --suppress-common-lines ${KERNEL_OUT}.${i} ${CUSE_OUT}.${i}
|
|
fi
|
|
done
|
|
|
|
rm -Rf $testdir/match_files
|
|
|
|
# Verify read/write path
|
|
tr < /dev/urandom -dc "a-zA-Z0-9" | fold -w 512 | head -n 1 > $testdir/write_file
|
|
${NVME_CMD} write $ns --data-size=512 --data=$testdir/write_file
|
|
${NVME_CMD} read $ns --data-size=512 --data=$testdir/read_file
|
|
diff --ignore-trailing-space $testdir/write_file $testdir/read_file
|
|
rm -f $testdir/write_file $testdir/read_file
|
|
|
|
# Verify admin cmd when no data is transferred,
|
|
# by creating and deleting completion queue.
|
|
${NVME_CMD} admin-passthru $ctrlr -o 5 --cdw10=0x3ff0003 --cdw11=0x1 -r
|
|
${NVME_CMD} admin-passthru $ctrlr -o 4 --cdw10=0x3
|
|
|
|
[[ -c "$ctrlr" ]]
|
|
[[ -c "$ns" ]]
|
|
|
|
trap - SIGINT SIGTERM EXIT
|
|
killprocess $spdk_tgt_pid
|