When the caller of the RPC API has all the necessary information about how to access a Ceph cluster, then having to create configuration files before calling the RPC API is problematic (has to touch files owned by a local admin, changes must be removed again). But having to encode support for certain configuration options in SPDK is also problematic, because that might change depending on the librados version. The approach taken here is to merely pass through arbitrary key/value config options. Existing config files are ignored when that happens. The caller of the RPC then has full control over the connection setup and can be sure that he does not inherit settings from a local file accidentally. In addition, user management is supported now, with or without a config. This is useful for accessing a volume with a less privileged user. Previously, passing NULL to rados_create implicitly chose the "admin" user. Change-Id: I5e7f36092df663a3d7ac503c04fc624a8fe1208e Signed-off-by: Patrick Ohly <patrick.ohly@intel.com> Reviewed-on: https://review.gerrithub.io/430460 Reviewed-by: Pawel Wodkowski <pawelx.wodkowski@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
209 lines
5.9 KiB
C
209 lines
5.9 KiB
C
/*-
|
|
* BSD LICENSE
|
|
*
|
|
* Copyright (c) Intel Corporation.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
*
|
|
* * Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in
|
|
* the documentation and/or other materials provided with the
|
|
* distribution.
|
|
* * Neither the name of Intel Corporation nor the names of its
|
|
* contributors may be used to endorse or promote products derived
|
|
* from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include "bdev_rbd.h"
|
|
#include "spdk/rpc.h"
|
|
#include "spdk/util.h"
|
|
#include "spdk/string.h"
|
|
#include "spdk_internal/log.h"
|
|
|
|
struct rpc_construct_rbd {
|
|
char *name;
|
|
char *user_id;
|
|
char *pool_name;
|
|
char *rbd_name;
|
|
uint32_t block_size;
|
|
char **config;
|
|
};
|
|
|
|
static void
|
|
free_rpc_construct_rbd(struct rpc_construct_rbd *req)
|
|
{
|
|
free(req->name);
|
|
free(req->user_id);
|
|
free(req->pool_name);
|
|
free(req->rbd_name);
|
|
spdk_bdev_rbd_free_config(req->config);
|
|
}
|
|
|
|
static int
|
|
spdk_bdev_rbd_decode_config(const struct spdk_json_val *values, void *out)
|
|
{
|
|
char ***map = out;
|
|
char **entry;
|
|
uint32_t i;
|
|
|
|
if (values->type == SPDK_JSON_VAL_NULL) {
|
|
/* treated like empty object: empty config */
|
|
*map = calloc(1, sizeof(**map));
|
|
if (!*map) {
|
|
return -1;
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
if (values->type != SPDK_JSON_VAL_OBJECT_BEGIN) {
|
|
return -1;
|
|
}
|
|
|
|
*map = calloc(values->len + 1, sizeof(**map));
|
|
if (!*map) {
|
|
return -1;
|
|
}
|
|
|
|
for (i = 0, entry = *map; i < values->len;) {
|
|
const struct spdk_json_val *name = &values[i + 1];
|
|
const struct spdk_json_val *v = &values[i + 2];
|
|
/* Here we catch errors like invalid types. */
|
|
if (!(entry[0] = spdk_json_strdup(name)) ||
|
|
!(entry[1] = spdk_json_strdup(v))) {
|
|
spdk_bdev_rbd_free_config(*map);
|
|
*map = NULL;
|
|
return -1;
|
|
}
|
|
i += 1 + spdk_json_val_len(v);
|
|
entry += 2;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct spdk_json_object_decoder rpc_construct_rbd_decoders[] = {
|
|
{"name", offsetof(struct rpc_construct_rbd, name), spdk_json_decode_string, true},
|
|
{"user_id", offsetof(struct rpc_construct_rbd, user_id), spdk_json_decode_string, true},
|
|
{"pool_name", offsetof(struct rpc_construct_rbd, pool_name), spdk_json_decode_string},
|
|
{"rbd_name", offsetof(struct rpc_construct_rbd, rbd_name), spdk_json_decode_string},
|
|
{"block_size", offsetof(struct rpc_construct_rbd, block_size), spdk_json_decode_uint32},
|
|
{"config", offsetof(struct rpc_construct_rbd, config), spdk_bdev_rbd_decode_config, true}
|
|
};
|
|
|
|
static void
|
|
spdk_rpc_construct_rbd_bdev(struct spdk_jsonrpc_request *request,
|
|
const struct spdk_json_val *params)
|
|
{
|
|
struct rpc_construct_rbd req = {};
|
|
struct spdk_json_write_ctx *w;
|
|
struct spdk_bdev *bdev;
|
|
|
|
if (spdk_json_decode_object(params, rpc_construct_rbd_decoders,
|
|
SPDK_COUNTOF(rpc_construct_rbd_decoders),
|
|
&req)) {
|
|
SPDK_DEBUGLOG(SPDK_LOG_BDEV_RBD, "spdk_json_decode_object failed\n");
|
|
goto invalid;
|
|
}
|
|
|
|
bdev = spdk_bdev_rbd_create(req.name, req.user_id, req.pool_name,
|
|
(const char *const *)req.config,
|
|
req.rbd_name,
|
|
req.block_size);
|
|
if (bdev == NULL) {
|
|
goto invalid;
|
|
}
|
|
|
|
free_rpc_construct_rbd(&req);
|
|
|
|
w = spdk_jsonrpc_begin_result(request);
|
|
if (w == NULL) {
|
|
return;
|
|
}
|
|
|
|
spdk_json_write_string(w, spdk_bdev_get_name(bdev));
|
|
spdk_jsonrpc_end_result(request, w);
|
|
return;
|
|
|
|
invalid:
|
|
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INVALID_PARAMS, "Invalid parameters");
|
|
free_rpc_construct_rbd(&req);
|
|
}
|
|
SPDK_RPC_REGISTER("construct_rbd_bdev", spdk_rpc_construct_rbd_bdev, SPDK_RPC_RUNTIME)
|
|
|
|
struct rpc_delete_rbd {
|
|
char *name;
|
|
};
|
|
|
|
static void
|
|
free_rpc_delete_rbd(struct rpc_delete_rbd *req)
|
|
{
|
|
free(req->name);
|
|
}
|
|
|
|
static const struct spdk_json_object_decoder rpc_delete_rbd_decoders[] = {
|
|
{"name", offsetof(struct rpc_delete_rbd, name), spdk_json_decode_string},
|
|
};
|
|
|
|
static void
|
|
_spdk_rpc_delete_rbd_bdev_cb(void *cb_arg, int bdeverrno)
|
|
{
|
|
struct spdk_jsonrpc_request *request = cb_arg;
|
|
struct spdk_json_write_ctx *w;
|
|
|
|
w = spdk_jsonrpc_begin_result(request);
|
|
if (w == NULL) {
|
|
return;
|
|
}
|
|
|
|
spdk_json_write_bool(w, bdeverrno == 0);
|
|
spdk_jsonrpc_end_result(request, w);
|
|
}
|
|
|
|
static void
|
|
spdk_rpc_delete_rbd_bdev(struct spdk_jsonrpc_request *request,
|
|
const struct spdk_json_val *params)
|
|
{
|
|
struct rpc_delete_rbd req = {NULL};
|
|
struct spdk_bdev *bdev;
|
|
int rc;
|
|
|
|
if (spdk_json_decode_object(params, rpc_delete_rbd_decoders,
|
|
SPDK_COUNTOF(rpc_delete_rbd_decoders),
|
|
&req)) {
|
|
rc = -EINVAL;
|
|
goto invalid;
|
|
}
|
|
|
|
bdev = spdk_bdev_get_by_name(req.name);
|
|
if (bdev == NULL) {
|
|
rc = -ENODEV;
|
|
goto invalid;
|
|
}
|
|
|
|
spdk_bdev_rbd_delete(bdev, _spdk_rpc_delete_rbd_bdev_cb, request);
|
|
free_rpc_delete_rbd(&req);
|
|
return;
|
|
|
|
invalid:
|
|
free_rpc_delete_rbd(&req);
|
|
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INVALID_PARAMS, spdk_strerror(-rc));
|
|
}
|
|
SPDK_RPC_REGISTER("delete_rbd_bdev", spdk_rpc_delete_rbd_bdev, SPDK_RPC_RUNTIME)
|