6b7e9d0af2
From SAM-4, section 5.13 (Sense Data); “When a command terminates with a CHECK CONDITION status, sense data shall be returned in the same I_T_L_Q nexus transaction (see 3.1.50) as the CHECK CONDITION status. After the sense data is returned, it shall be cleared except when it is associated with a unit attention condition and the UA_INTLCK_CTRL field in the Control mode page (see SPC-4) contains 10b or 11b.” SPDK does not set UA_INTLCK_CTRL to 10b or 11b, so we set the unit attention condition immediately against a single IO or Admin IO after reporting it via a CHECK CONDITION. Once the failed IO received at iSCSI initiator side, it will be retried. In the case of resize operation, if there is no IO from iSCSI initiator side, the unit attention condition will be delayed to report until the first IO is received at the iSCSI target side. Meanwhile, we clear the resizing (newly added) flag on our SCSI LUN structure after first time we report the resize unit attention condition. The kernel initiator won’t actually resize the corresponding block device automatically. It will report a uevent, and then you can set up udev rules to trigger a rescan. SPDK iSCSI initiator will automatically report the LUN size change. Change-Id: Ifc85b8d4d3fbea13e76fb5d1faf1ac6c8f662e6c Signed-off-by: GangCao <gang.cao@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11086 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Xiaodong Liu <xiaodong.liu@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
74 lines
2.3 KiB
Bash
Executable File
74 lines
2.3 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
|
|
testdir=$(readlink -f $(dirname $0))
|
|
rootdir=$(readlink -f $testdir/../../..)
|
|
source $rootdir/test/common/autotest_common.sh
|
|
source $rootdir/test/iscsi_tgt/common.sh
|
|
|
|
iscsitestinit
|
|
|
|
BDEV_SIZE=64
|
|
BDEV_NEW_SIZE=128
|
|
BLOCK_SIZE=512
|
|
RESIZE_SOCK="/var/tmp/spdk-resize.sock"
|
|
|
|
rpc_py="$rootdir/scripts/rpc.py"
|
|
|
|
timing_enter start_iscsi_tgt
|
|
|
|
# Remove the sock file first
|
|
rm -f $RESIZE_SOCK
|
|
|
|
"${ISCSI_APP[@]}" -m 0x2 -p 1 -s 512 --wait-for-rpc &
|
|
pid=$!
|
|
echo "iSCSI target launched. pid: $pid"
|
|
trap 'killprocess $pid; iscsitestfini; exit 1' SIGINT SIGTERM EXIT
|
|
waitforlisten $pid
|
|
$rpc_py framework_start_init
|
|
echo "iscsi_tgt is listening. Running tests..."
|
|
|
|
timing_exit start_iscsi_tgt
|
|
|
|
$rpc_py iscsi_create_portal_group $PORTAL_TAG $TARGET_IP:$ISCSI_PORT
|
|
$rpc_py iscsi_create_initiator_group $INITIATOR_TAG $INITIATOR_NAME $NETMASK
|
|
$rpc_py bdev_null_create Null0 $BDEV_SIZE $BLOCK_SIZE
|
|
# "Null0:0" ==> use Null0 blockdev for LUN0
|
|
# "1:2" ==> map PortalGroup1 to InitiatorGroup2
|
|
# "64" ==> iSCSI queue depth 64
|
|
# "-d" ==> disable CHAP authentication
|
|
$rpc_py iscsi_create_target_node disk1 disk1_alias 'Null0:0' $PORTAL_TAG:$INITIATOR_TAG 256 -d
|
|
sleep 1
|
|
trap 'killprocess $pid; iscsitestfini; exit 1' SIGINT SIGTERM EXIT
|
|
|
|
# Start bdevperf with another sock file and iSCSI initiator
|
|
"$rootdir/test/bdev/bdevperf/bdevperf" -r $RESIZE_SOCK --json <(initiator_json_config) -q 16 -o 4096 -w read -t 5 -R -s 128 -z &
|
|
bdevperf_pid=$!
|
|
waitforlisten $bdevperf_pid $RESIZE_SOCK
|
|
# Resize the Bdev from iSCSI target
|
|
$rpc_py bdev_null_resize Null0 $BDEV_NEW_SIZE
|
|
# Obtain the Bdev from bdevperf with iSCSI initiator
|
|
num_block=$($rpc_py -s $RESIZE_SOCK bdev_get_bdevs | grep num_blocks | sed 's/[^[:digit:]]//g')
|
|
# Size is not changed as no IO sent yet and resize notification is deferred.
|
|
total_size=$((num_block * BLOCK_SIZE / 1048576))
|
|
if [ $total_size != $BDEV_SIZE ]; then
|
|
echo "resize failed"
|
|
exit 1
|
|
fi
|
|
sleep 2
|
|
# Start the bdevperf IO
|
|
$rootdir/test/bdev/bdevperf/bdevperf.py -s $RESIZE_SOCK perform_tests
|
|
# Obtain the Bdev from bdevperf with iSCSI initiator
|
|
num_block=$($rpc_py -s $RESIZE_SOCK bdev_get_bdevs | grep num_blocks | sed 's/[^[:digit:]]//g')
|
|
# Get the new bdev size in MiB.
|
|
total_size=$((num_block * BLOCK_SIZE / 1048576))
|
|
if [ $total_size != $BDEV_NEW_SIZE ]; then
|
|
echo "resize failed"
|
|
exit 1
|
|
fi
|
|
|
|
trap - SIGINT SIGTERM EXIT
|
|
killprocess $bdevperf_pid
|
|
killprocess $pid
|
|
|
|
iscsitestfini
|