06fdd44c5d
By default, clang uses static sanitizer libraries, which means that the executable needs to have them linked in. Since we don't control how the fio binary is compiled, we need to use the shared libraries. This patch fixes ubsan, but there are still some issues with clang's address sanitizer. It seems as if the address sanitizer ignored some/all of the suppression rules, but in the interest of fixing the ubsan build, this will be fixed by a separate patch at a later time. Fixes #2367 Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com> Change-Id: I416a410214826b4ef8c25eeeef95272ef1742d7e Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/11662 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com> Community-CI: Mellanox Build Bot Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Dong Yi <dongx.yi@intel.com> Reviewed-by: Jun Wen <junx.wen@intel.com>
82 lines
2.8 KiB
Makefile
82 lines
2.8 KiB
Makefile
#
|
|
# BSD LICENSE
|
|
#
|
|
# Copyright (c) Intel Corporation.
|
|
# All rights reserved.
|
|
#
|
|
# Redistribution and use in source and binary forms, with or without
|
|
# modification, are permitted provided that the following conditions
|
|
# are met:
|
|
#
|
|
# * Redistributions of source code must retain the above copyright
|
|
# notice, this list of conditions and the following disclaimer.
|
|
# * Redistributions in binary form must reproduce the above copyright
|
|
# notice, this list of conditions and the following disclaimer in
|
|
# the documentation and/or other materials provided with the
|
|
# distribution.
|
|
# * Neither the name of Intel Corporation nor the names of its
|
|
# contributors may be used to endorse or promote products derived
|
|
# from this software without specific prior written permission.
|
|
#
|
|
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
#
|
|
|
|
include $(SPDK_ROOT_DIR)/mk/spdk.app_vars.mk
|
|
|
|
# Plugins go into build/example/
|
|
FIO_PLUGIN := $(SPDK_ROOT_DIR)/build/fio/$(notdir $(FIO_PLUGIN))
|
|
|
|
LIBS += $(SPDK_LIB_LINKER_ARGS)
|
|
|
|
CFLAGS += -I$(CONFIG_FIO_SOURCE_DIR)
|
|
# Compiling against fio 3.19 on latest FreeBSD generates warnings so we
|
|
# cannot use -Werror
|
|
ifeq ($(OS),FreeBSD)
|
|
CFLAGS += -Wno-error
|
|
else ifeq ($(CC_TYPE),clang)
|
|
CFLAGS += -Wno-error
|
|
endif
|
|
LDFLAGS += -shared -rdynamic -Wl,-z,nodelete
|
|
|
|
# By default, clang uses static sanitizer libraries, which means that the executable needs to have
|
|
# them linked in. Since we don't control how the fio binary is compiled, we need to use the shared
|
|
# libraries.
|
|
ifeq ($(CC_TYPE),clang)
|
|
ifneq ($(filter y,$(CONFIG_ASAN) $(CONFIG_UBSAN)),)
|
|
LDFLAGS += -shared-libsan
|
|
# clang's sanitizers aren't in ld's search path by default, so we need to add it manually
|
|
LDFLAGS += -Wl,-rpath=$(shell $(CC) -print-resource-dir)/lib
|
|
endif
|
|
endif
|
|
|
|
CLEAN_FILES = $(FIO_PLUGIN)
|
|
|
|
all : $(FIO_PLUGIN)
|
|
@:
|
|
|
|
install: empty_rule
|
|
|
|
uninstall: empty_rule
|
|
|
|
# To avoid overwriting warning
|
|
empty_rule:
|
|
@:
|
|
|
|
$(FIO_PLUGIN) : $(OBJS) $(SPDK_LIB_FILES) $(ENV_LIBS)
|
|
$(LINK_C)
|
|
|
|
clean :
|
|
$(CLEAN_C) $(CLEAN_FILES)
|
|
|
|
include $(SPDK_ROOT_DIR)/mk/spdk.deps.mk
|