Currently, error handling code in examples/nvme/identify frees the qpair before calling exit(). However, since every SPDK process starts off by triggering a reset (in state NVME_CTRLR_STATE_INIT), which causes all the qpairs to be deleted, there is not really a reason to do a nice cleanup on error. Additionally, other examples, e.g. examples/nvme/hello_world does not do a nice cleanup on error, so it is inconsistent if identify does so. Proper freeing of the qpairs is still done in the normal case where we don't get any errors (in this example, and in other examples). Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com> Change-Id: I0db612934464e6e84eaf466c12eb35eaa396e511 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4838 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> |
||
---|---|---|
.. | ||
accel | ||
bdev | ||
blob | ||
ioat | ||
nvme | ||
nvmf | ||
sock | ||
vmd | ||
Makefile |