spdk_bdev_queue_io_wait() can only be used when one of bdev submission functions returns ENOMEM (i.e. there are no more spdk_bdev_ios on that IO channel). Using it in any other case, e.g. on spdk_accel_append_*() returning ENOMEM, will most likely result in failure. Therefore, to avoid that, the IOs are completed with NOMEM status relying on the bdev layer to retry them. Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com> Change-Id: Ie0f03496e5d3180c481815b3f1b021e74ae2f46d Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17319 Community-CI: Mellanox Build Bot Reviewed-by: Jim Harris <james.r.harris@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
146 lines
4.7 KiB
Bash
Executable File
146 lines
4.7 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# SPDX-License-Identifier: BSD-3-Clause
|
|
# Copyright (C) 2023 Intel Corporation
|
|
# All rights reserved.
|
|
#
|
|
|
|
testdir=$(readlink -f $(dirname $0))
|
|
rootdir=$(readlink -f $testdir/../..)
|
|
|
|
# Use TCP as the default nvmf transport
|
|
TEST_TRANSPORT=${TEST_TRANSPORT:=tcp}
|
|
|
|
source "$rootdir/test/common/autotest_common.sh"
|
|
source "$rootdir/test/nvmf/common.sh"
|
|
|
|
nqn=nqn.2016-06.io.spdk:cnode0
|
|
key0=(00112233445566778899001122334455 11223344556677889900112233445500)
|
|
key1=(22334455667788990011223344550011 33445566778899001122334455001122)
|
|
declare -A stats
|
|
|
|
spdk_dd() {
|
|
local config
|
|
|
|
# Disable auto-examine to avoid seeing the examine callbacks' reads in accel stats
|
|
config=$("$rootdir/scripts/gen_nvme.sh" --mode=remote --json-with-subsystems \
|
|
--trid="$TEST_TRANSPORT:$NVMF_FIRST_TARGET_IP:$NVMF_PORT:$nqn" \
|
|
| jq '.subsystems[0].config[.subsystems[0].config | length] |=
|
|
{"method": "bdev_set_options", "params": {"bdev_auto_examine": false}}')
|
|
|
|
"$rootdir/build/bin/spdk_dd" -c <(echo "$config") "$@"
|
|
}
|
|
|
|
get_stat() {
|
|
local event opcode
|
|
|
|
event="$1" opcode="$2"
|
|
if [[ -z "$opcode" ]]; then
|
|
rpc_cmd accel_get_stats | jq -r ".$event"
|
|
else
|
|
rpc_cmd accel_get_stats \
|
|
| jq -r ".operations[] | select(.opcode == \"$opcode\").$event"
|
|
fi
|
|
}
|
|
|
|
update_stats() {
|
|
stats[sequence_executed]=$(get_stat sequence_executed)
|
|
stats[encrypt_executed]=$(get_stat executed encrypt)
|
|
stats[decrypt_executed]=$(get_stat executed decrypt)
|
|
stats[copy_executed]=$(get_stat executed copy)
|
|
}
|
|
|
|
tgtcleanup() {
|
|
[[ -v input ]] && rm -f "$input" || :
|
|
[[ -v output ]] && rm -f "$output" || :
|
|
nvmftestfini
|
|
}
|
|
|
|
bperfcleanup() {
|
|
[[ -v bperfpid ]] && killprocess $bperfpid
|
|
}
|
|
|
|
nvmftestinit
|
|
nvmfappstart -m 0x2
|
|
|
|
input=$(mktemp) output=$(mktemp)
|
|
trap 'tgtcleanup; exit 1' SIGINT SIGTERM EXIT
|
|
|
|
rpc_cmd <<- CONFIG
|
|
bdev_malloc_create 32 4096 -b malloc0
|
|
accel_crypto_key_create -c AES_XTS -k "${key0[0]}" -e "${key0[1]}" -n key0
|
|
accel_crypto_key_create -c AES_XTS -k "${key1[0]}" -e "${key1[1]}" -n key1
|
|
bdev_crypto_create malloc0 crypto0 -n key0
|
|
bdev_crypto_create crypto0 crypto1 -n key1
|
|
nvmf_create_transport $NVMF_TRANSPORT_OPTS
|
|
nvmf_create_subsystem $nqn -a
|
|
nvmf_subsystem_add_listener $nqn -t $TEST_TRANSPORT -a $NVMF_FIRST_TARGET_IP -s $NVMF_PORT
|
|
nvmf_subsystem_add_ns $nqn crypto1
|
|
CONFIG
|
|
|
|
# Remember initial stats
|
|
update_stats
|
|
|
|
# Write a single 64K request and check the stats
|
|
dd if=/dev/urandom of="$input" bs=1K count=64
|
|
spdk_dd --if "$input" --ob Nvme0n1 --bs $((64 * 1024)) --count 1
|
|
(($(get_stat sequence_executed) == stats[sequence_executed] + 1))
|
|
(($(get_stat executed encrypt) == stats[encrypt_executed] + 2))
|
|
(($(get_stat executed decrypt) == stats[decrypt_executed]))
|
|
# No copies should be done - the copy from the malloc should translate to changing encrypt's
|
|
# destination buffer
|
|
(($(get_stat executed copy) == stats[copy_executed]))
|
|
update_stats
|
|
|
|
# Now read that 64K, verify the stats and check that it matches what was written
|
|
spdk_dd --of "$output" --ib Nvme0n1 --bs $((64 * 1024)) --count 1
|
|
(($(get_stat sequence_executed) == stats[sequence_executed] + 1))
|
|
(($(get_stat executed encrypt) == stats[encrypt_executed]))
|
|
(($(get_stat executed decrypt) == stats[decrypt_executed] + 2))
|
|
(($(get_stat executed copy) == stats[copy_executed]))
|
|
cmp "$input" "$output"
|
|
spdk_dd --if /dev/zero --ob Nvme0n1 --bs $((64 * 1024)) --count 1
|
|
update_stats
|
|
|
|
# Now do the same using 4K requests
|
|
spdk_dd --if "$input" --ob Nvme0n1 --bs 4096 --count 16
|
|
(($(get_stat sequence_executed) == stats[sequence_executed] + 16))
|
|
(($(get_stat executed encrypt) == stats[encrypt_executed] + 32))
|
|
(($(get_stat executed decrypt) == stats[decrypt_executed]))
|
|
(($(get_stat executed copy) == stats[copy_executed]))
|
|
update_stats
|
|
|
|
# Check the reads
|
|
: > "$output"
|
|
spdk_dd --of "$output" --ib Nvme0n1 --bs 4096 --count 16
|
|
(($(get_stat sequence_executed) == stats[sequence_executed] + 16))
|
|
(($(get_stat executed encrypt) == stats[encrypt_executed]))
|
|
(($(get_stat executed decrypt) == stats[decrypt_executed] + 32))
|
|
(($(get_stat executed copy) == stats[copy_executed]))
|
|
cmp "$input" "$output"
|
|
|
|
trap - SIGINT SIGTERM EXIT
|
|
tgtcleanup
|
|
|
|
# Verify bdev crypto ENOMEM handling by setting low accel task count and sending IO with high qd
|
|
trap 'bperfcleanup; exit 1' SIGINT SIGTERM EXIT
|
|
|
|
"$rootdir/build/examples/bdevperf" -t 5 -w verify -o 4096 -q 256 --wait-for-rpc -z &
|
|
bperfpid=$!
|
|
|
|
waitforlisten $bperfpid
|
|
rpc_cmd <<- CONFIG
|
|
accel_set_options --task-count 16
|
|
framework_start_init
|
|
bdev_malloc_create 32 4096 -b malloc0
|
|
accel_crypto_key_create -c AES_XTS -k "${key0[0]}" -e "${key0[1]}" -n key0
|
|
accel_crypto_key_create -c AES_XTS -k "${key1[0]}" -e "${key1[1]}" -n key1
|
|
bdev_crypto_create malloc0 crypto0 -n key0
|
|
bdev_crypto_create crypto0 crypto1 -n key1
|
|
CONFIG
|
|
|
|
"$rootdir/examples/bdev/bdevperf/bdevperf.py" perform_tests
|
|
|
|
trap - SIGINT SIGTERM EXIT
|
|
killprocess $bperfpid
|
|
wait $bperfpid
|