2bb2afd085
spdk_bdev_unregister_by_name() is safer than spdk_bdev_get_by_name() + spdk_bdev_unregister(). It is ensured that the specified callback is executed after unwinding stack for spdk_bdev_unregister_by_name(). Signed-off-by: Shuhei Matsumoto <smatsumoto@nvidia.com> Change-Id: I5cc1e88a7e389ab173ef1195bd817d2aac6a70d1 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16556 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
116 lines
3.4 KiB
C
116 lines
3.4 KiB
C
/* SPDX-License-Identifier: BSD-3-Clause
|
|
* Copyright (C) 2020 Intel Corporation.
|
|
* Copyright (c) 2023 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
|
|
* All rights reserved.
|
|
*/
|
|
|
|
#include "vbdev_passthru.h"
|
|
#include "spdk/rpc.h"
|
|
#include "spdk/util.h"
|
|
#include "spdk/string.h"
|
|
#include "spdk/log.h"
|
|
|
|
/* Structure to hold the parameters for this RPC method. */
|
|
struct rpc_bdev_passthru_create {
|
|
char *base_bdev_name;
|
|
char *name;
|
|
};
|
|
|
|
/* Free the allocated memory resource after the RPC handling. */
|
|
static void
|
|
free_rpc_bdev_passthru_create(struct rpc_bdev_passthru_create *r)
|
|
{
|
|
free(r->base_bdev_name);
|
|
free(r->name);
|
|
}
|
|
|
|
/* Structure to decode the input parameters for this RPC method. */
|
|
static const struct spdk_json_object_decoder rpc_bdev_passthru_create_decoders[] = {
|
|
{"base_bdev_name", offsetof(struct rpc_bdev_passthru_create, base_bdev_name), spdk_json_decode_string},
|
|
{"name", offsetof(struct rpc_bdev_passthru_create, name), spdk_json_decode_string},
|
|
};
|
|
|
|
/* Decode the parameters for this RPC method and properly construct the passthru
|
|
* device. Error status returned in the failed cases.
|
|
*/
|
|
static void
|
|
rpc_bdev_passthru_create(struct spdk_jsonrpc_request *request,
|
|
const struct spdk_json_val *params)
|
|
{
|
|
struct rpc_bdev_passthru_create req = {NULL};
|
|
struct spdk_json_write_ctx *w;
|
|
int rc;
|
|
|
|
if (spdk_json_decode_object(params, rpc_bdev_passthru_create_decoders,
|
|
SPDK_COUNTOF(rpc_bdev_passthru_create_decoders),
|
|
&req)) {
|
|
SPDK_DEBUGLOG(vbdev_passthru, "spdk_json_decode_object failed\n");
|
|
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR,
|
|
"spdk_json_decode_object failed");
|
|
goto cleanup;
|
|
}
|
|
|
|
rc = bdev_passthru_external_create_disk(req.base_bdev_name, req.name);
|
|
if (rc != 0) {
|
|
spdk_jsonrpc_send_error_response(request, rc, spdk_strerror(-rc));
|
|
goto cleanup;
|
|
}
|
|
|
|
w = spdk_jsonrpc_begin_result(request);
|
|
spdk_json_write_string(w, req.name);
|
|
spdk_jsonrpc_end_result(request, w);
|
|
|
|
cleanup:
|
|
free_rpc_bdev_passthru_create(&req);
|
|
}
|
|
SPDK_RPC_REGISTER("construct_ext_passthru_bdev", rpc_bdev_passthru_create, SPDK_RPC_RUNTIME)
|
|
|
|
struct rpc_bdev_passthru_delete {
|
|
char *name;
|
|
};
|
|
|
|
static void
|
|
free_rpc_bdev_passthru_delete(struct rpc_bdev_passthru_delete *req)
|
|
{
|
|
free(req->name);
|
|
}
|
|
|
|
static const struct spdk_json_object_decoder rpc_bdev_passthru_delete_decoders[] = {
|
|
{"name", offsetof(struct rpc_bdev_passthru_delete, name), spdk_json_decode_string},
|
|
};
|
|
|
|
static void
|
|
rpc_bdev_passthru_delete_cb(void *cb_arg, int bdeverrno)
|
|
{
|
|
struct spdk_jsonrpc_request *request = cb_arg;
|
|
|
|
if (bdeverrno == 0) {
|
|
spdk_jsonrpc_send_bool_response(request, true);
|
|
} else {
|
|
spdk_jsonrpc_send_error_response(request, bdeverrno, spdk_strerror(-bdeverrno));
|
|
|
|
}
|
|
}
|
|
|
|
static void
|
|
rpc_bdev_passthru_delete(struct spdk_jsonrpc_request *request,
|
|
const struct spdk_json_val *params)
|
|
{
|
|
struct rpc_bdev_passthru_delete req = {NULL};
|
|
struct spdk_bdev *bdev;
|
|
|
|
if (spdk_json_decode_object(params, rpc_bdev_passthru_delete_decoders,
|
|
SPDK_COUNTOF(rpc_bdev_passthru_delete_decoders),
|
|
&req)) {
|
|
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR,
|
|
"spdk_json_decode_object failed");
|
|
goto cleanup;
|
|
}
|
|
|
|
bdev_passthru_external_delete_disk(req.name, rpc_bdev_passthru_delete_cb, request);
|
|
|
|
cleanup:
|
|
free_rpc_bdev_passthru_delete(&req);
|
|
}
|
|
SPDK_RPC_REGISTER("delete_ext_passthru_bdev", rpc_bdev_passthru_delete, SPDK_RPC_RUNTIME)
|