Support Aio bdev 'readonly' option in RPC call. The read-only flag can be dumped from the bdev info. Any writes on a read-only aio bdev will be fail. Signed-off-by: Yuhua <yuhua@smartx.com> Change-Id: I939f72479f8953a3678a8df3083ecce0f96844fb Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/14955 Reviewed-by: GangCao <gang.cao@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Mellanox Build Bot
169 lines
4.4 KiB
C
169 lines
4.4 KiB
C
/* SPDX-License-Identifier: BSD-3-Clause
|
|
* Copyright (c) Intel Corporation.
|
|
* All rights reserved.
|
|
*/
|
|
|
|
#include "bdev_aio.h"
|
|
#include "spdk/rpc.h"
|
|
#include "spdk/util.h"
|
|
#include "spdk/string.h"
|
|
#include "spdk/log.h"
|
|
|
|
struct rpc_construct_aio {
|
|
char *name;
|
|
char *filename;
|
|
uint32_t block_size;
|
|
bool readonly;
|
|
};
|
|
|
|
struct rpc_construct_aio_ctx {
|
|
struct rpc_construct_aio req;
|
|
struct spdk_jsonrpc_request *request;
|
|
};
|
|
|
|
static void
|
|
free_rpc_construct_aio(struct rpc_construct_aio_ctx *ctx)
|
|
{
|
|
free(ctx->req.name);
|
|
free(ctx->req.filename);
|
|
free(ctx);
|
|
}
|
|
|
|
static const struct spdk_json_object_decoder rpc_construct_aio_decoders[] = {
|
|
{"name", offsetof(struct rpc_construct_aio, name), spdk_json_decode_string},
|
|
{"filename", offsetof(struct rpc_construct_aio, filename), spdk_json_decode_string},
|
|
{"block_size", offsetof(struct rpc_construct_aio, block_size), spdk_json_decode_uint32, true},
|
|
{"readonly", offsetof(struct rpc_construct_aio, readonly), spdk_json_decode_bool, true},
|
|
};
|
|
|
|
static void
|
|
rpc_bdev_aio_create_cb(void *cb_arg)
|
|
{
|
|
struct rpc_construct_aio_ctx *ctx = cb_arg;
|
|
struct spdk_jsonrpc_request *request = ctx->request;
|
|
struct spdk_json_write_ctx *w;
|
|
|
|
w = spdk_jsonrpc_begin_result(request);
|
|
spdk_json_write_string(w, ctx->req.name);
|
|
spdk_jsonrpc_end_result(request, w);
|
|
free_rpc_construct_aio(ctx);
|
|
}
|
|
|
|
static void
|
|
rpc_bdev_aio_create(struct spdk_jsonrpc_request *request,
|
|
const struct spdk_json_val *params)
|
|
{
|
|
struct rpc_construct_aio_ctx *ctx;
|
|
int rc;
|
|
|
|
ctx = calloc(1, sizeof(*ctx));
|
|
if (!ctx) {
|
|
spdk_jsonrpc_send_error_response(request, -ENOMEM, spdk_strerror(ENOMEM));
|
|
return;
|
|
}
|
|
|
|
if (spdk_json_decode_object(params, rpc_construct_aio_decoders,
|
|
SPDK_COUNTOF(rpc_construct_aio_decoders),
|
|
&ctx->req)) {
|
|
SPDK_ERRLOG("spdk_json_decode_object failed\n");
|
|
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR,
|
|
"spdk_json_decode_object failed");
|
|
free_rpc_construct_aio(ctx);
|
|
return;
|
|
}
|
|
|
|
ctx->request = request;
|
|
rc = create_aio_bdev(ctx->req.name, ctx->req.filename, ctx->req.block_size, ctx->req.readonly);
|
|
if (rc) {
|
|
spdk_jsonrpc_send_error_response(request, rc, spdk_strerror(-rc));
|
|
free_rpc_construct_aio(ctx);
|
|
return;
|
|
}
|
|
|
|
spdk_bdev_wait_for_examine(rpc_bdev_aio_create_cb, ctx);
|
|
}
|
|
SPDK_RPC_REGISTER("bdev_aio_create", rpc_bdev_aio_create, SPDK_RPC_RUNTIME)
|
|
|
|
struct rpc_rescan_aio {
|
|
char *name;
|
|
};
|
|
|
|
static const struct spdk_json_object_decoder rpc_rescan_aio_decoders[] = {
|
|
{"name", offsetof(struct rpc_rescan_aio, name), spdk_json_decode_string},
|
|
};
|
|
|
|
static void
|
|
rpc_bdev_aio_rescan(struct spdk_jsonrpc_request *request,
|
|
const struct spdk_json_val *params)
|
|
{
|
|
struct rpc_rescan_aio req = {NULL};
|
|
int bdeverrno;
|
|
|
|
if (spdk_json_decode_object(params, rpc_rescan_aio_decoders,
|
|
SPDK_COUNTOF(rpc_rescan_aio_decoders),
|
|
&req)) {
|
|
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR,
|
|
"spdk_json_decode_object failed");
|
|
goto cleanup;
|
|
}
|
|
|
|
bdeverrno = bdev_aio_rescan(req.name);
|
|
if (bdeverrno) {
|
|
spdk_jsonrpc_send_error_response(request, bdeverrno,
|
|
spdk_strerror(-bdeverrno));
|
|
goto cleanup;
|
|
}
|
|
|
|
spdk_jsonrpc_send_bool_response(request, true);
|
|
cleanup:
|
|
free(req.name);
|
|
}
|
|
SPDK_RPC_REGISTER("bdev_aio_rescan", rpc_bdev_aio_rescan, SPDK_RPC_RUNTIME)
|
|
|
|
struct rpc_delete_aio {
|
|
char *name;
|
|
};
|
|
|
|
static void
|
|
free_rpc_delete_aio(struct rpc_delete_aio *r)
|
|
{
|
|
free(r->name);
|
|
}
|
|
|
|
static const struct spdk_json_object_decoder rpc_delete_aio_decoders[] = {
|
|
{"name", offsetof(struct rpc_delete_aio, name), spdk_json_decode_string},
|
|
};
|
|
|
|
static void
|
|
_rpc_bdev_aio_delete_cb(void *cb_arg, int bdeverrno)
|
|
{
|
|
struct spdk_jsonrpc_request *request = cb_arg;
|
|
|
|
if (bdeverrno == 0) {
|
|
spdk_jsonrpc_send_bool_response(request, true);
|
|
} else {
|
|
spdk_jsonrpc_send_error_response(request, bdeverrno, spdk_strerror(-bdeverrno));
|
|
}
|
|
}
|
|
|
|
static void
|
|
rpc_bdev_aio_delete(struct spdk_jsonrpc_request *request,
|
|
const struct spdk_json_val *params)
|
|
{
|
|
struct rpc_delete_aio req = {NULL};
|
|
|
|
if (spdk_json_decode_object(params, rpc_delete_aio_decoders,
|
|
SPDK_COUNTOF(rpc_delete_aio_decoders),
|
|
&req)) {
|
|
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR,
|
|
"spdk_json_decode_object failed");
|
|
goto cleanup;
|
|
}
|
|
|
|
bdev_aio_delete(req.name, _rpc_bdev_aio_delete_cb, request);
|
|
|
|
cleanup:
|
|
free_rpc_delete_aio(&req);
|
|
}
|
|
SPDK_RPC_REGISTER("bdev_aio_delete", rpc_bdev_aio_delete, SPDK_RPC_RUNTIME)
|