Due to the network issue, spdk_iscsi_conn_free_pdu in spdk_iscsi_conn_flush_pdus_internal will not be executed. So consider the pdu free, we should call spdk_iscsi_conn_free_pdu in spdk_iscsi_conn_free_tasks. Actually, for the task which in queued_datain_task, we have the following case: 1 The task is not sent to the scsi layer: it means that the task is not freed, so we should call spdk_iscsi_task_put here. 2 The task is sent to the scsi layer, but no subtasks are sent to the scsi layer: It means that the call back function (spdk_iscsi_task_cpl) will be called, but since it will have the subtask, so spdk_iscsi_task_put will not be called, thus, we should call spdk_iscsi_task_put here. 3 The task is sent to the scsi layer, and some subtasks are also sent to the scsi layer: It also mean that the spdk_iscsi_task_put will not be called in spdk_iscsi_task_cpl, and not all the subtasks will be finished, so the father task will not be freed, so we should still call spdk_iscsi_task_put here. 4 The task is sent to the scsi layer, and all the subtasks are also sent to the scsi layer, thus this task is not in the queued_data_in_task. So according to 1-4, we should call spdk_iscsi_task_put here, and also decrease the data_in_cnt; Change-Id: Icb13df1ae07f6eea0247d45f4a0397edc4aa2500 Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-on: https://review.gerrithub.io/420875 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> |
||
---|---|---|
.githooks | ||
app | ||
build/lib | ||
doc | ||
dpdk@c860b292c9 | ||
dpdkbuild | ||
etc/spdk | ||
examples | ||
go | ||
include | ||
intel-ipsec-mb@134c90c912 | ||
lib | ||
mk | ||
scripts | ||
shared_lib | ||
test | ||
.astylerc | ||
.gitignore | ||
.gitmodules | ||
.travis.yml | ||
autobuild.sh | ||
autopackage.sh | ||
autorun_post.py | ||
autorun.sh | ||
autotest.sh | ||
CHANGELOG.md | ||
CONFIG | ||
configure | ||
CONTRIBUTING.md | ||
ISSUE_TEMPLATE.md | ||
LICENSE | ||
Makefile | ||
README.md |
Storage Performance Development Kit
The Storage Performance Development Kit (SPDK) provides a set of tools and libraries for writing high performance, scalable, user-mode storage applications. It achieves high performance by moving all of the necessary drivers into userspace and operating in a polled mode instead of relying on interrupts, which avoids kernel context switches and eliminates interrupt handling overhead.
The development kit currently includes:
- NVMe driver
- I/OAT (DMA engine) driver
- NVMe over Fabrics target
- iSCSI target
- vhost target
- Virtio-SCSI driver
In this readme:
- Documentation
- Prerequisites
- Source Code
- Build
- Unit Tests
- Vagrant
- Advanced Build Options
- Hugepages and Device Binding
- Example Code
- Contributing
Documentation
Doxygen API documentation is available, as well as a Porting Guide for porting SPDK to different frameworks and operating systems.
Source Code
git clone https://github.com/spdk/spdk
cd spdk
git submodule update --init
Prerequisites
The dependencies can be installed automatically by scripts/pkgdep.sh
.
./scripts/pkgdep.sh
Build
Linux:
./configure
make
FreeBSD: Note: Make sure you have the matching kernel source in /usr/src/ and also note that CONFIG_COVERAGE option is not available right now for FreeBSD builds.
./configure
gmake
Unit Tests
./test/unit/unittest.sh
You will see several error messages when running the unit tests, but they are part of the test suite. The final message at the end of the script indicates success or failure.
Vagrant
A Vagrant setup is also provided to create a Linux VM with a virtual NVMe controller to get up and running quickly. Currently this has only been tested on MacOS and Ubuntu 16.04.2 LTS with the VirtualBox provider. The VirtualBox Extension Pack must also be installed in order to get the required NVMe support.
Details on the Vagrant setup can be found in the SPDK Vagrant documentation.
Advanced Build Options
Optional components and other build-time configuration are controlled by
settings in two Makefile fragments in the root of the repository. CONFIG
contains the base settings. Running the configure
script generates a new
file, CONFIG.local
, that contains overrides to the base CONFIG
file. For
advanced configuration, there are a number of additional options to configure
that may be used, or CONFIG.local
can simply be created and edited by hand. A
description of all possible options is located in CONFIG
.
Boolean (on/off) options are configured with a 'y' (yes) or 'n' (no). For
example, this line of CONFIG
controls whether the optional RDMA (libibverbs)
support is enabled:
CONFIG_RDMA?=n
To enable RDMA, this line may be added to CONFIG.local
with a 'y' instead of
'n'. For the majority of options this can be done using the configure
script.
For example:
./configure --with-rdma
Additionally, CONFIG
options may also be overrriden on the make
command
line:
make CONFIG_RDMA=y
Users may wish to use a version of DPDK different from the submodule included in the SPDK repository. To specify an alternate DPDK installation, run configure with the --with-dpdk option. For example:
Linux:
./configure --with-dpdk=/path/to/dpdk/x86_64-native-linuxapp-gcc
make
FreeBSD:
./configure --with-dpdk=/path/to/dpdk/x86_64-native-bsdapp-clang
gmake
The options specified on the make
command line take precedence over the
default values in CONFIG
and CONFIG.local
. This can be useful if you, for
example, generate a CONFIG.local
using the configure
script and then have
one or two options (i.e. debug builds) that you wish to turn on and off
frequently.
Hugepages and Device Binding
Before running an SPDK application, some hugepages must be allocated and any NVMe and I/OAT devices must be unbound from the native kernel drivers. SPDK includes a script to automate this process on both Linux and FreeBSD. This script should be run as root.
sudo scripts/setup.sh
Users may wish to configure a specific memory size. Below is an example of configuring 8192MB memory.
sudo HUGEMEM=8192 scripts/setup.sh
Example Code
Example code is located in the examples directory. The examples are compiled automatically as part of the build process. Simply call any of the examples with no arguments to see the help output. You'll likely need to run the examples as a privileged user (root) unless you've done additional configuration to grant your user permission to allocate huge pages and map devices through vfio.
Contributing
For additional details on how to get more involved in the community, including contributing code and participating in discussions and other activiites, please refer to spdk.io