44f69b654b
We have very frequent failures when we run test/nvmf/host/multipath.sh in the test pool. Call stack showed nvmf_stop_listen_disconnect_qpairs() accessed qpair->ctrlr even if qpair->ctrlr was NULL. nvmf_stop_listen_disconnect_qpairs() did not check if qpair->ctrlr is not NULL before accessing qpair->ctrlr->subsys. When a qpair is added to a poll group, qpair->ctrlr is cleared to NULL. The test code test/nvmf/host/multipath.sh executes multiple reconnects for path error. So a conflict might occur between adding a qpair to a poll group and disconnecting a qpair in a poll group. In this case, it may be acceptable even if we disconnect a qpair whose qpair->ctrlr is NULL. It will be better than SIGSEGV. Fixes one of the issues in #2300 Signed-off-by: Shuhei Matsumoto <shuheimatsumoto@gmail.com> Change-Id: I308fcb886dd410d01e3361c1850dec9a8eacbccf Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/10860 Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com> Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> |
||
|---|---|---|
| .. | ||
| ctrlr_bdev.c | ||
| ctrlr_discovery.c | ||
| ctrlr.c | ||
| fc_ls.c | ||
| fc.c | ||
| Makefile | ||
| nvmf_fc.h | ||
| nvmf_internal.h | ||
| nvmf_rpc.c | ||
| nvmf.c | ||
| rdma.c | ||
| spdk_nvmf.map | ||
| subsystem.c | ||
| tcp.c | ||
| transport.c | ||
| transport.h | ||
| vfio_user.c | ||