In current code there is no possibility to remove ocf instance permanently, even we call delete_ocf_bdev rpc command, on next examine this instance will be loaded. This patch introduces changes to delete_ocf_bdev rpc command. When we call this command via rpc, core related to particular vbdev will be removed from ocf cache before removing this cache instance. Thanks to that, on next examine we will not detect this core in cache metadata and therefore we will not create this instance on next load. However, in any other situation, we will not touch metadata, so in case of dirty shutdown/hot remove, on next load, we will recovery this instance. Signed-off-by: Marcin Dziegielewski <marcin.dziegielewski@intel.com> Change-Id: Iebef80989ea22ccea7f1b6ba4d734a40c1d5cc5d Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/465675 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Community-CI: Broadcom SPDK FC-NVMe CI <spdk-ci.pdl@broadcom.com>
327 lines
10 KiB
C
327 lines
10 KiB
C
/*-
|
|
* BSD LICENSE
|
|
*
|
|
* Copyright (c) Intel Corporation.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
*
|
|
* * Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in
|
|
* the documentation and/or other materials provided with the
|
|
* distribution.
|
|
* * Neither the name of Intel Corporation nor the names of its
|
|
* contributors may be used to endorse or promote products derived
|
|
* from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include "vbdev_ocf.h"
|
|
#include "stats.h"
|
|
#include "spdk/log.h"
|
|
#include "spdk/rpc.h"
|
|
#include "spdk/string.h"
|
|
|
|
/* Structure to hold the parameters for this RPC method. */
|
|
struct rpc_bdev_ocf_create {
|
|
char *name; /* master vbdev */
|
|
char *mode; /* OCF mode (choose one) */
|
|
char *cache_bdev_name; /* sub bdev */
|
|
char *core_bdev_name; /* sub bdev */
|
|
};
|
|
|
|
static void
|
|
free_rpc_bdev_ocf_create(struct rpc_bdev_ocf_create *r)
|
|
{
|
|
free(r->name);
|
|
free(r->core_bdev_name);
|
|
free(r->cache_bdev_name);
|
|
free(r->mode);
|
|
}
|
|
|
|
/* Structure to decode the input parameters for this RPC method. */
|
|
static const struct spdk_json_object_decoder rpc_bdev_ocf_create_decoders[] = {
|
|
{"name", offsetof(struct rpc_bdev_ocf_create, name), spdk_json_decode_string},
|
|
{"mode", offsetof(struct rpc_bdev_ocf_create, mode), spdk_json_decode_string},
|
|
{"cache_bdev_name", offsetof(struct rpc_bdev_ocf_create, cache_bdev_name), spdk_json_decode_string},
|
|
{"core_bdev_name", offsetof(struct rpc_bdev_ocf_create, core_bdev_name), spdk_json_decode_string},
|
|
};
|
|
|
|
static void
|
|
construct_cb(int status, struct vbdev_ocf *vbdev, void *cb_arg)
|
|
{
|
|
struct spdk_jsonrpc_request *request = cb_arg;
|
|
struct spdk_json_write_ctx *w;
|
|
|
|
if (status) {
|
|
spdk_jsonrpc_send_error_response_fmt(request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR,
|
|
"Could not create OCF vbdev: %d",
|
|
status);
|
|
} else {
|
|
w = spdk_jsonrpc_begin_result(request);
|
|
spdk_json_write_string(w, vbdev->name);
|
|
spdk_jsonrpc_end_result(request, w);
|
|
}
|
|
}
|
|
|
|
static void
|
|
spdk_rpc_bdev_ocf_create(struct spdk_jsonrpc_request *request,
|
|
const struct spdk_json_val *params)
|
|
{
|
|
struct rpc_bdev_ocf_create req = {NULL};
|
|
int ret;
|
|
|
|
ret = spdk_json_decode_object(params, rpc_bdev_ocf_create_decoders,
|
|
SPDK_COUNTOF(rpc_bdev_ocf_create_decoders),
|
|
&req);
|
|
if (ret) {
|
|
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INVALID_PARAMS,
|
|
"Invalid parameters");
|
|
free_rpc_bdev_ocf_create(&req);
|
|
return;
|
|
}
|
|
|
|
vbdev_ocf_construct(req.name, req.mode, req.cache_bdev_name, req.core_bdev_name, false,
|
|
construct_cb, request);
|
|
free_rpc_bdev_ocf_create(&req);
|
|
}
|
|
SPDK_RPC_REGISTER("bdev_ocf_create", spdk_rpc_bdev_ocf_create, SPDK_RPC_RUNTIME)
|
|
SPDK_RPC_REGISTER_ALIAS_DEPRECATED(bdev_ocf_create, construct_ocf_bdev)
|
|
|
|
/* Structure to hold the parameters for this RPC method. */
|
|
struct rpc_bdev_ocf_delete {
|
|
char *name; /* master vbdev name */
|
|
};
|
|
|
|
static void
|
|
free_rpc_bdev_ocf_delete(struct rpc_bdev_ocf_delete *r)
|
|
{
|
|
free(r->name);
|
|
}
|
|
|
|
/* Structure to decode the input parameters for this RPC method. */
|
|
static const struct spdk_json_object_decoder rpc_bdev_ocf_delete_decoders[] = {
|
|
{"name", offsetof(struct rpc_bdev_ocf_delete, name), spdk_json_decode_string},
|
|
};
|
|
|
|
static void
|
|
delete_cb(void *cb_arg, int status)
|
|
{
|
|
struct spdk_jsonrpc_request *request = cb_arg;
|
|
struct spdk_json_write_ctx *w;
|
|
|
|
if (status) {
|
|
spdk_jsonrpc_send_error_response_fmt(request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR,
|
|
"Could not delete OCF vbdev: %d",
|
|
status);
|
|
} else {
|
|
w = spdk_jsonrpc_begin_result(request);
|
|
spdk_json_write_bool(w, true);
|
|
spdk_jsonrpc_end_result(request, w);
|
|
}
|
|
}
|
|
|
|
static void
|
|
spdk_rpc_bdev_ocf_delete(struct spdk_jsonrpc_request *request,
|
|
const struct spdk_json_val *params)
|
|
{
|
|
struct rpc_bdev_ocf_delete req = {NULL};
|
|
struct vbdev_ocf *vbdev;
|
|
int status;
|
|
|
|
status = spdk_json_decode_object(params, rpc_bdev_ocf_delete_decoders,
|
|
SPDK_COUNTOF(rpc_bdev_ocf_delete_decoders),
|
|
&req);
|
|
if (status) {
|
|
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INVALID_PARAMS,
|
|
"Invalid parameters");
|
|
goto end;
|
|
}
|
|
|
|
vbdev = vbdev_ocf_get_by_name(req.name);
|
|
if (vbdev == NULL) {
|
|
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INVALID_PARAMS,
|
|
spdk_strerror(ENODEV));
|
|
goto end;
|
|
}
|
|
|
|
status = vbdev_ocf_delete_clean(vbdev, delete_cb, request);
|
|
if (status) {
|
|
spdk_jsonrpc_send_error_response_fmt(request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR,
|
|
"Could not delete OCF vbdev: %s",
|
|
spdk_strerror(-status));
|
|
goto end;
|
|
}
|
|
|
|
end:
|
|
free_rpc_bdev_ocf_delete(&req);
|
|
}
|
|
SPDK_RPC_REGISTER("bdev_ocf_delete", spdk_rpc_bdev_ocf_delete, SPDK_RPC_RUNTIME)
|
|
SPDK_RPC_REGISTER_ALIAS_DEPRECATED(bdev_ocf_delete, delete_ocf_bdev)
|
|
|
|
/* Structure to hold the parameters for this RPC method. */
|
|
struct rpc_bdev_ocf_get_stats {
|
|
char *name; /* master vbdev name */
|
|
};
|
|
|
|
static void
|
|
free_rpc_bdev_ocf_get_stats(struct rpc_bdev_ocf_get_stats *r)
|
|
{
|
|
free(r->name);
|
|
}
|
|
|
|
/* Structure to decode the input parameters for this RPC method. */
|
|
static const struct spdk_json_object_decoder rpc_bdev_ocf_get_stats_decoders[] = {
|
|
{"name", offsetof(struct rpc_bdev_ocf_get_stats, name), spdk_json_decode_string},
|
|
};
|
|
|
|
static void
|
|
spdk_rpc_bdev_ocf_get_stats(struct spdk_jsonrpc_request *request,
|
|
const struct spdk_json_val *params)
|
|
{
|
|
struct rpc_bdev_ocf_get_stats req = {NULL};
|
|
struct spdk_json_write_ctx *w;
|
|
struct vbdev_ocf *vbdev;
|
|
struct vbdev_ocf_stats stats;
|
|
int status;
|
|
|
|
if (spdk_json_decode_object(params, rpc_bdev_ocf_get_stats_decoders,
|
|
SPDK_COUNTOF(rpc_bdev_ocf_get_stats_decoders),
|
|
&req)) {
|
|
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INVALID_PARAMS,
|
|
"Invalid parameters");
|
|
goto end;
|
|
}
|
|
|
|
vbdev = vbdev_ocf_get_by_name(req.name);
|
|
if (vbdev == NULL) {
|
|
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INVALID_PARAMS,
|
|
spdk_strerror(ENODEV));
|
|
goto end;
|
|
}
|
|
|
|
status = vbdev_ocf_stats_get(vbdev->ocf_cache, vbdev->core.id, &stats);
|
|
if (status) {
|
|
spdk_jsonrpc_send_error_response_fmt(request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR,
|
|
"Could not get stats: %s",
|
|
spdk_strerror(-status));
|
|
goto end;
|
|
}
|
|
|
|
w = spdk_jsonrpc_begin_result(request);
|
|
vbdev_ocf_stats_write_json(w, &stats);
|
|
spdk_jsonrpc_end_result(request, w);
|
|
|
|
end:
|
|
free_rpc_bdev_ocf_get_stats(&req);
|
|
}
|
|
SPDK_RPC_REGISTER("bdev_ocf_get_stats", spdk_rpc_bdev_ocf_get_stats, SPDK_RPC_RUNTIME)
|
|
SPDK_RPC_REGISTER_ALIAS_DEPRECATED(bdev_ocf_get_stats, get_ocf_stats)
|
|
|
|
/* Structure to hold the parameters for this RPC method. */
|
|
struct rpc_bdev_ocf_get_bdevs {
|
|
char *name;
|
|
};
|
|
|
|
static void
|
|
free_rpc_bdev_ocf_get_bdevs(struct rpc_bdev_ocf_get_bdevs *r)
|
|
{
|
|
free(r->name);
|
|
}
|
|
|
|
/* Structure to decode the input parameters for this RPC method. */
|
|
static const struct spdk_json_object_decoder rpc_bdev_ocf_get_bdevs_decoders[] = {
|
|
{"name", offsetof(struct rpc_bdev_ocf_get_bdevs, name), spdk_json_decode_string, true},
|
|
};
|
|
|
|
struct bdev_get_bdevs_ctx {
|
|
char *name;
|
|
struct spdk_json_write_ctx *w;
|
|
};
|
|
|
|
static void
|
|
bdev_get_bdevs_fn(struct vbdev_ocf *vbdev, void *ctx)
|
|
{
|
|
struct bdev_get_bdevs_ctx *cctx = ctx;
|
|
struct spdk_json_write_ctx *w = cctx->w;
|
|
|
|
if (cctx->name != NULL &&
|
|
strcmp(vbdev->name, cctx->name) &&
|
|
strcmp(vbdev->cache.name, cctx->name) &&
|
|
strcmp(vbdev->core.name, cctx->name)) {
|
|
return;
|
|
}
|
|
|
|
spdk_json_write_object_begin(w);
|
|
spdk_json_write_named_string(w, "name", vbdev->name);
|
|
spdk_json_write_named_bool(w, "started", vbdev->state.started);
|
|
|
|
spdk_json_write_named_object_begin(w, "cache");
|
|
spdk_json_write_named_string(w, "name", vbdev->cache.name);
|
|
spdk_json_write_named_bool(w, "attached", vbdev->cache.attached);
|
|
spdk_json_write_object_end(w);
|
|
|
|
spdk_json_write_named_object_begin(w, "core");
|
|
spdk_json_write_named_string(w, "name", vbdev->core.name);
|
|
spdk_json_write_named_bool(w, "attached", vbdev->core.attached);
|
|
spdk_json_write_object_end(w);
|
|
|
|
spdk_json_write_object_end(w);
|
|
}
|
|
|
|
static void
|
|
spdk_rpc_bdev_ocf_get_bdevs(struct spdk_jsonrpc_request *request,
|
|
const struct spdk_json_val *params)
|
|
{
|
|
struct spdk_json_write_ctx *w;
|
|
struct rpc_bdev_ocf_get_bdevs req = {NULL};
|
|
struct bdev_get_bdevs_ctx cctx;
|
|
|
|
if (params && spdk_json_decode_object(params, rpc_bdev_ocf_get_bdevs_decoders,
|
|
SPDK_COUNTOF(rpc_bdev_ocf_get_bdevs_decoders),
|
|
&req)) {
|
|
spdk_jsonrpc_send_error_response(request, SPDK_JSONRPC_ERROR_INVALID_PARAMS,
|
|
"Invalid parameters");
|
|
goto end;
|
|
}
|
|
|
|
if (req.name) {
|
|
if (!(vbdev_ocf_get_by_name(req.name) || vbdev_ocf_get_base_by_name(req.name))) {
|
|
spdk_jsonrpc_send_error_response(request,
|
|
SPDK_JSONRPC_ERROR_INVALID_PARAMS,
|
|
spdk_strerror(ENODEV));
|
|
goto end;
|
|
}
|
|
}
|
|
|
|
w = spdk_jsonrpc_begin_result(request);
|
|
|
|
cctx.name = req.name;
|
|
cctx.w = w;
|
|
|
|
spdk_json_write_array_begin(w);
|
|
vbdev_ocf_foreach(bdev_get_bdevs_fn, &cctx);
|
|
spdk_json_write_array_end(w);
|
|
spdk_jsonrpc_end_result(request, w);
|
|
|
|
end:
|
|
free_rpc_bdev_ocf_get_bdevs(&req);
|
|
}
|
|
SPDK_RPC_REGISTER("bdev_ocf_get_bdevs", spdk_rpc_bdev_ocf_get_bdevs, SPDK_RPC_RUNTIME)
|
|
SPDK_RPC_REGISTER_ALIAS_DEPRECATED(bdev_ocf_get_bdevs, get_ocf_bdevs)
|