Many open source projects have moved to using SPDX identifiers to specify license information, reducing the amount of boilerplate code in every source file. This patch replaces the bulk of SPDK .c, .cpp and Makefiles with the BSD-3-Clause identifier. Almost all of these files share the exact same license text, and this patch only modifies the files that contain the most common license text. There can be slight variations because the third clause contains company names - most say "Intel Corporation", but there are instances for Nvidia, Samsung, Eideticom and even "the copyright holder". Used a bash script to automate replacement of the license text with SPDX identifier which is checked into scripts/spdx.sh. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Iaa88ab5e92ea471691dc298cfe41ebfb5d169780 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12904 Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com> Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Dong Yi <dongx.yi@intel.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: <qun.wan@intel.com>
228 lines
5.9 KiB
C
228 lines
5.9 KiB
C
/* SPDX-License-Identifier: BSD-3-Clause
|
|
* Copyright (c) Intel Corporation.
|
|
* All rights reserved.
|
|
* Copyright (c) 2021 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
|
|
*/
|
|
|
|
#include "spdk/stdinc.h"
|
|
|
|
#include "spdk_cunit.h"
|
|
|
|
#include "unit/lib/json_mock.c"
|
|
#include "init/subsystem.c"
|
|
#include "common/lib/test_env.c"
|
|
|
|
static struct spdk_subsystem g_ut_subsystems[8];
|
|
static struct spdk_subsystem_depend g_ut_subsystem_deps[8];
|
|
static int global_rc;
|
|
|
|
static void
|
|
ut_event_fn(int rc, void *arg1)
|
|
{
|
|
global_rc = rc;
|
|
}
|
|
|
|
static void
|
|
set_up_subsystem(struct spdk_subsystem *subsystem, const char *name)
|
|
{
|
|
subsystem->init = NULL;
|
|
subsystem->fini = NULL;
|
|
subsystem->name = name;
|
|
}
|
|
|
|
static void
|
|
set_up_depends(struct spdk_subsystem_depend *depend, const char *subsystem_name,
|
|
const char *depends_on_name)
|
|
{
|
|
depend->name = subsystem_name;
|
|
depend->depends_on = depends_on_name;
|
|
}
|
|
|
|
static void
|
|
subsystem_clear(void)
|
|
{
|
|
struct spdk_subsystem *subsystem, *subsystem_tmp;
|
|
struct spdk_subsystem_depend *subsystem_dep, *subsystem_dep_tmp;
|
|
|
|
TAILQ_FOREACH_SAFE(subsystem, &g_subsystems, tailq, subsystem_tmp) {
|
|
TAILQ_REMOVE(&g_subsystems, subsystem, tailq);
|
|
}
|
|
|
|
TAILQ_FOREACH_SAFE(subsystem_dep, &g_subsystems_deps, tailq, subsystem_dep_tmp) {
|
|
TAILQ_REMOVE(&g_subsystems_deps, subsystem_dep, tailq);
|
|
}
|
|
}
|
|
|
|
static void
|
|
subsystem_sort_test_depends_on_single(void)
|
|
{
|
|
struct spdk_subsystem *subsystem;
|
|
int i;
|
|
char subsystem_name[16];
|
|
|
|
global_rc = -1;
|
|
spdk_subsystem_init(ut_event_fn, NULL);
|
|
CU_ASSERT(global_rc == 0);
|
|
|
|
i = 4;
|
|
TAILQ_FOREACH(subsystem, &g_subsystems, tailq) {
|
|
snprintf(subsystem_name, sizeof(subsystem_name), "subsystem%d", i);
|
|
SPDK_CU_ASSERT_FATAL(i > 0);
|
|
i--;
|
|
CU_ASSERT(strcmp(subsystem_name, subsystem->name) == 0);
|
|
}
|
|
}
|
|
|
|
static void
|
|
subsystem_sort_test_depends_on_multiple(void)
|
|
{
|
|
int i;
|
|
struct spdk_subsystem *subsystem;
|
|
|
|
subsystem_clear();
|
|
set_up_subsystem(&g_ut_subsystems[0], "iscsi");
|
|
set_up_subsystem(&g_ut_subsystems[1], "nvmf");
|
|
set_up_subsystem(&g_ut_subsystems[2], "sock");
|
|
set_up_subsystem(&g_ut_subsystems[3], "bdev");
|
|
set_up_subsystem(&g_ut_subsystems[4], "rpc");
|
|
set_up_subsystem(&g_ut_subsystems[5], "scsi");
|
|
set_up_subsystem(&g_ut_subsystems[6], "interface");
|
|
set_up_subsystem(&g_ut_subsystems[7], "accel");
|
|
|
|
for (i = 0; i < 8; i++) {
|
|
spdk_add_subsystem(&g_ut_subsystems[i]);
|
|
}
|
|
|
|
set_up_depends(&g_ut_subsystem_deps[0], "bdev", "accel");
|
|
set_up_depends(&g_ut_subsystem_deps[1], "scsi", "bdev");
|
|
set_up_depends(&g_ut_subsystem_deps[2], "rpc", "interface");
|
|
set_up_depends(&g_ut_subsystem_deps[3], "sock", "interface");
|
|
set_up_depends(&g_ut_subsystem_deps[4], "nvmf", "interface");
|
|
set_up_depends(&g_ut_subsystem_deps[5], "iscsi", "scsi");
|
|
set_up_depends(&g_ut_subsystem_deps[6], "iscsi", "sock");
|
|
set_up_depends(&g_ut_subsystem_deps[7], "iscsi", "rpc");
|
|
|
|
for (i = 0; i < 8; i++) {
|
|
spdk_add_subsystem_depend(&g_ut_subsystem_deps[i]);
|
|
}
|
|
|
|
global_rc = -1;
|
|
spdk_subsystem_init(ut_event_fn, NULL);
|
|
CU_ASSERT(global_rc == 0);
|
|
|
|
subsystem = TAILQ_FIRST(&g_subsystems);
|
|
CU_ASSERT(strcmp(subsystem->name, "interface") == 0);
|
|
TAILQ_REMOVE(&g_subsystems, subsystem, tailq);
|
|
|
|
subsystem = TAILQ_FIRST(&g_subsystems);
|
|
CU_ASSERT(strcmp(subsystem->name, "accel") == 0);
|
|
TAILQ_REMOVE(&g_subsystems, subsystem, tailq);
|
|
|
|
subsystem = TAILQ_FIRST(&g_subsystems);
|
|
CU_ASSERT(strcmp(subsystem->name, "nvmf") == 0);
|
|
TAILQ_REMOVE(&g_subsystems, subsystem, tailq);
|
|
|
|
subsystem = TAILQ_FIRST(&g_subsystems);
|
|
CU_ASSERT(strcmp(subsystem->name, "sock") == 0);
|
|
TAILQ_REMOVE(&g_subsystems, subsystem, tailq);
|
|
|
|
subsystem = TAILQ_FIRST(&g_subsystems);
|
|
CU_ASSERT(strcmp(subsystem->name, "bdev") == 0);
|
|
TAILQ_REMOVE(&g_subsystems, subsystem, tailq);
|
|
|
|
subsystem = TAILQ_FIRST(&g_subsystems);
|
|
CU_ASSERT(strcmp(subsystem->name, "rpc") == 0);
|
|
TAILQ_REMOVE(&g_subsystems, subsystem, tailq);
|
|
|
|
subsystem = TAILQ_FIRST(&g_subsystems);
|
|
CU_ASSERT(strcmp(subsystem->name, "scsi") == 0);
|
|
TAILQ_REMOVE(&g_subsystems, subsystem, tailq);
|
|
|
|
subsystem = TAILQ_FIRST(&g_subsystems);
|
|
CU_ASSERT(strcmp(subsystem->name, "iscsi") == 0);
|
|
TAILQ_REMOVE(&g_subsystems, subsystem, tailq);
|
|
}
|
|
|
|
struct spdk_subsystem subsystem1 = {
|
|
.name = "subsystem1",
|
|
};
|
|
|
|
struct spdk_subsystem subsystem2 = {
|
|
.name = "subsystem2",
|
|
};
|
|
struct spdk_subsystem subsystem3 = {
|
|
.name = "subsystem3",
|
|
};
|
|
|
|
struct spdk_subsystem subsystem4 = {
|
|
.name = "subsystem4",
|
|
};
|
|
|
|
SPDK_SUBSYSTEM_REGISTER(subsystem1);
|
|
SPDK_SUBSYSTEM_REGISTER(subsystem2);
|
|
SPDK_SUBSYSTEM_REGISTER(subsystem3);
|
|
SPDK_SUBSYSTEM_REGISTER(subsystem4);
|
|
|
|
SPDK_SUBSYSTEM_DEPEND(subsystem1, subsystem2)
|
|
SPDK_SUBSYSTEM_DEPEND(subsystem2, subsystem3)
|
|
SPDK_SUBSYSTEM_DEPEND(subsystem3, subsystem4)
|
|
|
|
|
|
static void
|
|
subsystem_sort_test_missing_dependency(void)
|
|
{
|
|
/*
|
|
* A depends on B, but B is missing
|
|
*/
|
|
|
|
subsystem_clear();
|
|
set_up_subsystem(&g_ut_subsystems[0], "A");
|
|
spdk_add_subsystem(&g_ut_subsystems[0]);
|
|
|
|
set_up_depends(&g_ut_subsystem_deps[0], "A", "B");
|
|
spdk_add_subsystem_depend(&g_ut_subsystem_deps[0]);
|
|
|
|
global_rc = -1;
|
|
spdk_subsystem_init(ut_event_fn, NULL);
|
|
CU_ASSERT(global_rc != 0);
|
|
|
|
/*
|
|
* Dependency from C to A is defined, but C is missing
|
|
*/
|
|
|
|
subsystem_clear();
|
|
set_up_subsystem(&g_ut_subsystems[0], "A");
|
|
spdk_add_subsystem(&g_ut_subsystems[0]);
|
|
|
|
set_up_depends(&g_ut_subsystem_deps[0], "C", "A");
|
|
spdk_add_subsystem_depend(&g_ut_subsystem_deps[0]);
|
|
|
|
global_rc = -1;
|
|
spdk_subsystem_init(ut_event_fn, NULL);
|
|
CU_ASSERT(global_rc != 0);
|
|
|
|
}
|
|
|
|
int
|
|
main(int argc, char **argv)
|
|
{
|
|
CU_pSuite suite = NULL;
|
|
unsigned int num_failures;
|
|
|
|
CU_set_error_action(CUEA_ABORT);
|
|
CU_initialize_registry();
|
|
|
|
suite = CU_add_suite("subsystem_suite", NULL, NULL);
|
|
|
|
CU_ADD_TEST(suite, subsystem_sort_test_depends_on_single);
|
|
CU_ADD_TEST(suite, subsystem_sort_test_depends_on_multiple);
|
|
CU_ADD_TEST(suite, subsystem_sort_test_missing_dependency);
|
|
|
|
CU_basic_set_mode(CU_BRM_VERBOSE);
|
|
CU_basic_run_tests();
|
|
num_failures = CU_get_number_of_failures();
|
|
CU_cleanup_registry();
|
|
|
|
return num_failures;
|
|
}
|