2bfa860dfe
This patch fixes submission of partial IOs in bottom adapter Existing check (if offset > 0) was not sufficient to detect partial IOs because there could be an IO with offset = 0 but length < total size of iovs. This patch changes the check, but also free operation on completion because now the old free does not cover all situations when we allocate iovs. `Partial IOs` are the IOs handled by bottom adapter which specify only part of the internal iovs vector. So their length is less that the length of internal iovs vector. They exist because sometimes parts of single IO from top adapter need to be sent to different locations. Also, in general, IOs initiated by OCF (such as cleaner IOs) are represented as single big iov that is submitted by parts in form of 'Partial IOs'. Change-Id: I8ae47659fb34904c593a696d74d683a418ac9962 Signed-off-by: Vitaliy Mysak <vitaliy.mysak@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/455821 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
64 lines
2.1 KiB
C
64 lines
2.1 KiB
C
/*-
|
|
* BSD LICENSE
|
|
*
|
|
* Copyright (c) Intel Corporation.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
*
|
|
* * Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in
|
|
* the documentation and/or other materials provided with the
|
|
* distribution.
|
|
* * Neither the name of Intel Corporation nor the names of its
|
|
* contributors may be used to endorse or promote products derived
|
|
* from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#ifndef VBDEV_OCF_DOBJ_H
|
|
#define VBDEV_OCF_DOBJ_H
|
|
|
|
#include <ocf/ocf.h>
|
|
|
|
#include "ocf_env.h"
|
|
#include "ctx.h"
|
|
#include "data.h"
|
|
|
|
/* ocf_io context
|
|
* It is initialized from io size and offset */
|
|
struct ocf_io_ctx {
|
|
struct bdev_ocf_data *data;
|
|
struct spdk_io_channel *ch;
|
|
uint32_t offset;
|
|
int ref;
|
|
int rq_cnt;
|
|
int error;
|
|
bool iovs_allocated;
|
|
};
|
|
|
|
int vbdev_ocf_volume_init(void);
|
|
void vbdev_ocf_volume_cleanup(void);
|
|
|
|
static inline struct ocf_io_ctx *ocf_get_io_ctx(struct ocf_io *io)
|
|
{
|
|
return ocf_io_get_priv(io);
|
|
}
|
|
|
|
#endif
|